All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Daniel Palmer <daniel@0x0f.com>,
	linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] m68k: amiga: Mark amiga_reset() as __noreturn
Date: Mon, 29 Jun 2026 10:55:23 +0200	[thread overview]
Message-ID: <akIy-8N9QAOI53KN@linux.dev> (raw)
In-Reply-To: <CAMuHMdVMkDOK6baAm9cjYyuUCOWxu_OHE8+ftNwEU1rFfet7Ag@mail.gmail.com>

On Mon, Jun 29, 2026 at 09:25:48AM +0200, Geert Uytterhoeven wrote:
> Hi Thorsten,
> 
> Thanks for your patch!
> 
> On Fri, 26 Jun 2026 at 16:58, Thorsten Blum <thorsten.blum@linux.dev> wrote:
> > [PATCH v2] m68k: amiga: Mark amiga_reset() as __noreturn
> 
> This is not what this patch does, as amiga_reset() is already marked
> __noreturn.

I assumed __noreturn on the second prototype would be ignored, but it is
in fact additive.

> > Mark both the forward declaration and the function definition as
> > __noreturn, and remove the redundant redeclaration.
> 
> Why both? No other static function (except for xen_pv_play_dead)
> is tagged __noreturn in both the forward declaration and the
> implementation.

Can I blame the heat wave?

I'll send a v3 later.

Thanks,
Thorsten

      reply	other threads:[~2026-06-29  8:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26 14:57 [PATCH v2] m68k: amiga: Mark amiga_reset() as __noreturn Thorsten Blum
2026-06-26 15:07 ` Daniel Palmer
2026-06-26 15:12   ` Thorsten Blum
2026-06-29  7:25 ` Geert Uytterhoeven
2026-06-29  8:55   ` Thorsten Blum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akIy-8N9QAOI53KN@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=daniel@0x0f.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.