Re: [PATCH v2 v2 3/8] mmc: k1: add sdhci platform driver

[Peng Fan <peng.fan@oss.nxp.com>]

On Mon, Jun 29, 2026 at 11:51:17PM +0800, Eric Chung wrote:
>Add SDHCI platform driver support for SpacemiT K1 SoC. This driver
>implements the necessary platform-specific operations for the SDHCI
>controller, enabling MMC/SD card functionality on K1-based platforms.
>
>Signed-off-by: Eric Chung <eric.chung@riscstar.com>
>
>---
>v2:
>- Enable ADMA mode support.
>- Use CMD23 for multi-block read/write.
>- Move ASR/AIB register into pinctrl driver.
>- Correct pinctrl state from "fast" to "uhs".
>- Migrate tuning support from the spacemit linux driver.
>---
> drivers/mmc/Kconfig          |   7 +
> drivers/mmc/Makefile         |   1 +
> drivers/mmc/spacemit_sdhci.c | 681 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 689 insertions(+)
>
>diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
>index 131be3106a1..f05b376ab72 100644
>--- a/drivers/mmc/Kconfig
>+++ b/drivers/mmc/Kconfig
>@@ -722,6 +722,13 @@ config MMC_SDHCI_SNPS
> 
> 	  If unsure, say N.
> 
>+config MMC_SDHCI_SPACEMIT
>+	bool "Spacemit SDHCI controller"
>+	depends on MMC_SDHCI
>+	help
>+	  Support for Secure Digital Host Controller Interface (SDHCI) on
>+	  Spacemit K1 SoC.
>+
> config MMC_SDHCI_STI
> 	bool "SDHCI support for STMicroelectronics SoC"
> 	depends on MMC_SDHCI && OF_CONTROL && ARCH_STI
>diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile
>index a23336d7d8d..aa05cec23be 100644
>--- a/drivers/mmc/Makefile
>+++ b/drivers/mmc/Makefile
>@@ -71,6 +71,7 @@ obj-$(CONFIG_MMC_SDHCI_ROCKCHIP)	+= rockchip_sdhci.o
> obj-$(CONFIG_MMC_SDHCI_ADI)		+= adi_sdhci.o
> obj-$(CONFIG_MMC_SDHCI_S5P)		+= s5p_sdhci.o
> obj-$(CONFIG_MMC_SDHCI_SNPS)		+= snps_sdhci.o
>+obj-$(CONFIG_MMC_SDHCI_SPACEMIT)	+= spacemit_sdhci.o
> obj-$(CONFIG_MMC_SDHCI_STI)		+= sti_sdhci.o
> obj-$(CONFIG_MMC_SDHCI_TANGIER)		+= tangier_sdhci.o
> obj-$(CONFIG_MMC_SDHCI_TEGRA)		+= tegra_mmc.o
>diff --git a/drivers/mmc/spacemit_sdhci.c b/drivers/mmc/spacemit_sdhci.c
>new file mode 100644
>index 00000000000..c905c33b2af
>--- /dev/null
>+++ b/drivers/mmc/spacemit_sdhci.c
>@@ -0,0 +1,681 @@
>+// SPDX-License-Identifier: GPL-2.0+
>+/*
>+ * Driver for Spacemit K1 Mobile Storage Host Controller
>+ *
>+ * Copyright (C) 2023-2026 Spacemit Inc.
>+ * Copyright (C) 2026 RISCstar Ltd.
>+ */
>+
>+#define LOG_CATEGORY UCLASS_MMC
>+
>+#include <clk.h>
>+#include <dm.h>
>+#include <fdtdec.h>
>+#include <log.h>
>+#include <malloc.h>
>+#include <sdhci.h>
>+#include <reset-uclass.h>
>+#include <mapmem.h>
>+#include <dm/pinctrl.h>
>+#include <linux/libfdt.h>
>+#include <linux/delay.h>
>+#include <power/regulator.h>
>+
>+#define FIELD_PREP(mask, val)		(((val) << __ffs(mask)) & (mask))

Please use the one in bitfield.h

>+
>+
>+struct spacemit_sdhci_plat {
>+	struct mmc_config cfg;
>+	struct mmc mmc;
>+	struct reset_ctl_bulk resets;
>+	struct clk_bulk clks;
>+};
>+
>+struct spacemit_sdhci_priv {
>+	struct sdhci_host host;
>+};
>+
...
>+
>+	/* Wait for DLL lock */
>+	i = 0;
>+	while (i++ < 100) {
>+		if (sdhci_readl(host, SPACEMIT_SDHC_PHY_DLLSTS) & SDHC_DLL_LOCK_STATE)
>+			break;
>+		udelay(10);

Please use poll timeout.

>+	}
>+	if (i == 100) {
>+		log_err("%s: phy dll lock timeout\n", host->name);
>+		return -ETIMEDOUT;
>+	}
>+}
>+
>+static const struct udevice_id spacemit_sdhci_ids[] = {
>+	{
>+		.compatible = "spacemit,k1-sdhci",
>+		.data = 0,

No need set .data as 0.

>+	}, {
>+	}
>+};

Regards
Peng