Re: [PATCH 2/6] odb: make backend-specific fields optional

[Patrick Steinhardt <ps@pks.im>]

On Mon, Jun 29, 2026 at 12:25:21PM -0500, Justin Tobler wrote:
> On 26/06/24 02:19PM, Patrick Steinhardt wrote:
> > diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> > index 8726485f1f..adc626ce30 100644
> > --- a/builtin/cat-file.c
> > +++ b/builtin/cat-file.c
> > @@ -269,32 +301,20 @@ struct object_info {
> >  	 */
> >  	time_t *mtimep;
> >  
> > +	/*
> > +	 * Backend-specific information that tells the caller where exactly an
> > +	 * object was looked up from. This information should help disambiguate
> > +	 * object lookups in case the same object exists in multiple sources,
> > +	 * or multiple times in the same source.
> > +	 */
> > +	struct object_info_source *sourcep;
> 
> To me, the name `sourcep` makes me think a pointer to `struct
> odb_source`. This did confuse me slightly when initially reading, but
> I'm not sure it's worth it to be overly verbose here.

Yeah, good point. But as you say, I haven't been able to really come up
with a name that is not overly verbose. We could potentially rename the
structure itself to `odb_source_info` and then call the field itself
`source_infop`. Would that help?

Patrick