From: Petr Mladek <pmladek@suse.com>
To: Shihao Ren <rsh15355756202@163.com>
Cc: jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz,
joe.lawrence@redhat.com, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch/klp-build: Fix wrong index in error cleanup loop
Date: Thu, 2 Jul 2026 10:53:46 +0200 [thread overview]
Message-ID: <akYnGv_tDPouw8nM@pathway.suse.cz> (raw)
In-Reply-To: <20260701060655.2343093-1-rsh15355756202@163.com>
On Wed 2026-07-01 14:06:55, Shihao Ren wrote:
> In the funcs allocation failure path, the cleanup loop iterates with
> 'j' but frees objs[i].funcs, which uses the outer loop index 'i'
> instead of the loop variable 'j'. As a result the just-failed (NULL)
> entry is freed repeatedly, while the funcs buffers already allocated
> for objs[0..i-1] are leaked.
>
> Use objs[j].funcs so the previously allocated entries are correctly
> released.
>
> Fixes: 59adee07b568 ("livepatch/klp-build: Add stub init code for livepatch modules")
> Signed-off-by: Shihao Ren <rsh15355756202@163.com>
Great catch!
Reviewed-by: Petr Mladek <pmladek@suse.com>
I assume that Josh would take this together with other klp-build
related changes.
Best Regards,
Petr
prev parent reply other threads:[~2026-07-02 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 6:06 [PATCH] livepatch/klp-build: Fix wrong index in error cleanup loop Shihao Ren
2026-07-01 11:16 ` Miroslav Benes
2026-07-02 8:53 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akYnGv_tDPouw8nM@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=rsh15355756202@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.