Re: [PATCH v2 1/4] t1517: skip svn tests if svn is not installed2sy

["brian m. carlson" <sandals@crustytoothpaste.net>]

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On 2026-07-01 at 22:27:04, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > +test_lazy_prereq SVN '
> > +	test_have_prereq PERL && test -n "$NO_SVN_TESTS" && perl -w -e "
> > +		use SVN::Core;
> > +		use SVN::Repos;
> > +		\$SVN::Core::VERSION gt '1.1.0' or exit(42);
> > +	"
> > +'
> 
> If "have_prereq PERL" is not satisfied, SVN is not satisfied.

Correct.

> If NO_SVN_TESTS is an empty string (or unset), "test -n" fails, and
> SVN is not satisfied.  Questionable---am I misreading this part of
> the logic???

I think that's reversed, yes.

> The perl script would not barf only if use SVN::* succeed and then
> SVN::Core::VERSION is strictly better than '1.1.0'.  If not, i.e.,
> libsvn-perl is not available, or its version is older, then we fail
> with exit(42), and SVN is not satisfied.

Correct.  And yes, this came in from `t/lib-git-svn.sh`.  I'll probably
just simplify this to omit the version check since it's very unlikely
that anybody is using SVN 1.0 any more and, as Peff pointed out, this
doesn't actually work using a string comparison.
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]