From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Sunil V L <sunilvl@ventanamicro.com>,
Thomas Gleixner <tglx@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Anup Patel <anup@brainfault.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
loongarch@lists.linux.dev,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v3 1/7] ACPI: Add acpi_device_clear_dep() helper function
Date: Mon, 6 Jul 2026 10:46:55 +0200 [thread overview]
Message-ID: <aktrfyXrIeCL1eqp@lpieralisi> (raw)
In-Reply-To: <87jyrd6q0o.wl-maz@kernel.org>
On Thu, Jul 02, 2026 at 10:27:35PM +0100, Marc Zyngier wrote:
> On Wed, 01 Jul 2026 15:38:49 +0100,
> Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
> >
> > Code clearing device dependencies in ACPI in drivers through
> >
> > acpi_dev_clear_dependencies()
> >
> > requires annoying ifdeffery to make sure it is compiled out on
> > !CONFIG_ACPI configurations.
> >
> > Implement a wrapper function to clear device dependencies that can be used
> > in device drivers without conditional compilation.
> >
> > Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > ---
> > include/linux/acpi.h | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> > index 10d6c6c11bdf..4f950f5386d7 100644
> > --- a/include/linux/acpi.h
> > +++ b/include/linux/acpi.h
> > @@ -94,6 +94,12 @@ static inline void acpi_preset_companion(struct device *dev,
> > ACPI_COMPANION_SET(dev, acpi_find_child_device(parent, addr, false));
> > }
> >
> > +static inline void acpi_device_clear_dep(struct device *dev)
>
> uber nit: "clear_dep" is singular, while "clear_dependencies" is
> obviously plural. acpi_device_clear_deps() would look slightly
> clearer.
Hi Marc,
sure I will update it and respin a final version.
Thanks,
Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Anup Patel <anup@brainfault.org>,
Huacai Chen <chenhuacai@kernel.org>,
linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@kernel.org>,
linux-acpi@vger.kernel.org, Thomas Gleixner <tglx@kernel.org>,
loongarch@lists.linux.dev, Hanjun Guo <guohanjun@huawei.com>,
linux-riscv@lists.infradead.org, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v3 1/7] ACPI: Add acpi_device_clear_dep() helper function
Date: Mon, 6 Jul 2026 10:46:55 +0200 [thread overview]
Message-ID: <aktrfyXrIeCL1eqp@lpieralisi> (raw)
In-Reply-To: <87jyrd6q0o.wl-maz@kernel.org>
On Thu, Jul 02, 2026 at 10:27:35PM +0100, Marc Zyngier wrote:
> On Wed, 01 Jul 2026 15:38:49 +0100,
> Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
> >
> > Code clearing device dependencies in ACPI in drivers through
> >
> > acpi_dev_clear_dependencies()
> >
> > requires annoying ifdeffery to make sure it is compiled out on
> > !CONFIG_ACPI configurations.
> >
> > Implement a wrapper function to clear device dependencies that can be used
> > in device drivers without conditional compilation.
> >
> > Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > ---
> > include/linux/acpi.h | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> > index 10d6c6c11bdf..4f950f5386d7 100644
> > --- a/include/linux/acpi.h
> > +++ b/include/linux/acpi.h
> > @@ -94,6 +94,12 @@ static inline void acpi_preset_companion(struct device *dev,
> > ACPI_COMPANION_SET(dev, acpi_find_child_device(parent, addr, false));
> > }
> >
> > +static inline void acpi_device_clear_dep(struct device *dev)
>
> uber nit: "clear_dep" is singular, while "clear_dependencies" is
> obviously plural. acpi_device_clear_deps() would look slightly
> clearer.
Hi Marc,
sure I will update it and respin a final version.
Thanks,
Lorenzo
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-07-06 8:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 14:38 [PATCH v3 0/7] irqchip/ACPI: Arm GICv5 IWB ACPI IRQ probe deferral Lorenzo Pieralisi
2026-07-01 14:38 ` Lorenzo Pieralisi
2026-07-01 14:38 ` [PATCH v3 1/7] ACPI: Add acpi_device_clear_dep() helper function Lorenzo Pieralisi
2026-07-01 14:38 ` Lorenzo Pieralisi
2026-07-02 21:27 ` Marc Zyngier
2026-07-02 21:27 ` Marc Zyngier
2026-07-06 8:46 ` Lorenzo Pieralisi [this message]
2026-07-06 8:46 ` Lorenzo Pieralisi
2026-07-01 14:38 ` [PATCH v3 2/7] ACPI: RISC-V: Fix riscv_acpi_irq_get_dep() loop termination Lorenzo Pieralisi
2026-07-01 14:38 ` Lorenzo Pieralisi
2026-07-01 14:38 ` [PATCH v3 3/7] ACPI: RISC-V: Check acpi_get_handle() status in riscv_acpi_add_prt_dep() Lorenzo Pieralisi
2026-07-01 14:38 ` Lorenzo Pieralisi
2026-07-01 14:38 ` [PATCH v3 4/7] ACPI: RISC-V: Fix riscv_acpi_add_prt_dep() loop handling Lorenzo Pieralisi
2026-07-01 14:38 ` Lorenzo Pieralisi
2026-07-01 14:38 ` [PATCH v3 5/7] ACPI: irq: Move RISC-V interrupt controllers autodep to ACPI IRQ code Lorenzo Pieralisi
2026-07-01 14:38 ` Lorenzo Pieralisi
2026-07-01 14:38 ` [PATCH v3 6/7] ACPI/IORT: Implement ACPI infrastructure to enable GICv5 IWB probe deferral Lorenzo Pieralisi
2026-07-01 14:38 ` Lorenzo Pieralisi
2026-07-01 14:38 ` [PATCH v3 7/7] irqchip/gic-v5: Enable GICv5 IWB ACPI probe ordering detection Lorenzo Pieralisi
2026-07-01 14:38 ` Lorenzo Pieralisi
2026-07-02 21:49 ` Marc Zyngier
2026-07-02 21:49 ` Marc Zyngier
2026-07-02 21:55 ` Thomas Gleixner
2026-07-02 21:55 ` Thomas Gleixner
2026-07-02 21:56 ` Thomas Gleixner
2026-07-02 21:56 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aktrfyXrIeCL1eqp@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=anup@brainfault.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=maz@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.