* [PATCH] ui/vnc: remove redundant rows computation
@ 2026-07-21 15:28 marcandre.lureau
2026-07-21 15:46 ` Daniel P. Berrangé
2026-07-21 20:17 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: marcandre.lureau @ 2026-07-21 15:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau
From: Marc-André Lureau <marcandre.lureau@redhat.com>
"rows" was already computed in an earlier commit 3543c2b855 ("ui/vnc:
fix OOB write in vnc_refresh_lossy_rect").
Fixes: e650e4fe0f ("ui/vnc: fix out-of-bounds write in lossy refresh dirty marking")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/vnc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 24aa40f7308..656768f9c99 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3016,7 +3016,6 @@ static int vnc_refresh_lossy_rect(VncDisplay *vd, int x, int y,
y = QEMU_ALIGN_DOWN(y, VNC_STAT_RECT);
x = QEMU_ALIGN_DOWN(x, VNC_STAT_RECT);
- rows = MIN(VNC_STAT_RECT, height - y);
rows = MIN(VNC_STAT_RECT, height - y);
if (rows <= 0) {
--
2.55.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ui/vnc: remove redundant rows computation
2026-07-21 15:28 [PATCH] ui/vnc: remove redundant rows computation marcandre.lureau
@ 2026-07-21 15:46 ` Daniel P. Berrangé
2026-07-21 20:17 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2026-07-21 15:46 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel
On Tue, Jul 21, 2026 at 07:28:15PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> "rows" was already computed in an earlier commit 3543c2b855 ("ui/vnc:
> fix OOB write in vnc_refresh_lossy_rect").
>
> Fixes: e650e4fe0f ("ui/vnc: fix out-of-bounds write in lossy refresh dirty marking")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/vnc.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ui/vnc: remove redundant rows computation
2026-07-21 15:28 [PATCH] ui/vnc: remove redundant rows computation marcandre.lureau
2026-07-21 15:46 ` Daniel P. Berrangé
@ 2026-07-21 20:17 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-07-21 20:17 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel
On 21/7/26 17:28, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> "rows" was already computed in an earlier commit 3543c2b855 ("ui/vnc:
> fix OOB write in vnc_refresh_lossy_rect").
>
> Fixes: e650e4fe0f ("ui/vnc: fix out-of-bounds write in lossy refresh dirty marking")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/vnc.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-21 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-21 15:28 [PATCH] ui/vnc: remove redundant rows computation marcandre.lureau
2026-07-21 15:46 ` Daniel P. Berrangé
2026-07-21 20:17 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.