From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
axboe@kernel.dk, jack@suse.cz, brauner@kernel.org,
cem@kernel.org, jaegeuk@kernel.org, aalbersh@kernel.org,
tytso@mit.edu, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 3/5] xfs: report direct io attributes through file_getattr
Date: Mon, 13 Jul 2026 05:00:06 -0700 [thread overview]
Message-ID: <alTTRoOEglwuf4vg@infradead.org> (raw)
In-Reply-To: <20260710210646.3576365-4-kbusch@meta.com>
On Fri, Jul 10, 2026 at 02:06:44PM -0700, Keith Busch wrote:
> +static void
> +xfs_fill_fsxattr_dio(
> + struct xfs_inode *ip,
> + int whichfork,
> + struct file_kattr *fa)
> +{
> + struct xfs_buftarg *target;
Same alignment for the variables as for the arguments.
> +
> + if (whichfork != XFS_DATA_FORK || !S_ISREG(VFS_I(ip)->i_mode))
> + return;
Move this check to th caller? Although this and similar check in
the other file system patches miss block device nodes, for which we'd
need a special case, or one in the caller to override the attrs.
Or maybe using the file attr for this isn't actually a good idea,
and we should do an ioctl instead which automatically gets routed to
the block device fops?
> + target = xfs_inode_buftarg(ip);
.. and initialize the variable at declaration time?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: axboe@kernel.dk, linux-xfs@vger.kernel.org, brauner@kernel.org,
jack@suse.cz, cem@kernel.org, aalbersh@kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
tytso@mit.edu, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCHv2 3/5] xfs: report direct io attributes through file_getattr
Date: Mon, 13 Jul 2026 05:00:06 -0700 [thread overview]
Message-ID: <alTTRoOEglwuf4vg@infradead.org> (raw)
In-Reply-To: <20260710210646.3576365-4-kbusch@meta.com>
On Fri, Jul 10, 2026 at 02:06:44PM -0700, Keith Busch wrote:
> +static void
> +xfs_fill_fsxattr_dio(
> + struct xfs_inode *ip,
> + int whichfork,
> + struct file_kattr *fa)
> +{
> + struct xfs_buftarg *target;
Same alignment for the variables as for the arguments.
> +
> + if (whichfork != XFS_DATA_FORK || !S_ISREG(VFS_I(ip)->i_mode))
> + return;
Move this check to th caller? Although this and similar check in
the other file system patches miss block device nodes, for which we'd
need a special case, or one in the caller to override the attrs.
Or maybe using the file attr for this isn't actually a good idea,
and we should do an ioctl instead which automatically gets routed to
the block device fops?
> + target = xfs_inode_buftarg(ip);
.. and initialize the variable at declaration time?
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-07-13 12:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 21:06 [PATCHv2 0/5] direct-io file extended attributes Keith Busch
2026-07-10 21:06 ` [f2fs-dev] " Keith Busch via Linux-f2fs-devel
2026-07-10 21:06 ` [PATCHv2 1/5] fs: add direct io attributes to file_getattr Keith Busch
2026-07-10 21:06 ` [f2fs-dev] " Keith Busch via Linux-f2fs-devel
2026-07-13 10:14 ` Christoph Hellwig
2026-07-13 10:14 ` Christoph Hellwig
2026-07-10 21:06 ` [PATCHv2 2/5] block: report direct io attributes through file_getattr Keith Busch
2026-07-10 21:06 ` [f2fs-dev] " Keith Busch via Linux-f2fs-devel
2026-07-13 11:57 ` Christoph Hellwig
2026-07-13 11:57 ` Christoph Hellwig
2026-07-10 21:06 ` [PATCHv2 3/5] xfs: " Keith Busch
2026-07-10 21:06 ` [f2fs-dev] " Keith Busch via Linux-f2fs-devel
2026-07-13 12:00 ` Christoph Hellwig [this message]
2026-07-13 12:00 ` Christoph Hellwig
2026-07-14 21:09 ` Keith Busch
2026-07-14 21:09 ` [f2fs-dev] " Keith Busch via Linux-f2fs-devel
2026-07-10 21:06 ` [PATCHv2 4/5] ext4: " Keith Busch
2026-07-10 21:06 ` [f2fs-dev] " Keith Busch via Linux-f2fs-devel
2026-07-10 21:06 ` [PATCHv2 5/5] f2fs: " Keith Busch
2026-07-10 21:06 ` [f2fs-dev] " Keith Busch via Linux-f2fs-devel
2026-07-10 21:53 ` [f2fs-dev] [PATCHv2 0/5] direct-io file extended attributes Eric Biggers
2026-07-10 21:53 ` Eric Biggers via Linux-f2fs-devel
2026-07-10 22:58 ` Keith Busch
2026-07-10 22:58 ` Keith Busch via Linux-f2fs-devel
2026-07-11 0:24 ` Eric Biggers
2026-07-11 0:24 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-07-11 1:06 ` Keith Busch
2026-07-11 1:06 ` [f2fs-dev] " Keith Busch via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alTTRoOEglwuf4vg@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.