All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] json-parser: fix formatting of comment
@ 2026-07-13 11:46 Paolo Bonzini
  2026-07-13 12:16 ` Daniel P. Berrangé
  2026-07-13 12:32 ` Markus Armbruster
  0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2026-07-13 11:46 UTC (permalink / raw)
  To: qemu-devel; +Cc: armbru, qemu-trivial

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qobject/json-parser.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/qobject/json-parser.c b/qobject/json-parser.c
index 5935730c0c7..6b1b4762bda 100644
--- a/qobject/json-parser.c
+++ b/qobject/json-parser.c
@@ -29,9 +29,10 @@
  * object, an error, or NULL (if the object is incomplete and no error
  * happened) after every token.  Therefore it has an explicit
  * representation of its parser stack; each stack entry consists of a
- * parser state and a QObject: - a QList, for an array that is being
- * added to - a QDict, for a dictionary that is being added to - a
- * QString, for the key of the next pair that will be added to a QDict
+ * parser state and a QObject:
+ * - a QList, for an array that is being added to
+ * - a QDict, for a dictionary that is being added to
+ * - a QString, for the key of the next pair that will be added to a QDict
  *
  * The stack represents an arbitrary nesting of arrays and dictionaries
  * (whose next key has been parsed); it can also have a dictionary whose
-- 
2.54.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] json-parser: fix formatting of comment
  2026-07-13 11:46 [PATCH] json-parser: fix formatting of comment Paolo Bonzini
@ 2026-07-13 12:16 ` Daniel P. Berrangé
  2026-07-13 12:32 ` Markus Armbruster
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2026-07-13 12:16 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: qemu-devel, armbru, qemu-trivial

On Mon, Jul 13, 2026 at 01:46:22PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qobject/json-parser.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/qobject/json-parser.c b/qobject/json-parser.c
> index 5935730c0c7..6b1b4762bda 100644
> --- a/qobject/json-parser.c
> +++ b/qobject/json-parser.c
> @@ -29,9 +29,10 @@
>   * object, an error, or NULL (if the object is incomplete and no error
>   * happened) after every token.  Therefore it has an explicit
>   * representation of its parser stack; each stack entry consists of a
> - * parser state and a QObject: - a QList, for an array that is being
> - * added to - a QDict, for a dictionary that is being added to - a
> - * QString, for the key of the next pair that will be added to a QDict
> + * parser state and a QObject:
> + * - a QList, for an array that is being added to
> + * - a QDict, for a dictionary that is being added to
> + * - a QString, for the key of the next pair that will be added to a QDict

bike shedding a little....

  representation of its parser stack; each stack entry consists of a
  parser state and a QObject:
   - QList: an array that is being added to
   - QDict: a dictionary that is being added to
   - QString: the key of the next pair that will be added to a QDict


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] json-parser: fix formatting of comment
  2026-07-13 11:46 [PATCH] json-parser: fix formatting of comment Paolo Bonzini
  2026-07-13 12:16 ` Daniel P. Berrangé
@ 2026-07-13 12:32 ` Markus Armbruster
  1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2026-07-13 12:32 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: qemu-devel, armbru, qemu-trivial

Paolo Bonzini <pbonzini@redhat.com> writes:

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qobject/json-parser.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/qobject/json-parser.c b/qobject/json-parser.c
> index 5935730c0c7..6b1b4762bda 100644
> --- a/qobject/json-parser.c
> +++ b/qobject/json-parser.c
> @@ -29,9 +29,10 @@
>   * object, an error, or NULL (if the object is incomplete and no error
>   * happened) after every token.  Therefore it has an explicit
>   * representation of its parser stack; each stack entry consists of a
> - * parser state and a QObject: - a QList, for an array that is being
> - * added to - a QDict, for a dictionary that is being added to - a
> - * QString, for the key of the next pair that will be added to a QDict
> + * parser state and a QObject:
> + * - a QList, for an array that is being added to
> + * - a QDict, for a dictionary that is being added to
> + * - a QString, for the key of the next pair that will be added to a QDict
>   *
>   * The stack represents an arbitrary nesting of arrays and dictionaries
>   * (whose next key has been parsed); it can also have a dictionary whose

I screwed this up.  My apologies!

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Queued for 11.1.  Thanks!



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-13 12:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 11:46 [PATCH] json-parser: fix formatting of comment Paolo Bonzini
2026-07-13 12:16 ` Daniel P. Berrangé
2026-07-13 12:32 ` Markus Armbruster

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.