* [PATCH] tests/functional/riscv64: sifive_u: Fix kernel command line
@ 2026-07-13 12:02 Bin Meng
2026-07-13 12:11 ` Philippe Mathieu-Daudé
2026-07-13 15:48 ` Chao Liu
0 siblings, 2 replies; 3+ messages in thread
From: Bin Meng @ 2026-07-13 12:02 UTC (permalink / raw)
To: QEMU
Cc: Alistair Francis, Chao Liu, Daniel Henrique Barboza, Liu Zhiwei,
Palmer Dabbelt, Weiwei Li, qemu-riscv
Build the complete kernel command line before adding it to the QEMU
arguments. This ensures the panic, noreboot and rootwait options are
passed to the guest.
Fixes: 7db162fa0138 ("tests/functional: Test SPI-SD adapter without SD card connected")
Signed-off-by: Bin Meng <bin.meng@processmission.com>
---
tests/functional/riscv64/test_sifive_u.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/functional/riscv64/test_sifive_u.py b/tests/functional/riscv64/test_sifive_u.py
index 847f709da1..54a0f9c648 100755
--- a/tests/functional/riscv64/test_sifive_u.py
+++ b/tests/functional/riscv64/test_sifive_u.py
@@ -35,9 +35,6 @@ def do_test_riscv64_sifive_u_mmc_spi(self, connect_card):
kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
'earlycon=sbi console=ttySIF0 '
'root=/dev/mmcblk0 ')
- self.vm.add_args('-kernel', kernel_path,
- '-append', kernel_command_line,
- '-no-reboot')
if connect_card:
kernel_command_line += 'panic=-1 noreboot rootwait '
self.vm.add_args('-drive', f'file={rootfs_path},if=sd,format=raw')
@@ -46,6 +43,9 @@ def do_test_riscv64_sifive_u_mmc_spi(self, connect_card):
kernel_command_line += 'panic=0 noreboot '
pattern = 'Cannot open root device "mmcblk0" or unknown-block(0,0)'
+ self.vm.add_args('-kernel', kernel_path,
+ '-append', kernel_command_line,
+ '-no-reboot')
self.vm.launch()
self.wait_for_console_pattern(pattern)
---
base-commit: a759542a2c62f0fd3b65f5a66ad9868201014669
branch: sifive_u
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tests/functional/riscv64: sifive_u: Fix kernel command line
2026-07-13 12:02 [PATCH] tests/functional/riscv64: sifive_u: Fix kernel command line Bin Meng
@ 2026-07-13 12:11 ` Philippe Mathieu-Daudé
2026-07-13 15:48 ` Chao Liu
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-07-13 12:11 UTC (permalink / raw)
To: Bin Meng, QEMU
Cc: Alistair Francis, Chao Liu, Daniel Henrique Barboza, Liu Zhiwei,
Palmer Dabbelt, Weiwei Li, qemu-riscv
On 13/7/26 14:02, Bin Meng wrote:
> Build the complete kernel command line before adding it to the QEMU
> arguments. This ensures the panic, noreboot and rootwait options are
> passed to the guest.
>
> Fixes: 7db162fa0138 ("tests/functional: Test SPI-SD adapter without SD card connected")
> Signed-off-by: Bin Meng <bin.meng@processmission.com>
>
> ---
>
> tests/functional/riscv64/test_sifive_u.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tests/functional/riscv64: sifive_u: Fix kernel command line
2026-07-13 12:02 [PATCH] tests/functional/riscv64: sifive_u: Fix kernel command line Bin Meng
2026-07-13 12:11 ` Philippe Mathieu-Daudé
@ 2026-07-13 15:48 ` Chao Liu
1 sibling, 0 replies; 3+ messages in thread
From: Chao Liu @ 2026-07-13 15:48 UTC (permalink / raw)
To: Bin Meng
Cc: QEMU, Alistair Francis, Daniel Henrique Barboza, Liu Zhiwei,
Palmer Dabbelt, Weiwei Li, qemu-riscv
On Mon, Jul 13, 2026 at 08:02:44PM +0800, Bin Meng wrote:
> Build the complete kernel command line before adding it to the QEMU
> arguments. This ensures the panic, noreboot and rootwait options are
> passed to the guest.
>
> Fixes: 7db162fa0138 ("tests/functional: Test SPI-SD adapter without SD card connected")
> Signed-off-by: Bin Meng <bin.meng@processmission.com>
Reviewed-by: Chao Liu <chao.liu@processmission.com>
Thanks
Chao
>
> ---
>
> tests/functional/riscv64/test_sifive_u.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/functional/riscv64/test_sifive_u.py b/tests/functional/riscv64/test_sifive_u.py
> index 847f709da1..54a0f9c648 100755
> --- a/tests/functional/riscv64/test_sifive_u.py
> +++ b/tests/functional/riscv64/test_sifive_u.py
> @@ -35,9 +35,6 @@ def do_test_riscv64_sifive_u_mmc_spi(self, connect_card):
> kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
> 'earlycon=sbi console=ttySIF0 '
> 'root=/dev/mmcblk0 ')
> - self.vm.add_args('-kernel', kernel_path,
> - '-append', kernel_command_line,
> - '-no-reboot')
> if connect_card:
> kernel_command_line += 'panic=-1 noreboot rootwait '
> self.vm.add_args('-drive', f'file={rootfs_path},if=sd,format=raw')
> @@ -46,6 +43,9 @@ def do_test_riscv64_sifive_u_mmc_spi(self, connect_card):
> kernel_command_line += 'panic=0 noreboot '
> pattern = 'Cannot open root device "mmcblk0" or unknown-block(0,0)'
>
> + self.vm.add_args('-kernel', kernel_path,
> + '-append', kernel_command_line,
> + '-no-reboot')
> self.vm.launch()
> self.wait_for_console_pattern(pattern)
>
> ---
> base-commit: a759542a2c62f0fd3b65f5a66ad9868201014669
> branch: sifive_u
>
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-13 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 12:02 [PATCH] tests/functional/riscv64: sifive_u: Fix kernel command line Bin Meng
2026-07-13 12:11 ` Philippe Mathieu-Daudé
2026-07-13 15:48 ` Chao Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.