* [PATCH 01/43] power: reset: pwr-mlxbf: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 02/43] power: supply: 88pm860x_battery: " Pan Chuang
` (41 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel, open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/reset/pwr-mlxbf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/power/reset/pwr-mlxbf.c b/drivers/power/reset/pwr-mlxbf.c
index 15d92c9f64dd..459c2b7f3a21 100644
--- a/drivers/power/reset/pwr-mlxbf.c
+++ b/drivers/power/reset/pwr-mlxbf.c
@@ -68,8 +68,6 @@ static int pwr_mlxbf_probe(struct platform_device *pdev)
return err;
err = devm_request_irq(dev, irq, pwr_mlxbf_irq, 0, hid, priv);
- if (err)
- dev_err(dev, "Failed request of %s irq\n", priv->hid);
return err;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 02/43] power: supply: 88pm860x_battery: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 3:33 ` [PATCH 01/43] power: reset: pwr-mlxbf: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 03/43] power: supply: 88pm860x_charger: " Pan Chuang
` (40 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/88pm860x_battery.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/power/supply/88pm860x_battery.c b/drivers/power/supply/88pm860x_battery.c
index edae1e843c51..8d93c7a6a5f0 100644
--- a/drivers/power/supply/88pm860x_battery.c
+++ b/drivers/power/supply/88pm860x_battery.c
@@ -959,20 +959,14 @@ static int pm860x_battery_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(chip->dev, info->irq_cc, NULL,
pm860x_coulomb_handler, IRQF_ONESHOT,
"coulomb", info);
- if (ret < 0) {
- dev_err(chip->dev, "Failed to request IRQ: #%d: %d\n",
- info->irq_cc, ret);
+ if (ret < 0)
return ret;
- }
ret = devm_request_threaded_irq(chip->dev, info->irq_batt, NULL,
pm860x_batt_handler,
IRQF_ONESHOT, "battery", info);
- if (ret < 0) {
- dev_err(chip->dev, "Failed to request IRQ: #%d: %d\n",
- info->irq_batt, ret);
+ if (ret < 0)
return ret;
- }
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 03/43] power: supply: 88pm860x_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 3:33 ` [PATCH 01/43] power: reset: pwr-mlxbf: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-09 3:33 ` [PATCH 02/43] power: supply: 88pm860x_battery: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 04/43] power: supply: ab8500_btemp: " Pan Chuang
` (39 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/88pm860x_charger.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/power/supply/88pm860x_charger.c b/drivers/power/supply/88pm860x_charger.c
index 8d99c6ff72ed..47f95f31e472 100644
--- a/drivers/power/supply/88pm860x_charger.c
+++ b/drivers/power/supply/88pm860x_charger.c
@@ -716,11 +716,8 @@ static int pm860x_charger_probe(struct platform_device *pdev)
pm860x_irq_descs[i].handler,
IRQF_ONESHOT,
pm860x_irq_descs[i].name, info);
- if (ret < 0) {
- dev_err(chip->dev, "Failed to request IRQ: #%d: %d\n",
- info->irq[i], ret);
+ if (ret < 0)
return ret;
- }
}
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 04/43] power: supply: ab8500_btemp: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (2 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 03/43] power: supply: 88pm860x_charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-10 19:38 ` Linus Walleij
2026-07-09 3:33 ` [PATCH 05/43] power: supply: ab8500_charger: " Pan Chuang
` (38 subsequent siblings)
42 siblings, 1 reply; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Linus Walleij, Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/ab8500_btemp.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c
index e5202a7b6209..032140bd6682 100644
--- a/drivers/power/supply/ab8500_btemp.c
+++ b/drivers/power/supply/ab8500_btemp.c
@@ -787,11 +787,8 @@ static int ab8500_btemp_probe(struct platform_device *pdev)
IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT,
ab8500_btemp_irq[i].name, di);
- if (ret) {
- dev_err(dev, "failed to request %s IRQ %d: %d\n"
- , ab8500_btemp_irq[i].name, irq, ret);
+ if (ret)
return ret;
- }
dev_dbg(dev, "Requested %s IRQ %d: %d\n",
ab8500_btemp_irq[i].name, irq, ret);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 05/43] power: supply: ab8500_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (3 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 04/43] power: supply: ab8500_btemp: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-10 19:39 ` Linus Walleij
2026-07-09 3:33 ` [PATCH 06/43] power: supply: ab8500_fg: " Pan Chuang
` (37 subsequent siblings)
42 siblings, 1 reply; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Linus Walleij, Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/ab8500_charger.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
index 1813fbdfa1c1..bc6c070a564d 100644
--- a/drivers/power/supply/ab8500_charger.c
+++ b/drivers/power/supply/ab8500_charger.c
@@ -3605,11 +3605,8 @@ static int ab8500_charger_probe(struct platform_device *pdev)
IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT,
ab8500_charger_irq[i].name, di);
- if (ret != 0) {
- dev_err(dev, "failed to request %s IRQ %d: %d\n"
- , ab8500_charger_irq[i].name, irq, ret);
+ if (ret)
return ret;
- }
dev_dbg(dev, "Requested %s IRQ %d: %d\n",
ab8500_charger_irq[i].name, irq, ret);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 06/43] power: supply: ab8500_fg: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (4 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 05/43] power: supply: ab8500_charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-10 19:39 ` Linus Walleij
2026-07-09 3:33 ` [PATCH 07/43] power: supply: act8945a_charger: " Pan Chuang
` (36 subsequent siblings)
42 siblings, 1 reply; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Linus Walleij, Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/ab8500_fg.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c
index eb5c1ae68e44..f8f392592193 100644
--- a/drivers/power/supply/ab8500_fg.c
+++ b/drivers/power/supply/ab8500_fg.c
@@ -3178,8 +3178,6 @@ static int ab8500_fg_probe(struct platform_device *pdev)
ab8500_fg_irq[i].name, di);
if (ret != 0) {
- dev_err(dev, "failed to request %s IRQ %d: %d\n",
- ab8500_fg_irq[i].name, irq, ret);
destroy_workqueue(di->fg_wq);
return ret;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 07/43] power: supply: act8945a_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (5 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 06/43] power: supply: ab8500_fg: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 08/43] power: supply: axp20x_ac_power: " Pan Chuang
` (35 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/act8945a_charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/act8945a_charger.c b/drivers/power/supply/act8945a_charger.c
index 9dec4486b143..7e4b087f7679 100644
--- a/drivers/power/supply/act8945a_charger.c
+++ b/drivers/power/supply/act8945a_charger.c
@@ -620,10 +620,8 @@ static int act8945a_charger_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq, act8945a_status_changed,
IRQF_TRIGGER_FALLING, "act8945a_interrupt",
charger);
- if (ret) {
- dev_err(&pdev->dev, "failed to request nIRQ pin IRQ\n");
+ if (ret)
return ret;
- }
platform_set_drvdata(pdev, charger);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 08/43] power: supply: axp20x_ac_power: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (6 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 07/43] power: supply: act8945a_charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 09/43] power: supply: axp20x_usb_power: " Pan Chuang
` (34 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel, Chen-Yu Tsai,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS,
open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS
Cc: Pan Chuang
The devm_request_any_context_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() and dev_err_probe() calls that previously printed generic
messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/axp20x_ac_power.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/power/supply/axp20x_ac_power.c b/drivers/power/supply/axp20x_ac_power.c
index 5f6ea416fa30..474661ba7cf2 100644
--- a/drivers/power/supply/axp20x_ac_power.c
+++ b/drivers/power/supply/axp20x_ac_power.c
@@ -383,11 +383,8 @@ static int axp20x_ac_power_probe(struct platform_device *pdev)
ret = devm_request_any_context_irq(&pdev->dev, power->irqs[i],
axp20x_ac_power_irq, 0,
DRVNAME, power);
- if (ret < 0) {
- dev_err(&pdev->dev, "Error requesting %s IRQ: %d\n",
- axp_data->irq_names[i], ret);
+ if (ret < 0)
return ret;
- }
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 09/43] power: supply: axp20x_usb_power: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (7 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 08/43] power: supply: axp20x_ac_power: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 10/43] power: supply: axp288_charger: " Pan Chuang
` (33 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel, Chen-Yu Tsai,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS,
open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS
Cc: Pan Chuang
The devm_request_any_context_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() and dev_err_probe() calls that previously printed generic
messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/axp20x_usb_power.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
index e75d1e377ac1..29f105f9212d 100644
--- a/drivers/power/supply/axp20x_usb_power.c
+++ b/drivers/power/supply/axp20x_usb_power.c
@@ -1030,11 +1030,8 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
ret = devm_request_any_context_irq(&pdev->dev, power->irqs[i],
axp20x_usb_power_irq, 0,
DRVNAME, power);
- if (ret < 0) {
- dev_err(&pdev->dev, "Error requesting %s IRQ: %d\n",
- axp_data->irq_names[i], ret);
+ if (ret < 0)
return ret;
- }
}
if (axp20x_usb_vbus_needs_polling(power))
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 10/43] power: supply: axp288_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (8 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 09/43] power: supply: axp20x_usb_power: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 11/43] power: supply: axp288_fuel_gauge: " Pan Chuang
` (32 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel, Hans de Goede, Chen-Yu Tsai,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS,
open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/axp288_charger.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c
index 24a8b1ee2fec..8f2090356017 100644
--- a/drivers/power/supply/axp288_charger.c
+++ b/drivers/power/supply/axp288_charger.c
@@ -946,8 +946,7 @@ static int axp288_charger_probe(struct platform_device *pdev)
NULL, axp288_charger_irq_thread_handler,
IRQF_ONESHOT, info->pdev->name, info);
if (ret)
- return dev_err_probe(dev, ret, "failed to request interrupt=%d\n",
- info->irq[i]);
+ return ret;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 11/43] power: supply: axp288_fuel_gauge: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (9 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 10/43] power: supply: axp288_charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 12/43] power: supply: bq24190_charger: " Pan Chuang
` (31 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel, Chen-Yu Tsai, Hans de Goede,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS,
open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/axp288_fuel_gauge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
index 5af334c0a980..aa04c54ff97e 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -791,7 +791,7 @@ static int axp288_fuel_gauge_probe(struct platform_device *pdev)
fuel_gauge_thread_handler,
IRQF_ONESHOT, DEV_NAME, info);
if (ret)
- return dev_err_probe(dev, ret, "requesting IRQ %d\n", info->irq[i]);
+ return ret;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 12/43] power: supply: bq24190_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (10 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 11/43] power: supply: axp288_fuel_gauge: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 13/43] power: supply: bq24257_charger: " Pan Chuang
` (30 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/bq24190_charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
index 8e28f86ae09f..cbd29e9b32d2 100644
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -2169,10 +2169,8 @@ static int bq24190_probe(struct i2c_client *client)
bq24190_irq_handler_thread,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"bq24190-charger", bdi);
- if (ret < 0) {
- dev_err(dev, "Can't set up irq handler\n");
+ if (ret < 0)
goto out_charger;
- }
ret = bq24190_register_vbus_regulator(bdi);
if (ret < 0)
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 13/43] power: supply: bq24257_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (11 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 12/43] power: supply: bq24190_charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 14/43] power: supply: bq24735-charger: " Pan Chuang
` (29 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/bq24257_charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/bq24257_charger.c b/drivers/power/supply/bq24257_charger.c
index 72f1bfea8d54..d6286be4af74 100644
--- a/drivers/power/supply/bq24257_charger.c
+++ b/drivers/power/supply/bq24257_charger.c
@@ -1052,10 +1052,8 @@ static int bq24257_probe(struct i2c_client *client)
IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
bq->info->name, bq);
- if (ret) {
- dev_err(dev, "Failed to request IRQ #%d\n", client->irq);
+ if (ret)
return ret;
- }
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 14/43] power: supply: bq24735-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (12 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 13/43] power: supply: bq24257_charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 15/43] power: supply: bq256xx_charger: " Pan Chuang
` (28 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/bq24735-charger.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c
index 99abbaf0470f..22c2b86c3b30 100644
--- a/drivers/power/supply/bq24735-charger.c
+++ b/drivers/power/supply/bq24735-charger.c
@@ -462,12 +462,8 @@ static int bq24735_charger_probe(struct i2c_client *client)
IRQF_ONESHOT,
supply_desc->name,
charger->charger);
- if (ret) {
- dev_err(&client->dev,
- "Unable to register IRQ %d err %d\n",
- client->irq, ret);
+ if (ret)
return ret;
- }
} else {
ret = device_property_read_u32(&client->dev, "poll-interval",
&charger->poll_interval);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 15/43] power: supply: bq256xx_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (13 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 14/43] power: supply: bq24735-charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 16/43] power: supply: bq257xx_charger: " Pan Chuang
` (27 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/bq256xx_charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/supply/bq256xx_charger.c
index 5a6634fde837..4ea89b7897c8 100644
--- a/drivers/power/supply/bq256xx_charger.c
+++ b/drivers/power/supply/bq256xx_charger.c
@@ -1752,10 +1752,8 @@ static int bq256xx_probe(struct i2c_client *client)
IRQF_TRIGGER_FALLING |
IRQF_ONESHOT,
dev_name(&client->dev), bq);
- if (ret < 0) {
- dev_err(dev, "get irq fail: %d\n", ret);
+ if (ret < 0)
return ret;
- }
}
ret = bq256xx_hw_init(bq);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 16/43] power: supply: bq257xx_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (14 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 15/43] power: supply: bq256xx_charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 17/43] power: supply: cpcap-battery: " Pan Chuang
` (26 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/bq257xx_charger.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/bq257xx_charger.c
index 9c082865e745..10d242cdaa0a 100644
--- a/drivers/power/supply/bq257xx_charger.c
+++ b/drivers/power/supply/bq257xx_charger.c
@@ -753,8 +753,6 @@ static int bq257xx_charger_probe(struct platform_device *pdev)
IRQF_TRIGGER_FALLING |
IRQF_ONESHOT,
dev_name(&bq->client->dev), pdata);
- if (ret < 0)
- dev_err_probe(dev, ret, "Charger get irq failed\n");
}
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 17/43] power: supply: cpcap-battery: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (15 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 16/43] power: supply: bq257xx_charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 18/43] power: supply: cpcap-charger: " Pan Chuang
` (25 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/cpcap-battery.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 59c741993ef8..1d2b8bb08564 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -957,12 +957,8 @@ static int cpcap_battery_init_irq(struct platform_device *pdev,
cpcap_battery_irq_thread,
IRQF_SHARED | IRQF_ONESHOT,
name, ddata);
- if (error) {
- dev_err(ddata->dev, "could not get irq %s: %i\n",
- name, error);
-
+ if (error)
return error;
- }
d = devm_kzalloc(ddata->dev, sizeof(*d), GFP_KERNEL);
if (!d)
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 18/43] power: supply: cpcap-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (16 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 17/43] power: supply: cpcap-battery: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 19/43] power: supply: da9150-fg: " Pan Chuang
` (24 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/cpcap-charger.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
index ec8d2a9245d9..76e2d2e3f5f5 100644
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -761,12 +761,8 @@ static int cpcap_usb_init_irq(struct platform_device *pdev,
cpcap_charger_irq_thread,
IRQF_SHARED | IRQF_ONESHOT,
name, ddata);
- if (error) {
- dev_err(ddata->dev, "could not get irq %s: %i\n",
- name, error);
-
+ if (error)
return error;
- }
d = devm_kzalloc(ddata->dev, sizeof(*d), GFP_KERNEL);
if (!d)
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 19/43] power: supply: da9150-fg: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (17 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 18/43] power: supply: cpcap-charger: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:33 ` [PATCH 20/43] power: supply: generic-adc-battery: " Pan Chuang
` (23 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Support Opensource, Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/da9150-fg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
index 4f28ef1bba1a..7b2fa723acd9 100644
--- a/drivers/power/supply/da9150-fg.c
+++ b/drivers/power/supply/da9150-fg.c
@@ -524,10 +524,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
IRQF_ONESHOT, "FG", fg);
- if (ret) {
- dev_err(dev, "Failed to request IRQ %d: %d\n", irq, ret);
+ if (ret)
return ret;
- }
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 20/43] power: supply: generic-adc-battery: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (18 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 19/43] power: supply: da9150-fg: " Pan Chuang
@ 2026-07-09 3:33 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 21/43] power: supply: max14656_charger_detector: " Pan Chuang
` (22 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:33 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/generic-adc-battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
index f5f2566b3a32..6913179ebb84 100644
--- a/drivers/power/supply/generic-adc-battery.c
+++ b/drivers/power/supply/generic-adc-battery.c
@@ -246,7 +246,7 @@ static int gab_probe(struct platform_device *pdev)
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
"battery charged", adc_bat);
if (ret < 0)
- return dev_err_probe(&pdev->dev, ret, "Failed to register irq\n");
+ return ret;
}
platform_set_drvdata(pdev, adc_bat);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 21/43] power: supply: max14656_charger_detector: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (19 preceding siblings ...)
2026-07-09 3:33 ` [PATCH 20/43] power: supply: generic-adc-battery: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 22/43] power: supply: max77759_charger: " Pan Chuang
` (21 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/max14656_charger_detector.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/max14656_charger_detector.c b/drivers/power/supply/max14656_charger_detector.c
index 81798f22a037..f78d0341d0ef 100644
--- a/drivers/power/supply/max14656_charger_detector.c
+++ b/drivers/power/supply/max14656_charger_detector.c
@@ -287,10 +287,8 @@ static int max14656_probe(struct i2c_client *client)
ret = devm_request_irq(dev, chip->irq, max14656_irq,
IRQF_TRIGGER_FALLING,
MAX14656_NAME, chip);
- if (ret) {
- dev_err(dev, "request_irq %d failed\n", chip->irq);
+ if (ret)
return -EINVAL;
- }
enable_irq_wake(chip->irq);
schedule_delayed_work(&chip->irq_work, msecs_to_jiffies(2000));
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 22/43] power: supply: max77759_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (20 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 21/43] power: supply: max14656_charger_detector: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 23/43] power: supply: max8903_charger: " Pan Chuang
` (20 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Amit Sunil Dhamne, Sebastian Reichel,
open list:MAXIM MAX77759 BATTERY CHARGER DRIVER,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/max77759_charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/max77759_charger.c b/drivers/power/supply/max77759_charger.c
index 41d810bb6744..689fc733fa3f 100644
--- a/drivers/power/supply/max77759_charger.c
+++ b/drivers/power/supply/max77759_charger.c
@@ -532,9 +532,7 @@ static int max77759_init_irqhandler(struct max77759_charger *chg)
ret = devm_request_threaded_irq(dev, chg->irqs[i], NULL,
thread_fn, 0, name, chg);
if (ret)
- return dev_err_probe(dev, ret,
- "Unable to register irq handler for %s\n",
- chgr_irqs_str[i]);
+ return ret;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 23/43] power: supply: max8903_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (21 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 22/43] power: supply: max77759_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 24/43] power: supply: max8971_charger: " Pan Chuang
` (19 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/max8903_charger.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c
index 45fbaad6c647..47334bfc8381 100644
--- a/drivers/power/supply/max8903_charger.c
+++ b/drivers/power/supply/max8903_charger.c
@@ -364,11 +364,8 @@ static int max8903_probe(struct platform_device *pdev)
IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"MAX8903 DC IN", data);
- if (ret) {
- dev_err(dev, "Cannot request irq %d for DC (%d)\n",
- gpiod_to_irq(data->dok), ret);
+ if (ret)
return ret;
- }
}
if (data->uok) {
@@ -377,11 +374,8 @@ static int max8903_probe(struct platform_device *pdev)
IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"MAX8903 USB IN", data);
- if (ret) {
- dev_err(dev, "Cannot request irq %d for USB (%d)\n",
- gpiod_to_irq(data->uok), ret);
+ if (ret)
return ret;
- }
}
if (data->flt) {
@@ -390,11 +384,8 @@ static int max8903_probe(struct platform_device *pdev)
IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"MAX8903 Fault", data);
- if (ret) {
- dev_err(dev, "Cannot request irq %d for Fault (%d)\n",
- gpiod_to_irq(data->flt), ret);
+ if (ret)
return ret;
- }
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 24/43] power: supply: max8971_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (22 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 23/43] power: supply: max8903_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 25/43] power: supply: mp2629_charger: " Pan Chuang
` (18 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/max8971_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/max8971_charger.c b/drivers/power/supply/max8971_charger.c
index 82f20b89b6b4..0d69e9f44c05 100644
--- a/drivers/power/supply/max8971_charger.c
+++ b/drivers/power/supply/max8971_charger.c
@@ -683,7 +683,7 @@ static int max8971_probe(struct i2c_client *client)
err = devm_request_threaded_irq(dev, client->irq, NULL, &max8971_interrupt,
IRQF_ONESHOT | IRQF_SHARED, client->name, priv);
if (err)
- return dev_err_probe(dev, err, "failed to register IRQ %d\n", client->irq);
+ return err;
extcon = of_graph_get_remote_node(dev->of_node, -1, -1);
if (!extcon)
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 25/43] power: supply: mp2629_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (23 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 24/43] power: supply: max8971_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 26/43] power: supply: mt6360_charger: " Pan Chuang
` (17 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Saravanan Sekar, Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/mp2629_charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/mp2629_charger.c b/drivers/power/supply/mp2629_charger.c
index f758d6a7bc8c..04294359ed7d 100644
--- a/drivers/power/supply/mp2629_charger.c
+++ b/drivers/power/supply/mp2629_charger.c
@@ -630,10 +630,8 @@ static int mp2629_charger_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, NULL, mp2629_irq_handler,
IRQF_ONESHOT | IRQF_TRIGGER_RISING,
"mp2629-charger", charger);
- if (ret) {
- dev_err(dev, "failed to request gpio IRQ\n");
+ if (ret)
return ret;
- }
regmap_update_bits(charger->regmap, MP2629_REG_INTERRUPT,
GENMASK(6, 5), BIT(6) | BIT(5));
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 26/43] power: supply: mt6360_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (24 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 25/43] power: supply: mp2629_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 27/43] power: supply: mt6370-charger: " Pan Chuang
` (16 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel, Matthias Brugger, AngeloGioacchino Del Regno,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS,
open list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/mt6360_charger.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/power/supply/mt6360_charger.c b/drivers/power/supply/mt6360_charger.c
index d3b0731f6562..b4d462343151 100644
--- a/drivers/power/supply/mt6360_charger.c
+++ b/drivers/power/supply/mt6360_charger.c
@@ -721,8 +721,7 @@ static int mt6360_chg_irq_register(struct platform_device *pdev)
irq_descs[i].name,
platform_get_drvdata(pdev));
if (ret < 0)
- return dev_err_probe(&pdev->dev, ret, "Failed to request %s irq\n",
- irq_descs[i].name);
+ return ret;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 27/43] power: supply: mt6370-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (25 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 26/43] power: supply: mt6360_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 28/43] power: supply: pf1550-charger: " Pan Chuang
` (15 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel, Matthias Brugger, AngeloGioacchino Del Regno,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS,
open list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/mt6370-charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c
index 916556baa854..9d388bc53098 100644
--- a/drivers/power/supply/mt6370-charger.c
+++ b/drivers/power/supply/mt6370-charger.c
@@ -837,9 +837,7 @@ static int mt6370_chg_init_irq(struct mt6370_priv *priv)
IRQF_TRIGGER_FALLING,
dev_name(priv->dev), priv);
if (ret)
- return dev_err_probe(priv->dev, ret,
- "Failed to request irq %s\n",
- mt6370_chg_irqs[i].name);
+ return ret;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 28/43] power: supply: pf1550-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (26 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 27/43] power: supply: mt6370-charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:57 ` sashiko-bot
2026-07-14 0:24 ` Samuel Kayode
2026-07-09 3:34 ` [PATCH 29/43] power: supply: qcom_smbb: " Pan Chuang
` (14 subsequent siblings)
42 siblings, 2 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Samuel Kayode, Sebastian Reichel,
open list:NXP PF1550 PMIC MFD DRIVER,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/pf1550-charger.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/power/supply/pf1550-charger.c b/drivers/power/supply/pf1550-charger.c
index 41036f4cb64a..94fe81bab5a2 100644
--- a/drivers/power/supply/pf1550-charger.c
+++ b/drivers/power/supply/pf1550-charger.c
@@ -612,8 +612,7 @@ static int pf1550_charger_probe(struct platform_device *pdev)
IRQF_NO_SUSPEND,
"pf1550-charger", chg);
if (ret)
- return dev_err_probe(&pdev->dev, ret,
- "failed irq request\n");
+ return ret;
}
pf1550_dt_parse_dev_info(chg);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH 28/43] power: supply: pf1550-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:34 ` [PATCH 28/43] power: supply: pf1550-charger: " Pan Chuang
@ 2026-07-09 3:57 ` sashiko-bot
2026-07-14 0:24 ` Samuel Kayode
1 sibling, 0 replies; 49+ messages in thread
From: sashiko-bot @ 2026-07-09 3:57 UTC (permalink / raw)
To: Pan Chuang; +Cc: Frank.Li, imx
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
Pre-existing issues:
- [High] Inverted logic when turning on the charger based on battery presence in `pf1550_reg_init()`.
- [High] Use-after-free vulnerability during driver unbind or probe failure due to incorrect `devm` registration order.
- [High] Guaranteed probe failure for device trees omitting the optional `constant-charge-voltage-max-microvolt` property due to unhandled `-EINVAL`.
- [Medium] Resource leak of `struct power_supply_battery_info` due to uncalled `power_supply_put_battery_info()`.
--
--- Patch [28]: [PATCH 28/43] power: supply: pf1550-charger: Remove redundant dev_err()/dev_err_probe() ---
commit 7f7745c9eb293f3e6b24f5df79b35be592a07130
Author: Pan Chuang <panchuang@vivo.com>
power: supply: pf1550-charger: Remove redundant dev_err()/dev_err_probe()
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls.
> diff --git a/drivers/power/supply/pf1550-charger.c b/drivers/power/supply/pf1550-charger.c
> index 41036f4cb64a0..94fe81bab5a21 100644
> --- a/drivers/power/supply/pf1550-charger.c
> +++ b/drivers/power/supply/pf1550-charger.c
> @@ -612,8 +612,7 @@ static int pf1550_charger_probe(struct platform_device *pdev)
> IRQF_NO_SUSPEND,
> "pf1550-charger", chg);
> if (ret)
> - return dev_err_probe(&pdev->dev, ret,
> - "failed irq request\n");
> + return ret;
> }
>
> pf1550_dt_parse_dev_info(chg);
[Severity: High]
This is a pre-existing issue, but does this devm registration order leave
a use-after-free window during device unbind?
In drivers/power/supply/pf1550-charger.c:pf1550_charger_probe(), the delayed
works are registered before the power supplies:
ret = devm_delayed_work_autocancel(chg->dev, &chg->vbus_sense_work,
pf1550_chg_vbus_work);
...
chg->charger = devm_power_supply_register(&pdev->dev,
&pf1550_charger_desc,
&psy_cfg);
Since devres cleans up in reverse order, the power supplies will be freed
first. If pf1550_chg_vbus_work executes before the work is canceled, it
will call power_supply_changed(chg->battery) on a freed power supply
pointer.
[Severity: Medium]
This is a pre-existing issue, but does this code leak the battery info
structure?
Looking at pf1550_dt_parse_dev_info(), it calls power_supply_get_battery_info():
if (power_supply_get_battery_info(chg->charger, &info))
chg->constant_volt = PF1550_DEFAULT_CONSTANT_VOLT;
else
chg->constant_volt = info->constant_charge_voltage_max_uv;
The same call also occurs in pf1550_reg_init(). However, there are no
matching calls to power_supply_put_battery_info() in the driver to free the
memory allocated by these lookups.
[Severity: High]
This is a pre-existing issue, but does this code handle missing devicetree
properties correctly?
In pf1550_dt_parse_dev_info():
if (power_supply_get_battery_info(chg->charger, &info))
chg->constant_volt = PF1550_DEFAULT_CONSTANT_VOLT;
else
chg->constant_volt = info->constant_charge_voltage_max_uv;
If the devicetree lacks the optional constant-charge-voltage-max-microvolt
property, info->constant_charge_voltage_max_uv is set to -EINVAL. This
negative error code is then cast to the u32 chg->constant_volt, which
becomes 4294967274 and guarantees a failure in later upper-bound checks.
[Severity: High]
This is a pre-existing issue, but is the logic for enabling the charger
inverted here?
Looking at pf1550_reg_init():
if (power_supply_get_battery_info(chg->charger, &info)) {
ret = regmap_write(chg->pf1550->regmap,
PF1550_CHARG_REG_CHG_OPER,
PF1550_CHG_BAT_ON);
Since power_supply_get_battery_info() returns 0 on success and an error code
like -ENODEV on failure, this condition evaluates to true only when the
battery info lookup fails. This appears to turn on the charger exactly when
the battery is missing or misconfigured.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260709033428.362970-1-panchuang@vivo.com?part=28
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH 28/43] power: supply: pf1550-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:34 ` [PATCH 28/43] power: supply: pf1550-charger: " Pan Chuang
2026-07-09 3:57 ` sashiko-bot
@ 2026-07-14 0:24 ` Samuel Kayode
1 sibling, 0 replies; 49+ messages in thread
From: Samuel Kayode @ 2026-07-14 0:24 UTC (permalink / raw)
To: Pan Chuang
Cc: Sebastian Reichel, open list:NXP PF1550 PMIC MFD DRIVER,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
On Thu, Jul 09, 2026 at 11:34:07AM +0800, Pan Chuang wrote:
> The devm_request_threaded_irq() and devm_request_irq() now automatically
> log detailed error messages on failure. This eliminates the need for
> driver-specific dev_err() and dev_err_probe() calls that previously
> printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/power/supply/pf1550-charger.c | 3 +--
Reviewed-by: Samuel Kayode <samkay014@gmail.com>
Thanks,
Sam
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH 29/43] power: supply: qcom_smbb: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (27 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 28/43] power: supply: pf1550-charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 30/43] power: supply: qcom_smbx: " Pan Chuang
` (13 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel, open list:ARM/QUALCOMM MAILING LIST,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/qcom_smbb.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c
index 28afe758a2da..f33aab9619c4 100644
--- a/drivers/power/supply/qcom_smbb.c
+++ b/drivers/power/supply/qcom_smbb.c
@@ -937,11 +937,8 @@ static int smbb_charger_probe(struct platform_device *pdev)
rc = devm_request_threaded_irq(&pdev->dev, irq, NULL,
smbb_charger_irqs[i].handler, IRQF_ONESHOT,
smbb_charger_irqs[i].name, chg);
- if (rc) {
- dev_err(&pdev->dev, "failed to request irq '%s'\n",
- smbb_charger_irqs[i].name);
+ if (rc)
return rc;
- }
}
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 30/43] power: supply: qcom_smbx: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (28 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 29/43] power: supply: qcom_smbb: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 31/43] power: supply: rk817_charger: " Pan Chuang
` (12 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Casey Connolly, Sebastian Reichel,
open list:QUALCOMM SMB CHARGER DRIVER,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/qcom_smbx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/power/supply/qcom_smbx.c b/drivers/power/supply/qcom_smbx.c
index bf2e2ccc454a..7bda5cd77a75 100644
--- a/drivers/power/supply/qcom_smbx.c
+++ b/drivers/power/supply/qcom_smbx.c
@@ -922,8 +922,7 @@ static int smb_init_irq(struct smb_chip *chip, int *irq, const char *name,
rc = devm_request_threaded_irq(chip->dev, irqnum, NULL, handler,
IRQF_ONESHOT, name, chip);
if (rc < 0)
- return dev_err_probe(chip->dev, rc, "Couldn't request irq %s\n",
- name);
+ return rc;
if (irq)
*irq = irqnum;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 31/43] power: supply: rk817_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (29 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 30/43] power: supply: qcom_smbx: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 32/43] power: supply: rn5t618_power: " Pan Chuang
` (11 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/rk817_charger.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
index 9436c6bbf51f..5558b182a1a6 100644
--- a/drivers/power/supply/rk817_charger.c
+++ b/drivers/power/supply/rk817_charger.c
@@ -1186,19 +1186,15 @@ static int rk817_charger_probe(struct platform_device *pdev)
rk817_plug_in_isr,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"rk817_plug_in", charger);
- if (ret) {
- return dev_err_probe(&pdev->dev, ret,
- "plug_in_irq request failed!\n");
- }
+ if (ret)
+ return ret;
ret = devm_request_threaded_irq(charger->dev, plugout_irq, NULL,
rk817_plug_out_isr,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"rk817_plug_out", charger);
- if (ret) {
- return dev_err_probe(&pdev->dev, ret,
- "plug_out_irq request failed!\n");
- }
+ if (ret)
+ return ret;
ret = devm_delayed_work_autocancel(&pdev->dev, &charger->work,
rk817_charging_monitor);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 32/43] power: supply: rn5t618_power: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (30 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 31/43] power: supply: rk817_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 33/43] power: supply: rt9455_charger: " Pan Chuang
` (10 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/rn5t618_power.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/power/supply/rn5t618_power.c b/drivers/power/supply/rn5t618_power.c
index 40dec55a9f73..5963a55341ee 100644
--- a/drivers/power/supply/rn5t618_power.c
+++ b/drivers/power/supply/rn5t618_power.c
@@ -800,11 +800,8 @@ static int rn5t618_power_probe(struct platform_device *pdev)
"rn5t618_power",
&pdev->dev);
- if (ret < 0) {
- dev_err(&pdev->dev, "request IRQ:%d fail\n",
- info->irq);
+ if (ret < 0)
info->irq = -1;
- }
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 33/43] power: supply: rt9455_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (31 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 32/43] power: supply: rn5t618_power: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 34/43] power: supply: rt9467-charger: " Pan Chuang
` (9 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/rt9455_charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/rt9455_charger.c b/drivers/power/supply/rt9455_charger.c
index 7045d2908148..4f3a799db654 100644
--- a/drivers/power/supply/rt9455_charger.c
+++ b/drivers/power/supply/rt9455_charger.c
@@ -1676,10 +1676,8 @@ static int rt9455_probe(struct i2c_client *client)
rt9455_irq_handler_thread,
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
RT9455_DRIVER_NAME, info);
- if (ret) {
- dev_err(dev, "Failed to register IRQ handler\n");
+ if (ret)
goto put_usb_notifier;
- }
ret = rt9455_hw_init(info, ichrg, ieoc_percentage, mivr, iaicr);
if (ret) {
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 34/43] power: supply: rt9467-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (32 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 33/43] power: supply: rt9455_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 35/43] power: supply: rt9471: " Pan Chuang
` (8 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/rt9467-charger.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply/rt9467-charger.c
index de0471e54978..a9a83b263e18 100644
--- a/drivers/power/supply/rt9467-charger.c
+++ b/drivers/power/supply/rt9467-charger.c
@@ -1030,8 +1030,7 @@ static int rt9467_request_interrupt(struct rt9467_chg_data *data)
ret = devm_request_threaded_irq(dev, virq, NULL, chg_irqs[i].handler,
IRQF_ONESHOT, chg_irqs[i].name, data);
if (ret)
- return dev_err_probe(dev, ret, "Failed to request (%s) irq\n",
- chg_irqs[i].name);
+ return ret;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 35/43] power: supply: rt9471: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (33 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 34/43] power: supply: rt9467-charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 36/43] power: supply: sbs-charger: " Pan Chuang
` (7 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/rt9471.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/power/supply/rt9471.c b/drivers/power/supply/rt9471.c
index ca7d426849a7..ea0f865cbc62 100644
--- a/drivers/power/supply/rt9471.c
+++ b/drivers/power/supply/rt9471.c
@@ -583,8 +583,7 @@ static int rt9471_register_interrupts(struct rt9471_chip *chip)
ret = devm_request_threaded_irq(dev, virq, NULL, curr->handler,
IRQF_ONESHOT, curr->name, chip);
if (ret)
- return dev_err_probe(dev, ret, "Failed to register IRQ (%s)\n",
- curr->name);
+ return ret;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 36/43] power: supply: sbs-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (34 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 35/43] power: supply: rt9471: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 37/43] power: supply: sc27xx_fuel_gauge: " Pan Chuang
` (6 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/sbs-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/sbs-charger.c b/drivers/power/supply/sbs-charger.c
index a00c710601e8..e7b4e10dcfd5 100644
--- a/drivers/power/supply/sbs-charger.c
+++ b/drivers/power/supply/sbs-charger.c
@@ -217,7 +217,7 @@ static int sbs_probe(struct i2c_client *client)
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
dev_name(&client->dev), chip);
if (ret)
- return dev_err_probe(&client->dev, ret, "Failed to request irq\n");
+ return ret;
} else {
ret = devm_delayed_work_autocancel(&client->dev, &chip->work,
sbs_delayed_work);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 37/43] power: supply: sc27xx_fuel_gauge: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (35 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 36/43] power: supply: sbs-charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 38/43] power: supply: surface-rt-ec: " Pan Chuang
` (5 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel, Orson Zhai, Baolin Wang, Chunyan Zhang,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/sc27xx_fuel_gauge.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/power/supply/sc27xx_fuel_gauge.c b/drivers/power/supply/sc27xx_fuel_gauge.c
index a7ed9de8a289..9af0017fa88e 100644
--- a/drivers/power/supply/sc27xx_fuel_gauge.c
+++ b/drivers/power/supply/sc27xx_fuel_gauge.c
@@ -1231,10 +1231,8 @@ static int sc27xx_fgu_probe(struct platform_device *pdev)
sc27xx_fgu_interrupt,
IRQF_NO_SUSPEND | IRQF_ONESHOT,
pdev->name, data);
- if (ret) {
- dev_err(data->dev, "failed to request fgu IRQ\n");
+ if (ret)
return ret;
- }
irq = gpiod_to_irq(data->gpiod);
if (irq < 0) {
@@ -1247,10 +1245,8 @@ static int sc27xx_fgu_probe(struct platform_device *pdev)
IRQF_ONESHOT | IRQF_TRIGGER_RISING |
IRQF_TRIGGER_FALLING,
pdev->name, data);
- if (ret) {
- dev_err(dev, "failed to request IRQ\n");
+ if (ret)
return ret;
- }
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 38/43] power: supply: surface-rt-ec: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (36 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 37/43] power: supply: sc27xx_fuel_gauge: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 39/43] power: supply: tps65090-charger: " Pan Chuang
` (4 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/surface-rt-ec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/surface-rt-ec.c b/drivers/power/supply/surface-rt-ec.c
index a728ae0db858..da57b0a1a495 100644
--- a/drivers/power/supply/surface-rt-ec.c
+++ b/drivers/power/supply/surface-rt-ec.c
@@ -337,7 +337,7 @@ static int srt_ec_probe(struct i2c_client *client)
ret = devm_request_threaded_irq(dev, client->irq, NULL, srt_psy_detect_irq,
IRQF_ONESHOT, client->name, srt);
if (ret < 0)
- return dev_err_probe(dev, ret, "failed to request interrupt\n");
+ return ret;
ret = devm_delayed_work_autocancel(dev, &srt->poll_work, srt_bat_poll_work);
if (ret < 0)
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 39/43] power: supply: tps65090-charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (37 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 38/43] power: supply: surface-rt-ec: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 40/43] power: supply: tps65217_charger: " Pan Chuang
` (3 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/tps65090-charger.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/power/supply/tps65090-charger.c b/drivers/power/supply/tps65090-charger.c
index d010f013af8c..36340c56d272 100644
--- a/drivers/power/supply/tps65090-charger.c
+++ b/drivers/power/supply/tps65090-charger.c
@@ -302,12 +302,8 @@ static int tps65090_charger_probe(struct platform_device *pdev)
if (irq != -ENXIO) {
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
tps65090_charger_isr, IRQF_ONESHOT, "tps65090-charger", cdata);
- if (ret) {
- dev_err(cdata->dev,
- "Unable to register irq %d err %d\n", irq,
- ret);
+ if (ret)
return ret;
- }
} else {
cdata->poll_task = kthread_run(tps65090_charger_poll_task,
cdata, "ktps65090charger");
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 40/43] power: supply: tps65217_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (38 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 39/43] power: supply: tps65090-charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 41/43] power: supply: twl4030_charger: " Pan Chuang
` (2 subsequent siblings)
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/tps65217_charger.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c
index 6af17ce0b204..cd00a3f372b3 100644
--- a/drivers/power/supply/tps65217_charger.c
+++ b/drivers/power/supply/tps65217_charger.c
@@ -239,12 +239,8 @@ static int tps65217_charger_probe(struct platform_device *pdev)
tps65217_charger_irq,
IRQF_SHARED, "tps65217-charger",
charger);
- if (ret) {
- dev_err(charger->dev,
- "Unable to register irq %d err %d\n", irq[i],
- ret);
+ if (ret)
return ret;
- }
/* Check current state */
tps65217_charger_irq(-1, charger);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 41/43] power: supply: twl4030_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (39 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 40/43] power: supply: tps65217_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 42/43] power: supply: twl6030_charger: " Pan Chuang
2026-07-09 3:34 ` [PATCH 43/43] power: supply: ucs1002_power: " Pan Chuang
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/twl4030_charger.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
index 04216b2bfb6c..1cace8f73927 100644
--- a/drivers/power/supply/twl4030_charger.c
+++ b/drivers/power/supply/twl4030_charger.c
@@ -1055,19 +1055,13 @@ static int twl4030_bci_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(&pdev->dev, bci->irq_chg, NULL,
twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name,
bci);
- if (ret < 0) {
- dev_err(&pdev->dev, "could not request irq %d, status %d\n",
- bci->irq_chg, ret);
+ if (ret < 0)
return ret;
- }
ret = devm_request_threaded_irq(&pdev->dev, bci->irq_bci, NULL,
twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci);
- if (ret < 0) {
- dev_err(&pdev->dev, "could not request irq %d, status %d\n",
- bci->irq_bci, ret);
+ if (ret < 0)
return ret;
- }
/* Enable interrupts now. */
reg = ~(u32)(TWL4030_ICHGLOW | TWL4030_ICHGEOC | TWL4030_TBATOR2 |
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 42/43] power: supply: twl6030_charger: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (40 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 41/43] power: supply: twl4030_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
2026-07-09 3:34 ` [PATCH 43/43] power: supply: ucs1002_power: " Pan Chuang
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/twl6030_charger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/twl6030_charger.c b/drivers/power/supply/twl6030_charger.c
index b4ec26ff257c..020512d0e306 100644
--- a/drivers/power/supply/twl6030_charger.c
+++ b/drivers/power/supply/twl6030_charger.c
@@ -542,9 +542,7 @@ static int twl6030_charger_probe(struct platform_device *pdev)
IRQF_ONESHOT, pdev->name,
charger);
if (ret < 0)
- return dev_err_probe(&pdev->dev, ret,
- "could not request irq %d\n",
- charger->irq_chg);
+ return ret;
/* turing to charging to configure things */
twl6030_charger_write(CONTROLLER_CTRL1, 0);
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 43/43] power: supply: ucs1002_power: Remove redundant dev_err()/dev_err_probe()
2026-07-09 3:33 [PATCH 00/43] power: Remove redundant error messages on IRQ request failure Pan Chuang
` (41 preceding siblings ...)
2026-07-09 3:34 ` [PATCH 42/43] power: supply: twl6030_charger: " Pan Chuang
@ 2026-07-09 3:34 ` Pan Chuang
42 siblings, 0 replies; 49+ messages in thread
From: Pan Chuang @ 2026-07-09 3:34 UTC (permalink / raw)
To: Sebastian Reichel,
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS, open list
Cc: Pan Chuang
The devm_request_threaded_irq() and devm_request_irq() now automatically
log detailed error messages on failure. This eliminates the need for
driver-specific dev_err() and dev_err_probe() calls that previously
printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/power/supply/ucs1002_power.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c
index 3f44cc902f84..735880ed1cc8 100644
--- a/drivers/power/supply/ucs1002_power.c
+++ b/drivers/power/supply/ucs1002_power.c
@@ -647,21 +647,15 @@ static int ucs1002_probe(struct i2c_client *client)
ucs1002_charger_irq,
IRQF_ONESHOT,
"ucs1002-a_det", info);
- if (ret) {
- dev_err(dev, "Failed to request A_DET threaded irq: %d\n",
- ret);
+ if (ret)
return ret;
- }
}
if (irq_alert > 0) {
ret = devm_request_irq(dev, irq_alert, ucs1002_alert_irq,
0,"ucs1002-alert", info);
- if (ret) {
- dev_err(dev, "Failed to request ALERT threaded irq: %d\n",
- ret);
+ if (ret)
return ret;
- }
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 49+ messages in thread