All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Gatla Vishweshwar Reddy <gatlavishweshwarreddy26@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH v4] show-branch: convert per-branch flags to commit-slab
Date: Wed, 15 Jul 2026 08:47:52 +0200	[thread overview]
Message-ID: <alctGDn_g4bWB933@pks.im> (raw)
In-Reply-To: <20260715041856.51526-1-gatlavishweshwarreddy26@gmail.com>

On Wed, Jul 15, 2026 at 09:48:56AM +0530, Gatla Vishweshwar Reddy wrote:
> Changes in v4:
> - Fix show_independent() to use has_only_rev_flag_bit() instead of
>   test_rev_flag_bit(), preserving the original semantics: a commit is
>   independent only if reachable from exactly one tip, not merely if
>   the i-th bit is set.

Please note that it's considered good etiquette on our mailing list to
not only post new versions of a patch series, but to also reply to at
least some of the review comments you got [1]. This makes the reviewer
feel like they're not only talking to a code producing entity (read: AI
prompt), but rather to a human on the other side of the internet.

Thanks!

Patrick

[1]: https://git-scm.com/docs/MyFirstContribution#reviewing

  reply	other threads:[~2026-07-15  6:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 18:30 [PATCH] show-branch: convert object.flags usage to a commit-slab Gatla Vishweshwar Reddy
2026-07-14 20:01 ` [PATCH v2] show-branch: convert object.flags to commit-slab with uint64_t Gatla Vishweshwar Reddy
2026-07-14 20:41   ` Junio C Hamano
2026-07-14 22:00     ` Jeff King
2026-07-15  1:47       ` [PATCH v3] show-branch: convert per-branch flags to commit-slab Gatla Vishweshwar Reddy
2026-07-15  3:34         ` Junio C Hamano
2026-07-15  4:18           ` [PATCH v4] " Gatla Vishweshwar Reddy
2026-07-15  6:47             ` Patrick Steinhardt [this message]
2026-07-15  7:20         ` [PATCH v3] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alctGDn_g4bWB933@pks.im \
    --to=ps@pks.im \
    --cc=gatlavishweshwarreddy26@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.