Re: [PATCH v3] show-branch: convert per-branch flags to commit-slab

[Junio C Hamano <gitster@pobox.com>]

Gatla Vishweshwar Reddy <gatlavishweshwarreddy26@gmail.com> writes:

> In response to Jeff King:
> - init_commit_rev_flags_with_stride() is used as foundation.
>   Current stride=1 gives 64 branches. Dynamic stride for >64
>   branches can be added as a follow-up.

If that is the case ...

>  builtin/show-branch.c | 143 ++++++++++++++++++++++++------------------
>  1 file changed, 83 insertions(+), 60 deletions(-)
>
> diff --git a/builtin/show-branch.c b/builtin/show-branch.c
> index f02831b085..70436007ec 100644
> --- a/builtin/show-branch.c
> +++ b/builtin/show-branch.c
> @@ -34,16 +34,9 @@ static enum git_colorbool showbranch_use_color = GIT_COLOR_UNKNOWN;
>
>  static struct strvec default_args = STRVEC_INIT;
>
> -/*
> - * TODO: convert this use of commit->object.flags to commit-slab
> - * instead to store a pointer to ref name directly. Then use the same
> - * UNINTERESTING definition from revision.h here.
> - */
>  #define UNINTERESTING	01

... it is a bit premature to lose this TODO comment (which was
written, inspired by what I wrote ages ago, in [*1*]), until that
happens.

On the other hand, you can and should lose our own #define
UNINTERSTING here even with this "slab stores a single u64 word"
rewrite, and instead use the common one from <revision.h> header
file.

Thanks.


[Reference]

*1* https://lore.kernel.org/git/xmqq36yud9bp.fsf@gitster-ct.c.googlers.com/