From: Yury Norov <ynorov@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Link Mauve" <linkmauve@linkmauve.fr>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Tianshu Qiu" <tian.shu.qiu@intel.com>,
"Bingbu Cao" <bingbu.cao@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Roger Quadros" <rogerq@kernel.org>,
"Tony Lindgren" <tony@atomide.com>, "Lee Jones" <lee@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Vaibhaav Ram T.L" <vaibhaavram.tl@microchip.com>,
"Kumaravel Thiagarajan" <kumaravel.thiagarajan@microchip.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"André Draszik" <andre.draszik@linaro.org>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Praveen Teja Kundanala" <praveen.teja.kundanala@amd.com>,
"Kalyani Akula" <kalyani.akula@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Joshua Kinard" <linux@kumba.dev>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Johan Hovold" <johan@kernel.org>,
"Ronald Claveau" <linux-kernel-dev@aliel.fr>,
"Salah Triki" <salah.triki@gmail.com>,
"David Carlier" <devnexen@gmail.com>,
"Achim Gratz" <Achim.Gratz@stromeko.de>,
"Alexander Sverdlin" <alexander.sverdlin@siemens.com>,
"Patrick Wicki" <patrick.wicki@siemens.com>,
"Markus Heidelberg" <m.heidelberg@cab.de>,
"Markus Perkins" <markus@notsyncing.net>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Abd-Alrhman Masalkhi" <abd.masalkhi@gmail.com>,
"Chen Ni" <nichen@iscas.ac.cn>, "Kees Cook" <kees@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-media@vger.kernel.org,
linux-omap@vger.kernel.org, mfd@lists.linux.dev,
linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
imx@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 0/8] nvmem: make reg_write() take a const void *
Date: Wed, 15 Jul 2026 16:09:20 -0400 [thread overview]
Message-ID: <alfo8Mobje173POp@yury> (raw)
In-Reply-To: <alfZNQGcX0Z68eto@ashevche-desk.local>
On Wed, Jul 15, 2026 at 10:02:13PM +0300, Andy Shevchenko wrote:
> On Wed, Jul 15, 2026 at 07:52:16PM +0200, Link Mauve wrote:
> > This callback used to take a mutable void * for no reason, which causes
> > the compiler to be unaware that the val buffer should never be modified
> > by the callback.
> >
> > This was found while drafting the nvmem-provider Rust abstraction.
> >
> > I’ve split this series based on the subsystem each patch affects, but I
> > think it should go through the nvmem tree in one go after gathering the
> > acks from the other subsystem maintainers.
>
> It's an option. The other option (and often we go this way) is to introduce
> a new name, convert users, convert the name back.
>
> See, for example, how GPIO subsystem changed a proto of .set() callback.
I agree with Andy. This should be a well-narrowed bisectable series,
so please follow his suggestion with renaming.
> > I’ve been told previously to not include too many maintainers in Cc, but
> > I don’t know which ones to remove from the get_maintainers.pl output, so
> > I’ve still included everyone, sorry about that.
>
> With this, rather standard, way you will fulfill the above requirement
> automatically. Also you won't need treewide change to bother everybody
> with this. And also increase the chances to go in (maybe in a few releases
> span).
If I feel the recepient list is too long, I have a couple home-brewed scripts
for it:
$ cat add_maintainers.sh
#!/bin/bash
line=`scripts/get_maintainer.pl -n -f --separator , --no-rolestats $1`
sed -i "/^Subject:/i To: $line" $1
sed -i "s/>,/>,\n\t/g" $1
and
$ cat addm.sh
#!/bin/bash
for f in 00*; do
echo $f
./add_maintainers.sh $f
done
So, my approach is:
1. Run the ./addm.sh
2. Pick maintainers from each patch, and put them in the cover letter.
3. Trim cover letter To list, if needed.
The disadvantage of this approach is that people may receive a part of
the series, so for example can't apply it cleanly for testing. But now
that everyone has b4, fetching everything is as simple as
b4 mbox <message-id>
Thanks,
Yury
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <ynorov@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Link Mauve" <linkmauve@linkmauve.fr>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Tianshu Qiu" <tian.shu.qiu@intel.com>,
"Bingbu Cao" <bingbu.cao@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Roger Quadros" <rogerq@kernel.org>,
"Tony Lindgren" <tony@atomide.com>, "Lee Jones" <lee@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Vaibhaav Ram T.L" <vaibhaavram.tl@microchip.com>,
"Kumaravel Thiagarajan" <kumaravel.thiagarajan@microchip.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"André Draszik" <andre.draszik@linaro.org>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Praveen Teja Kundanala" <praveen.teja.kundanala@amd.com>,
"Kalyani Akula" <kalyani.akula@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Joshua Kinard" <linux@kumba.dev>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Johan Hovold" <johan@kernel.org>,
"Ronald Claveau" <linux-kernel-dev@aliel.fr>,
"Salah Triki" <salah.triki@gmail.com>,
"David Carlier" <devnexen@gmail.com>,
"Achim Gratz" <Achim.Gratz@stromeko.de>,
"Alexander Sverdlin" <alexander.sverdlin@siemens.com>,
"Patrick Wicki" <patrick.wicki@siemens.com>,
"Markus Heidelberg" <m.heidelberg@cab.de>,
"Markus Perkins" <markus@notsyncing.net>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Abd-Alrhman Masalkhi" <abd.masalkhi@gmail.com>,
"Chen Ni" <nichen@iscas.ac.cn>, "Kees Cook" <kees@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-media@vger.kernel.org,
linux-omap@vger.kernel.org, mfd@lists.linux.dev,
linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
imx@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 0/8] nvmem: make reg_write() take a const void *
Date: Wed, 15 Jul 2026 16:09:20 -0400 [thread overview]
Message-ID: <alfo8Mobje173POp@yury> (raw)
In-Reply-To: <alfZNQGcX0Z68eto@ashevche-desk.local>
On Wed, Jul 15, 2026 at 10:02:13PM +0300, Andy Shevchenko wrote:
> On Wed, Jul 15, 2026 at 07:52:16PM +0200, Link Mauve wrote:
> > This callback used to take a mutable void * for no reason, which causes
> > the compiler to be unaware that the val buffer should never be modified
> > by the callback.
> >
> > This was found while drafting the nvmem-provider Rust abstraction.
> >
> > I’ve split this series based on the subsystem each patch affects, but I
> > think it should go through the nvmem tree in one go after gathering the
> > acks from the other subsystem maintainers.
>
> It's an option. The other option (and often we go this way) is to introduce
> a new name, convert users, convert the name back.
>
> See, for example, how GPIO subsystem changed a proto of .set() callback.
I agree with Andy. This should be a well-narrowed bisectable series,
so please follow his suggestion with renaming.
> > I’ve been told previously to not include too many maintainers in Cc, but
> > I don’t know which ones to remove from the get_maintainers.pl output, so
> > I’ve still included everyone, sorry about that.
>
> With this, rather standard, way you will fulfill the above requirement
> automatically. Also you won't need treewide change to bother everybody
> with this. And also increase the chances to go in (maybe in a few releases
> span).
If I feel the recepient list is too long, I have a couple home-brewed scripts
for it:
$ cat add_maintainers.sh
#!/bin/bash
line=`scripts/get_maintainer.pl -n -f --separator , --no-rolestats $1`
sed -i "/^Subject:/i To: $line" $1
sed -i "s/>,/>,\n\t/g" $1
and
$ cat addm.sh
#!/bin/bash
for f in 00*; do
echo $f
./add_maintainers.sh $f
done
So, my approach is:
1. Run the ./addm.sh
2. Pick maintainers from each patch, and put them in the cover letter.
3. Trim cover letter To list, if needed.
The disadvantage of this approach is that people may receive a part of
the series, so for example can't apply it cleanly for testing. But now
that everyone has b4, fetching everything is as simple as
b4 mbox <message-id>
Thanks,
Yury
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-07-15 20:09 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 17:52 [PATCH 0/8] nvmem: make reg_write() take a const void * Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 17:52 ` [PATCH 1/8] nvmem: core: " Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 18:00 ` sashiko-bot
2026-07-15 18:00 ` sashiko-bot
2026-07-15 18:58 ` Andy Shevchenko
2026-07-15 18:58 ` Andy Shevchenko
2026-07-15 19:03 ` Link Mauve
2026-07-15 19:03 ` Link Mauve
2026-07-15 17:52 ` [PATCH 2/8] nvmem: make all reg_write callbacks take " Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 18:08 ` sashiko-bot
2026-07-15 18:08 ` sashiko-bot
2026-07-15 17:52 ` [PATCH 3/8] rtc: " Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 18:01 ` sashiko-bot
2026-07-15 18:01 ` sashiko-bot
2026-07-15 17:52 ` [PATCH 4/8] misc: " Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 18:04 ` sashiko-bot
2026-07-15 18:04 ` sashiko-bot
2026-07-15 17:52 ` [PATCH 5/8] iio: pressure: bmp280: make reg_write callback " Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 18:03 ` sashiko-bot
2026-07-15 18:03 ` sashiko-bot
2026-07-15 17:52 ` [PATCH 6/8] firmware: meson_sm: " Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 18:06 ` sashiko-bot
2026-07-15 18:06 ` sashiko-bot
2026-07-15 17:52 ` [PATCH 7/8] mfd: twl-core: " Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 18:08 ` sashiko-bot
2026-07-15 18:08 ` sashiko-bot
2026-07-15 17:52 ` [PATCH 8/8] media: ov2740: remove NULL reg_write callback Link Mauve
2026-07-15 17:52 ` Link Mauve
2026-07-15 18:07 ` sashiko-bot
2026-07-15 18:07 ` sashiko-bot
2026-07-15 19:02 ` [PATCH 0/8] nvmem: make reg_write() take a const void * Andy Shevchenko
2026-07-15 19:02 ` Andy Shevchenko
2026-07-15 19:09 ` Link Mauve
2026-07-15 19:09 ` Link Mauve
2026-07-15 20:09 ` Yury Norov [this message]
2026-07-15 20:09 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alfo8Mobje173POp@yury \
--to=ynorov@nvidia.com \
--cc=Achim.Gratz@stromeko.de \
--cc=Frank.Li@nxp.com \
--cc=a.hindborg@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=abd.masalkhi@gmail.com \
--cc=acourbot@nvidia.com \
--cc=alexander.sverdlin@siemens.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=aliceryhl@google.com \
--cc=andre.draszik@linaro.org \
--cc=andreas@kemnade.info \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=bingbu.cao@intel.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=daniel.lezcano@kernel.org \
--cc=devnexen@gmail.com \
--cc=dlechner@baylibre.com \
--cc=festevam@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=johan@kernel.org \
--cc=kalyani.akula@amd.com \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=lee@kernel.org \
--cc=linkmauve@linkmauve.fr \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-dev@aliel.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux@kumba.dev \
--cc=lossin@kernel.org \
--cc=m.heidelberg@cab.de \
--cc=markus@notsyncing.net \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mfd@lists.linux.dev \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=nichen@iscas.ac.cn \
--cc=nuno.sa@analog.com \
--cc=ojeda@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=patrick.wicki@siemens.com \
--cc=praveen.teja.kundanala@amd.com \
--cc=rogerq@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=salah.triki@gmail.com \
--cc=samuel@sholland.org \
--cc=srini@kernel.org \
--cc=tamird@kernel.org \
--cc=tian.shu.qiu@intel.com \
--cc=tmgross@umich.edu \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vaibhaavram.tl@microchip.com \
--cc=vz@mleia.com \
--cc=wens@kernel.org \
--cc=work@onurozkan.dev \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.