[PATCH] clk/x86: pmc_atom: add kasprintf return value check

[PATCH] clk/x86: pmc_atom: add kasprintf return value check

[longlong yan]

The kasprintf() function returns NULL on memory allocation failure, but
the code in plt_clk_register() was not checking this return value. If
kasprintf fails, init.name would be NULL and could cause NULL pointer
dereference when clkdev_hw_create() uses it.

Add proper error checking for the kasprintf() return value and return
ERR_PTR(-ENOMEM) on failure.

Fixes: 1141d9d08184 ("clk: x86: Add Atom PMC platform clocks")
Signed-off-by: longlong yan <yanlonglong@kylinos.cn>
---
 drivers/clk/x86/clk-pmc-atom.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
index 99291ba65da7..08c83e0abc41 100644
--- a/drivers/clk/x86/clk-pmc-atom.c
+++ b/drivers/clk/x86/clk-pmc-atom.c
@@ -160,6 +160,9 @@ static struct clk_plt *plt_clk_register(struct platform_device *pdev, int id,
 		return ERR_PTR(-ENOMEM);
 
 	init.name =  kasprintf(GFP_KERNEL, "%s_%d", PLT_CLK_NAME_BASE, id);
+	if (!init.name)
+		return ERR_PTR(-ENOMEM);
+
 	init.ops = &plt_clk_ops;
 	init.flags = 0;
 	init.parent_names = parent_names;
-- 
2.43.0

Re: [PATCH] clk/x86: pmc_atom: add kasprintf return value check

[Brian Masney]

On Tue, Jul 14, 2026 at 02:51:32PM +0800, longlong yan wrote:
> The kasprintf() function returns NULL on memory allocation failure, but
> the code in plt_clk_register() was not checking this return value. If
> kasprintf fails, init.name would be NULL and could cause NULL pointer
> dereference when clkdev_hw_create() uses it.
> 
> Add proper error checking for the kasprintf() return value and return
> ERR_PTR(-ENOMEM) on failure.
> 
> Fixes: 1141d9d08184 ("clk: x86: Add Atom PMC platform clocks")
> Signed-off-by: longlong yan <yanlonglong@kylinos.cn>

Reviewed-by: Brian Masney <bmasney@redhat.com>