Re: [PATCH rdma-next v3 14/14] RDMA/selftests: Add rxe_netns_names test

[Jiri Pirko <jiri@resnulli.us>]

Fri, Jul 17, 2026 at 03:24:28PM +0200, sashiko-bot@kernel.org wrote:
>Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>- [Medium] `wait_rdma_devs_gone()` fails to wait for dynamically renamed RDMA devices (e.g., `ibdevX`) to finish asynchronous unregistration, potentially causing module unload failures.
>--
>
>--- Patch [14]: [PATCH rdma-next v3 14/14] RDMA/selftests: Add rxe_netns_names test ---
>commit dabec57822c009814520c6cece67efb39fb7b1f8
>Author: Jiri Pirko <jiri@resnulli.us>
>
>RDMA/selftests: Add rxe_netns_names test
>
>This commit adds a kselftest script that exercises per-netns RDMA device
>naming with RXE. It covers duplicate names, conflicts, move-with-rename, and
>same-namespace rename requests.
>
>> diff --git a/tools/testing/selftests/rdma/rxe_netns_names.sh b/tools/testing/selftests/rdma/rxe_netns_names.sh
>> new file mode 100755
>> index 0000000000000..f40118407f4c0
>> --- /dev/null
>> +++ b/tools/testing/selftests/rdma/rxe_netns_names.sh
>
>[ ... ]
>
>> +wait_rdma_devs_gone()
>> +{
>> +	local i name ns
>> +	local names=("$RXE_A" "$RXE_B" "$RXE_SAME" "$RXE_NEW")
>
>[Severity: Medium]
>Does this hardcoded list of names miss dynamically assigned fallback names
>like 'ibdevX'?
>
>During the TEST_TEARDOWN_RETURN test, the device moves back to init_net and
>conflicts with an existing name, receiving a dynamic fallback name (e.g.,
>ibdev0). When cleanup_devs() deletes the underlying dummy netdevs, it calls
>wait_rdma_devs_gone() to wait for asynchronous unregistration.

*Very* unlikely. Ignoring.


>
>Since the dynamic name isn't in this list of expected names, the function may
>return early before the device actually finishes tearing down. Could this
>cause the script to fail to unload the rdma_rxe module or leave a dirty state
>for subsequent tests?
>
>> +
>> +	for i in $(seq 1 50); do
>> +		local found=0
>> +
>> +		for name in "${names[@]}"; do
>> +			if rdma_dev_exists "" "$name"; then
>> +				found=1
>> +				break
>> +			fi
>
>[ ... ]
>
>-- 
>Sashiko AI review · https://sashiko.dev/#/patchset/20260716132316.1495242-1-jiri@resnulli.us?part=14