From: "Michal Koutný" <mkoutny@suse.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: linux-rdma@vger.kernel.org, cgroups@vger.kernel.org,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kselftest@vger.kernel.org, jgg@ziepe.ca, leon@kernel.org,
parav@nvidia.com, mbloch@nvidia.com, cmeiohas@nvidia.com,
roman.gushchin@linux.dev, bvanassche@acm.org,
zyjzyj2000@gmail.com, shuah@kernel.org, tj@kernel.org,
hannes@cmpxchg.org, alibuda@linux.alibaba.com,
dust.li@linux.alibaba.com, sidraya@linux.ibm.com,
wenjia@linux.ibm.com, yanjun.zhu@linux.dev, cui.tao@linux.dev
Subject: Re: [PATCH rdma-next v3 08/14] RDMA/cgroup: Disambiguate devices across net namespaces
Date: Mon, 24 Aug 2026 20:29:23 +0200 [thread overview]
Message-ID: <aoyNXoZ4K2i_TNi-@localhost.localdomain> (raw)
In-Reply-To: <20260716132316.1495242-9-jiri@resnulli.us>
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
Hello Jiri.
On Thu, Jul 16, 2026 at 03:23:09PM +0200, Jiri Pirko <jiri@resnulli.us> wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> RDMA device names are unique only within a network namespace, but an
> RDMA cgroup can account resources for devices from multiple namespaces.
> Duplicate names therefore make cgroup output ambiguous and can cause
> limit writes to select the wrong device.
From the cover letter:
| A device in one network namespace therefore cannot use a name already
| taken in another, even in exclusive netns mode (netns_mode=0) where
| the two are otherwise isolated. Net devices have no such restriction -
| their names only need to be unique within a network namespace.
If this is modelled after net devices, why not make the visibility netns
based?
I.e. only list (write to) devices of the caller's netns.
>
> Use the system-wide RDMA device index to distinguish duplicate names
> while preserving the existing UAPI for unique names. Reject ambiguous
> name-only writes with -ENOTUNIQ and expose a complete device view to
> administrators.
I admit, the administrators won't get the full view but that's no
different from the netns devices situation.
Regards,
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
next prev parent reply other threads:[~2026-08-24 18:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 13:23 [PATCH rdma-next v3 00/14] RDMA: Make device names unique per net namespace Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 01/14] RDMA/core: Pass the net namespace to the device name lookups Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 02/14] RDMA/core: Handle device name conflicts when changing net namespace Jiri Pirko
2026-07-17 13:24 ` sashiko-bot
2026-07-17 14:06 ` Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 03/14] RDMA/core: Support renaming a device when changing its " Jiri Pirko
2026-07-17 13:24 ` sashiko-bot
2026-07-22 11:02 ` Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 04/14] RDMA/nldev: Report net namespace move errors through extack Jiri Pirko
2026-07-17 13:24 ` sashiko-bot
2026-07-22 11:17 ` Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 05/14] RDMA/nldev: Allow setting the device name while changing net namespace Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 06/14] net/smc: Look up the pnetid ib device within the " Jiri Pirko
2026-07-17 13:24 ` sashiko-bot
2026-07-17 14:08 ` Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 07/14] RDMA/srp: Make the SRP sysfs class net namespace aware Jiri Pirko
2026-07-30 18:34 ` Bart Van Assche
2026-07-16 13:23 ` [PATCH rdma-next v3 08/14] RDMA/cgroup: Disambiguate devices across net namespaces Jiri Pirko
2026-08-24 18:29 ` Michal Koutný [this message]
2026-07-16 13:23 ` [PATCH rdma-next v3 09/14] RDMA/cma: Document that CM configfs cannot be net namespace scoped Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 10/14] RDMA/core: Document the SELinux ibendport net namespace limitation Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 11/14] RDMA/core: Make device names unique per net namespace Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 12/14] RDMA/rxe: Allow queue VMAs to outlive ucontexts Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 13/14] RDMA/rxe: Implement disassociate_ucontext callback Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 14/14] RDMA/selftests: Add rxe_netns_names test Jiri Pirko
2026-07-17 4:22 ` Zhu Yanjun
2026-07-17 13:24 ` sashiko-bot
2026-07-17 14:09 ` Jiri Pirko
2026-07-22 11:19 ` [PATCH rdma-next v3 00/14] RDMA: Make device names unique per net namespace Jiri Pirko
2026-07-22 11:53 ` Leon Romanovsky
2026-07-22 13:01 ` Jiri Pirko
2026-07-26 7:32 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoyNXoZ4K2i_TNi-@localhost.localdomain \
--to=mkoutny@suse.com \
--cc=alibuda@linux.alibaba.com \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=cmeiohas@nvidia.com \
--cc=cui.tao@linux.dev \
--cc=dust.li@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=jgg@ziepe.ca \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=roman.gushchin@linux.dev \
--cc=shuah@kernel.org \
--cc=sidraya@linux.ibm.com \
--cc=tj@kernel.org \
--cc=wenjia@linux.ibm.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.