All of lore.kernel.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: add __ro_after_init to cyclecounter
Date: Sat, 11 Feb 2017 21:35:14 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702112129260.3734@nanos> (raw)
In-Reply-To: <1486840818-22214-1-git-send-email-bhumirks@gmail.com>

On Sun, 12 Feb 2017, Bhumika Goyal wrote:

Please be more careful with your subject line. The prefix for this is
definitely not 'clocksource'. git log would have told you the proper one:

clocksource/drivers/arm_arch_timer

'clocksource' is the general subsystem and used for system wide changes or
core changes, but not for a particular driver.

> The object cyclecounter of type cyclecounter is not getting modified
> after getting initialized by arch_counter_register. Apart from
> initialization in arch_counter_register it is also passed as an argument
> to the function timecounter_init but this argument is of type const.
> Therefore, add __ro_after_init to its declaration.

Other than that this is fine. I'll fix it up when applying.

Thanks,

	tglx

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, linux-kernel@vger.kernel.org,
	mark.rutland@arm.com, marc.zyngier@arm.com,
	daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org,
	keescook@chromium.org
Subject: Re: [PATCH] clocksource: add __ro_after_init to cyclecounter
Date: Sat, 11 Feb 2017 21:35:14 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702112129260.3734@nanos> (raw)
In-Reply-To: <1486840818-22214-1-git-send-email-bhumirks@gmail.com>

On Sun, 12 Feb 2017, Bhumika Goyal wrote:

Please be more careful with your subject line. The prefix for this is
definitely not 'clocksource'. git log would have told you the proper one:

clocksource/drivers/arm_arch_timer

'clocksource' is the general subsystem and used for system wide changes or
core changes, but not for a particular driver.

> The object cyclecounter of type cyclecounter is not getting modified
> after getting initialized by arch_counter_register. Apart from
> initialization in arch_counter_register it is also passed as an argument
> to the function timecounter_init but this argument is of type const.
> Therefore, add __ro_after_init to its declaration.

Other than that this is fine. I'll fix it up when applying.

Thanks,

	tglx

  parent reply	other threads:[~2017-02-11 20:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-11 19:20 [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal
2017-02-11 19:20 ` Bhumika Goyal
2017-02-11 20:31 ` Ard Biesheuvel
2017-02-11 20:31   ` Ard Biesheuvel
2017-02-11 20:36   ` Thomas Gleixner
2017-02-11 20:36     ` Thomas Gleixner
2017-02-12 18:20   ` Bhumika Goyal
2017-02-12 18:20     ` Bhumika Goyal
2017-02-12 18:56     ` Thomas Gleixner
2017-02-12 18:56       ` Thomas Gleixner
2017-02-12 19:00       ` Bhumika Goyal
2017-02-12 19:00         ` Bhumika Goyal
2017-02-12 20:07       ` Daniel Lezcano
2017-02-12 20:07         ` Daniel Lezcano
2017-02-11 20:35 ` Thomas Gleixner [this message]
2017-02-11 20:35   ` Thomas Gleixner
2017-02-12 18:21   ` Bhumika Goyal
2017-02-12 18:21     ` Bhumika Goyal
2017-02-12 19:28 ` [tip:timers/core] clocksource/drivers/arm_arch_timer:: Mark cyclecounter __ro_after_init tip-bot for Bhumika Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1702112129260.3734@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.