Re: [Outreachy kernel]

[Julia Lawall <julia.lawall@lip6.fr>]

On Fri, 17 Feb 2017, simran singhal wrote:

> linux-kernel@vger.kernel.org
> Bcc:
> Subject: [PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with
>  octal permissions
> Reply-To:

Your email did not come out well.  This part should not be in the message.
Try sending the message to yourself first, to be sure everything is ok.

> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> This warning is detected by checkpatch.pl

It would be better to explain what you did and why, rather than just
copying the checkpatch message.

> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> index a9a92d8..2ebc320 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> @@ -283,7 +283,7 @@ int __init ieee80211_debug_init(void)
>  				" proc directory\n");
>  		return -EIO;
>  	}
> -	e = proc_create("debug_level", S_IRUGO | S_IWUSR,
> +	e = proc_create("debug_level", 0644,
>  			      ieee80211_proc, &fops);

This could all be one line now.

julia

>  	if (!e) {
>  		remove_proc_entry(DRV_NAME, init_net.proc_net);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170216194114.GA17810%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>