From: Julia Lawall <julia.lawall@lip6.fr>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: arnaud.patard@rtp-net.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors
Date: Tue, 21 Feb 2017 18:40:51 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702211840010.3448@hadrien> (raw)
In-Reply-To: <20170221171920.GA18917@arushi-HP-Pavilion-Notebook>
On Tue, 21 Feb 2017, Arushi Singhal wrote:
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference...
> if there is boolean operator then it is fixed by Splitting line at
> boolean operator.
This is massively execeeding the 80 character boundary, and not for
something trivial like a string. Maybe the code can be reorganized in
some other way.
julia
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/xgifb/XGI_main_26.c | 15 +++++----------
> drivers/staging/xgifb/vb_setmode.c | 19 +++++++------------
> 2 files changed, 12 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 6930f7eb741b..4fd9bfafccc5 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -880,28 +880,23 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
> if ((filter >= 0) && (filter <= 7)) {
> pr_debug("FilterTable[%d]-%d: %*ph\n",
> filter_tb, filter,
> - 4, XGI_TV_filter[filter_tb].
> - filter[filter]);
> + 4, XGI_TV_filter[filter_tb].filter[filter]);
> xgifb_reg_set(
> XGIPART2,
> 0x35,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][0]));
> + (XGI_TV_filter[filter_tb].filter[filter][0]));
> xgifb_reg_set(
> XGIPART2,
> 0x36,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][1]));
> + (XGI_TV_filter[filter_tb].filter[filter][1]));
> xgifb_reg_set(
> XGIPART2,
> 0x37,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][2]));
> + (XGI_TV_filter[filter_tb].filter[filter][2]));
> xgifb_reg_set(
> XGIPART2,
> 0x38,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][3]));
> + (XGI_TV_filter[filter_tb].filter[filter][3]));
> }
> }
> }
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 7c7c8c8f1df3..00f1ae3adcda 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -221,8 +221,7 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
>
> for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
> tempbx; (*i)--) {
> - infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
> - Ext_InfoFlag;
> + infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
> if (infoflag & tempax)
> return 1;
>
> @@ -231,8 +230,7 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
> }
>
> for ((*i) = 0;; (*i)++) {
> - infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
> - Ext_InfoFlag;
> + infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
> if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
> != tempbx) {
> return 0;
> @@ -654,8 +652,8 @@ static void XGI_UpdateXG21CRTC(unsigned short ModeNo,
> (XGI330_RefIndex[RefreshRateTableIndex].Ext_CRT1CRTC ==
> RES640x480x60))
> index = 12;
> - else if (ModeNo == 0x2E && (XGI330_RefIndex[RefreshRateTableIndex].
> - Ext_CRT1CRTC == RES640x480x72))
> + else if (ModeNo == 0x2E && (XGI330_RefIndex[RefreshRateTableIndex].Ext_CRT1CRTC ==
> + RES640x480x72))
> index = 13;
> else if (ModeNo == 0x2F)
> index = 14;
> @@ -5092,8 +5090,7 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
>
> i = 0;
> do {
> - if (XGI330_RefIndex[RefreshRateTableIndex + i].
> - ModeID != ModeNo)
> + if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID != ModeNo)
> break;
> temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag;
> temp &= ModeTypeMask;
> @@ -5105,8 +5102,7 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
> } while (index != 0xFFFF);
> if (!(pVBInfo->VBInfo & SetCRT2ToRAMDAC)) {
> if (pVBInfo->VBInfo & SetInSlaveMode) {
> - temp = XGI330_RefIndex[RefreshRateTableIndex + i - 1].
> - Ext_InfoFlag;
> + temp = XGI330_RefIndex[RefreshRateTableIndex + i - 1].Ext_InfoFlag;
> if (temp & InterlaceMode)
> i++;
> }
> @@ -5483,8 +5479,7 @@ unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
> ModeIdIndex))
> return 0;
>
> - pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex].
> - Ext_ModeFlag & ModeTypeMask;
> + pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex].Ext_ModeFlag & ModeTypeMask;
>
> pVBInfo->SetFlag = 0;
> pVBInfo->VBInfo = DisableCRT2Display;
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170221171920.GA18917%40arushi-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-02-21 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 17:19 [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors Arushi Singhal
2017-02-21 17:40 ` Julia Lawall [this message]
2017-02-21 18:42 ` [Outreachy kernel] " Joe Perches
2017-02-21 18:42 ` Joe Perches
2017-02-22 4:16 ` Arushi Singhal
2017-02-22 4:33 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702211840010.3448@hadrien \
--to=julia.lawall@lip6.fr \
--cc=arnaud.patard@rtp-net.org \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.