From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: arnaud.patard@rtp-net.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors
Date: Tue, 21 Feb 2017 10:42:13 -0800 [thread overview]
Message-ID: <1487702533.2853.23.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1702211840010.3448@hadrien>
On Tue, 2017-02-21 at 18:40 +0100, Julia Lawall wrote:
>
> On Tue, 21 Feb 2017, Arushi Singhal wrote:
>
> > Error was reported by checkpatch.pl as
> > WARNING: Avoid multiple line dereference...
> > if there is boolean operator then it is fixed by Splitting line at
> > boolean operator.
>
> This is massively execeeding the 80 character boundary, and not for
> something trivial like a string. Maybe the code can be reorganized in
> some other way.
The easiest way to do that is to change the test above it
to reduce indentation from
if (xgifb_info->display2 == XGIFB_DISP_TV &&
����xgifb_info->hasVB == HASVB_301) {
[code...];
}
}
to
if (xgifb_info->display2 != XGIFB_DISP_TV ||
����xgifb_in
fo->hasVB != HASVB_301)
return;
[code...];
}
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: arnaud.patard@rtp-net.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors
Date: Tue, 21 Feb 2017 10:42:13 -0800 [thread overview]
Message-ID: <1487702533.2853.23.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1702211840010.3448@hadrien>
On Tue, 2017-02-21 at 18:40 +0100, Julia Lawall wrote:
>
> On Tue, 21 Feb 2017, Arushi Singhal wrote:
>
> > Error was reported by checkpatch.pl as
> > WARNING: Avoid multiple line dereference...
> > if there is boolean operator then it is fixed by Splitting line at
> > boolean operator.
>
> This is massively execeeding the 80 character boundary, and not for
> something trivial like a string. Maybe the code can be reorganized in
> some other way.
The easiest way to do that is to change the test above it
to reduce indentation from
if (xgifb_info->display2 == XGIFB_DISP_TV &&
xgifb_info->hasVB == HASVB_301) {
[code...];
}
}
to
if (xgifb_info->display2 != XGIFB_DISP_TV ||
xgifb_in
fo->hasVB != HASVB_301)
return;
[code...];
}
next prev parent reply other threads:[~2017-02-21 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 17:19 [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors Arushi Singhal
2017-02-21 17:40 ` [Outreachy kernel] " Julia Lawall
2017-02-21 18:42 ` Joe Perches [this message]
2017-02-21 18:42 ` Joe Perches
2017-02-22 4:16 ` Arushi Singhal
2017-02-22 4:33 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487702533.2853.23.camel@perches.com \
--to=joe@perches.com \
--cc=arnaud.patard@rtp-net.org \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.