From: Julia Lawall <julia.lawall@inria.fr>
To: Lourdes Pedrajas <lu@pplo.net>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
Date: Thu, 12 Mar 2020 18:22:03 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2003121820420.2418@hadrien> (raw)
In-Reply-To: <20200312161548.5631-1-lu@pplo.net>
On Thu, 12 Mar 2020, Lourdes Pedrajas wrote:
> printk() is deprecated, use netdev_warn() instead, which is a message printing
> function specific for network devices and uses net_device data structure,
> defined in include/linux/netdevice.h. Issue found by checkpatch.
I think that you could drop the part about the net_device structure. The
netdev debug functions are widley used in networking code, so anyone
interested in the patch should know about them already.
julia
>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> Changes since v3:
> - use netdev_warn() correcly
>
> drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 0118edb0b9ab..100532598781 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
> hwkey); /* KeyContent */
>
> } else {
> - printk("wrong type in WEP, not WEP40 and WEP104\n");
> + netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
> }
>
> }
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200312161548.5631-1-lu%40pplo.net.
>
next prev parent reply other threads:[~2020-03-12 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 16:15 [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk() Lourdes Pedrajas
2020-03-12 17:22 ` Julia Lawall [this message]
2020-03-12 20:59 ` [Outreachy kernel] " Lourdes Pedrajas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2003121820420.2418@hadrien \
--to=julia.lawall@inria.fr \
--cc=gregkh@linuxfoundation.org \
--cc=lu@pplo.net \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.