From: Lourdes Pedrajas <lu@pplo.net>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
Date: Thu, 12 Mar 2020 21:59:19 +0100 [thread overview]
Message-ID: <20200312205919.GB9113@supernova> (raw)
In-Reply-To: <alpine.DEB.2.21.2003121820420.2418@hadrien>
On Thu, Mar 12, 2020 at 06:22:03PM +0100, Julia Lawall wrote:
>
>
> On Thu, 12 Mar 2020, Lourdes Pedrajas wrote:
>
> > printk() is deprecated, use netdev_warn() instead, which is a message printing
> > function specific for network devices and uses net_device data structure,
> > defined in include/linux/netdevice.h. Issue found by checkpatch.
>
> I think that you could drop the part about the net_device structure. The
> netdev debug functions are widley used in networking code, so anyone
> interested in the patch should know about them already.
>
> julia
>
I agree, thank you for your help!
Lourdes
prev parent reply other threads:[~2020-03-12 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 16:15 [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk() Lourdes Pedrajas
2020-03-12 17:22 ` [Outreachy kernel] " Julia Lawall
2020-03-12 20:59 ` Lourdes Pedrajas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312205919.GB9113@supernova \
--to=lu@pplo.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.