* [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
@ 2020-03-12 16:15 Lourdes Pedrajas
2020-03-12 17:22 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Lourdes Pedrajas @ 2020-03-12 16:15 UTC (permalink / raw)
To: outreachy-kernel, gregkh; +Cc: Lourdes Pedrajas
printk() is deprecated, use netdev_warn() instead, which is a message printing
function specific for network devices and uses net_device data structure,
defined in include/linux/netdevice.h. Issue found by checkpatch.
Suggested-by: Julia Lawall <julia.lawall@inria.fr>
Suggested-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
Changes since v3:
- use netdev_warn() correcly
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 0118edb0b9ab..100532598781 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
hwkey); /* KeyContent */
} else {
- printk("wrong type in WEP, not WEP40 and WEP104\n");
+ netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
2020-03-12 16:15 [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk() Lourdes Pedrajas
@ 2020-03-12 17:22 ` Julia Lawall
2020-03-12 20:59 ` Lourdes Pedrajas
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-03-12 17:22 UTC (permalink / raw)
To: Lourdes Pedrajas; +Cc: outreachy-kernel, gregkh
On Thu, 12 Mar 2020, Lourdes Pedrajas wrote:
> printk() is deprecated, use netdev_warn() instead, which is a message printing
> function specific for network devices and uses net_device data structure,
> defined in include/linux/netdevice.h. Issue found by checkpatch.
I think that you could drop the part about the net_device structure. The
netdev debug functions are widley used in networking code, so anyone
interested in the patch should know about them already.
julia
>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> Changes since v3:
> - use netdev_warn() correcly
>
> drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 0118edb0b9ab..100532598781 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
> hwkey); /* KeyContent */
>
> } else {
> - printk("wrong type in WEP, not WEP40 and WEP104\n");
> + netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
> }
>
> }
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200312161548.5631-1-lu%40pplo.net.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
2020-03-12 17:22 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-12 20:59 ` Lourdes Pedrajas
0 siblings, 0 replies; 3+ messages in thread
From: Lourdes Pedrajas @ 2020-03-12 20:59 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel, gregkh
On Thu, Mar 12, 2020 at 06:22:03PM +0100, Julia Lawall wrote:
>
>
> On Thu, 12 Mar 2020, Lourdes Pedrajas wrote:
>
> > printk() is deprecated, use netdev_warn() instead, which is a message printing
> > function specific for network devices and uses net_device data structure,
> > defined in include/linux/netdevice.h. Issue found by checkpatch.
>
> I think that you could drop the part about the net_device structure. The
> netdev debug functions are widley used in networking code, so anyone
> interested in the patch should know about them already.
>
> julia
>
I agree, thank you for your help!
Lourdes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-12 20:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-12 16:15 [PATCH v4] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk() Lourdes Pedrajas
2020-03-12 17:22 ` [Outreachy kernel] " Julia Lawall
2020-03-12 20:59 ` Lourdes Pedrajas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.