From: Julia Lawall <julia.lawall@inria.fr>
To: Jaskaran Singh <jaskaransingh7654321@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH 22/32] parsing_c: pretty_print_c: Reflect Cast attributes
Date: Sun, 3 May 2020 21:32:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2005032132191.2533@hadrien> (raw)
In-Reply-To: <20200428170228.7002-23-jaskaransingh7654321@gmail.com>
On Tue, 28 Apr 2020, Jaskaran Singh wrote:
> Cast attributes are added to the SmPL AST. Print these attributes in
> pretty_print_c.ml.
>
> Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com>
> ---
> parsing_c/pretty_print_c.ml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/parsing_c/pretty_print_c.ml b/parsing_c/pretty_print_c.ml
> index 99a7e0ed..96a11d72 100644
> --- a/parsing_c/pretty_print_c.ml
> +++ b/parsing_c/pretty_print_c.ml
> @@ -146,8 +146,9 @@ let mk_pretty_printers
> pp_expression e
> | SizeOfType (t), [i1;i2;i3] ->
> pr_elem i1; pr_elem i2; pp_type t; pr_elem i3
> - | Cast (t, e), [i1;i2] ->
> - pr_elem i1; pp_type t; pr_elem i2; pp_expression e
> + | Cast (t, e, a), [i1;i2] ->
Less space in front of the [
julia
> + pr_elem i1; pp_type t; pr_elem i2; pp_expression e;
> + a +> pp_attributes pr_elem pr_space
>
> | StatementExpr (statxs, [ii1;ii2]), [i1;i2] ->
> pr_elem i1;
> @@ -184,7 +185,7 @@ let mk_pretty_printers
> | CondExpr (_,_,_) | Sequence (_,_) | Assignment (_,_,_)
> | Postfix (_,_) | Infix (_,_) | Unary (_,_) | Binary (_,_,_)
> | ArrayAccess (_,_) | RecordAccess (_,_) | RecordPtAccess (_,_)
> - | SizeOfExpr (_) | SizeOfType (_) | Cast (_,_)
> + | SizeOfExpr (_) | SizeOfType (_) | Cast (_,_,_)
> | StatementExpr (_) | Constructor _
> | ParenExpr (_) | New (_) | Delete (_,_)
> | Defined (_)),_ -> raise (Impossible 95)
> --
> 2.21.1
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Jaskaran Singh <jaskaransingh7654321@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Linux-kernel-mentees] [PATCH 22/32] parsing_c: pretty_print_c: Reflect Cast attributes
Date: Sun, 3 May 2020 21:32:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2005032132191.2533@hadrien> (raw)
In-Reply-To: <20200428170228.7002-23-jaskaransingh7654321@gmail.com>
On Tue, 28 Apr 2020, Jaskaran Singh wrote:
> Cast attributes are added to the SmPL AST. Print these attributes in
> pretty_print_c.ml.
>
> Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com>
> ---
> parsing_c/pretty_print_c.ml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/parsing_c/pretty_print_c.ml b/parsing_c/pretty_print_c.ml
> index 99a7e0ed..96a11d72 100644
> --- a/parsing_c/pretty_print_c.ml
> +++ b/parsing_c/pretty_print_c.ml
> @@ -146,8 +146,9 @@ let mk_pretty_printers
> pp_expression e
> | SizeOfType (t), [i1;i2;i3] ->
> pr_elem i1; pr_elem i2; pp_type t; pr_elem i3
> - | Cast (t, e), [i1;i2] ->
> - pr_elem i1; pp_type t; pr_elem i2; pp_expression e
> + | Cast (t, e, a), [i1;i2] ->
Less space in front of the [
julia
> + pr_elem i1; pp_type t; pr_elem i2; pp_expression e;
> + a +> pp_attributes pr_elem pr_space
>
> | StatementExpr (statxs, [ii1;ii2]), [i1;i2] ->
> pr_elem i1;
> @@ -184,7 +185,7 @@ let mk_pretty_printers
> | CondExpr (_,_,_) | Sequence (_,_) | Assignment (_,_,_)
> | Postfix (_,_) | Infix (_,_) | Unary (_,_) | Binary (_,_,_)
> | ArrayAccess (_,_) | RecordAccess (_,_) | RecordPtAccess (_,_)
> - | SizeOfExpr (_) | SizeOfType (_) | Cast (_,_)
> + | SizeOfExpr (_) | SizeOfType (_) | Cast (_,_,_)
> | StatementExpr (_) | Constructor _
> | ParenExpr (_) | New (_) | Delete (_,_)
> | Defined (_)),_ -> raise (Impossible 95)
> --
> 2.21.1
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-05-03 19:32 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 17:01 [Cocci] [PATCH 00/32] cocci: Add cast attributes to C and SmPL ASTs Jaskaran Singh
2020-04-28 17:01 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:01 ` [Cocci] [PATCH 01/32] parsing_c: parser: Pass attribute list from type_name Jaskaran Singh
2020-04-28 17:01 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-03 19:23 ` [Cocci] " Julia Lawall
2020-05-03 19:23 ` [Linux-kernel-mentees] " Julia Lawall
2020-05-04 9:06 ` [Cocci] " Jaskaran Singh
2020-05-04 9:06 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-04 9:17 ` [Cocci] " Julia Lawall
2020-05-04 9:17 ` [Linux-kernel-mentees] " Julia Lawall
2020-05-04 9:20 ` [Cocci] " Jaskaran Singh
2020-05-04 9:20 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-04 13:18 ` [Cocci] " Julia Lawall
2020-05-04 13:18 ` [Linux-kernel-mentees] " Julia Lawall
2020-04-28 17:01 ` [Cocci] [PATCH 02/32] parsing_cocci: ast0_cocci: Add cast attributes Jaskaran Singh
2020-04-28 17:01 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:01 ` [Cocci] [PATCH 03/32] parsing_cocci: parser: Parse " Jaskaran Singh
2020-04-28 17:01 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-03 19:26 ` [Cocci] " Julia Lawall
2020-05-03 19:26 ` [Linux-kernel-mentees] " Julia Lawall
2020-04-28 17:02 ` [Cocci] [PATCH 04/32] parsing_cocci: visitor_ast0: Visit " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 05/32] parsing_cocci: unparse_ast0: Reflect " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 06/32] parsing_cocci: index: Reflect Cast attributes Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 07/32] parsing_cocci: iso_pattern: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 08/32] parsing_cocci: type_infer: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 09/32] parsing_cocci: arity: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-03 19:28 ` [Cocci] " Julia Lawall
2020-05-03 19:28 ` [Linux-kernel-mentees] " Julia Lawall
2020-04-28 17:02 ` [Cocci] [PATCH 10/32] parsing_cocci: check_meta: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 11/32] parsing_cocci: compute_lines: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 12/32] parsing_cocci: context_neg: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 13/32] parsing_cocci: single_statement: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 14/32] parsing_cocci: ast_cocci: Add cast attributes Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 15/32] parsing_cocci: visitor_ast: Visit " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-03 19:29 ` [Cocci] " Julia Lawall
2020-05-03 19:29 ` [Linux-kernel-mentees] " Julia Lawall
2020-04-28 17:02 ` [Cocci] [PATCH 16/32] parsing_cocci: pretty_print_cocci: Print " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 17/32] parsing_cocci: ast0toast: Reflect Cast attributes Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 18/32] parsing_cocci: disjdistr: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 19/32] parsing_cocci: unify_ast: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 20/32] parsing_c: ast_c: Add " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-03 19:31 ` [Cocci] " Julia Lawall
2020-05-03 19:31 ` [Linux-kernel-mentees] " Julia Lawall
2020-04-28 17:02 ` [Cocci] [PATCH 21/32] parsing_c: parser: Parse " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 22/32] parsing_c: pretty_print_c: Reflect " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-03 19:32 ` Julia Lawall [this message]
2020-05-03 19:32 ` Julia Lawall
2020-04-28 17:02 ` [Cocci] [PATCH 23/32] parsing_c: type_annoter_c: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 24/32] parsing_c: unparse_cocci: " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 25/32] parsing_c: visitor_c: Visit " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 26/32] engine: check_exhaustive_pattern: Reflect " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 27/32] engine: cocci_vs_c: Match " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 28/32] ocaml: coccilib: Reflect " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 29/32] tools: spgen: Reflect Cast attrs Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 30/32] tests: Add test case to check cast attribute allminus Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 31/32] tests: Add test case to remove cast attributes Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-04-28 17:02 ` [Cocci] [PATCH 32/32] tests: Add test case to detect " Jaskaran Singh
2020-04-28 17:02 ` [Linux-kernel-mentees] " Jaskaran Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2005032132191.2533@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=jaskaransingh7654321@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.