Re: [cocci] Searching for repeated source code with SmPL?

[Julia Lawall <julia.lawall@inria.fr>]

[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]



On Sat, 11 May 2024, Markus Elfring wrote:

> >> Why is no diff output generated by the software combination “Coccinelle 1.2-00008-g75525032”
> >> so far?
> >
> > Your semantic patch needs to be:
> >
> > @display@
> > @@
> >  my_action(...);
> >  <+... when any
> > *my_action(...);
> >  ...+>
> >
> > Without that, a call to my_action is forbidden in the region matched by
> > the <+... ...+>.  Because any kind of dot thing matches the shortest path
> > between what comes before and what comes after (here the end of the function).
>
> Thanks for this quick feedback.
>
> It seems that we expect different data processing also for the shown test case.
>
> The SmPL construct “<+... … ...+>” supports a search for code parts
> which occur at least once.
> Thus it seems that the specified search pattern needs be duplicated before
> if you would like to find code which should occur at least twice.
> I would appreciate if undesirable duplication of search patterns can be avoided here.

If you want to find code that occurs at least twice, isn't it most natural
to make a pattern that shows the thing occurring twice?

julia