Re: [cocci] Searching for repeated source code with SmPL?

[Julia Lawall <julia.lawall@inria.fr>]

On Sun, 12 May 2024, Markus Elfring wrote:

> >> Can the data processing be improved anyhow?
> >
> > The current semantic pach allows the first my_action to match anywhere,
> > including the second my_action, third, etc.  So if you have changes in both,
> > then there will be contradictory changes to the code.
>
> I suggest to reconsider such information in more detail according to
> the presented transformation approach.
>
>
> > Probably you should start with ... when != my_action(...) to be sure to
> > get the first one.
>
> I would expect that only the first function call should be matched by
> the initial SmPL search pattern (without an extra when constraint).

Why would you expect that?  Coccinelle looks through your function and
matches the pattern anywhere it can.  The matches are independent of each
other.

julia

> Should subsequent repeated calls be taken into account only for the shown
> deletion attempt?
>
> Regards,
> Markus
>