Re: [PATCH 10/10] thinkpad_acpi: fingers off backlight if video.ko is serving this functionality

[Len Brown <lenb@kernel.org>]

On Fri, 1 Aug 2008, Henrique de Moraes Holschuh wrote:

> On Fri, 01 Aug 2008, Thomas Renninger wrote:
> > Signed-off-by: Thomas Renninger <trenn@suse.de>
> > ---
> >  drivers/misc/thinkpad_acpi.c |   31 ++++++++++++++++++++-----------
> >  1 files changed, 20 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
> > index d3eb790..a71ecd2 100644
> > --- a/drivers/misc/thinkpad_acpi.c
> > +++ b/drivers/misc/thinkpad_acpi.c
> > @@ -4922,17 +4922,26 @@ static int __init brightness_init(struct ibm_init_struct *iibm)
> >  	 */
> >  	b = tpacpi_check_std_acpi_brightness_support();
> >  	if (b > 0) {
> > -		if (thinkpad_id.vendor == PCI_VENDOR_ID_LENOVO) {
> > -			printk(TPACPI_NOTICE
> > -			       "Lenovo BIOS switched to ACPI backlight "
> > -			       "control mode\n");
> > -		}
> > -		if (brightness_enable > 1) {
> > -			printk(TPACPI_NOTICE
> > -			       "standard ACPI backlight interface "
> > -			       "available, not loading native one...\n");
> > -			return 1;
> > -		}
> > +
> > +		if (acpi_video_backlight_support()) {
> > +			if (brightness_enable > 1) {
> > +				printk(TPACPI_NOTICE
> > +				       "Standard ACPI backlight interface "
> > +				       "available, not loading native one.\n");
> > +				return 1;
> > +			} else if (brightness_enable == 1) {
> > +				printk(TPACPI_NOTICE
> > +				       "Backlight control force, even standard "
> > +				       "ACPI backlight interface available\n");
> > +			}
> 
> EPARSE.  "Backlight control force, even standard ACPI backlight interface
> available" is no good.  Maybe you want to change that to "Backlight control
> force enabled, even if standard ACPI backlight interface is available" ?

updated.

> > +		} else {
> > +			if (brightness_enable > 1) {
> > +				printk(TPACPI_NOTICE
> > +				       "Standard ACPI backlight interface not "
> > +				       "available, thinkpad_acpi driver "
> > +				       "will take over control\n");
> 
> "thinkpad-acpi native brightness control enabled", perhaps?

updated.

> > +			}
> > + 		}
> >  	}
> >  
> >  	if (!brightness_enable) {
> 
> Provided that you clarify the printk I marked with EPARSE:
> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

thanks,
-Len