* [PATCH] Kconfig: MTD_DATAFLASH_WRITE_VERIFY -> MTD_DATAFLASH_VERIFY_WRITE
@ 2009-09-10 11:19 Robert P. J. Day
2009-09-10 11:57 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2009-09-10 11:19 UTC (permalink / raw)
To: MTD mailing list
Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so
that it matches the spelling here:
drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
index 325fab9..3265e96 100644
--- a/drivers/mtd/devices/Kconfig
+++ b/drivers/mtd/devices/Kconfig
@@ -59,7 +59,7 @@ config MTD_DATAFLASH
Sometimes DataFlash chips are packaged inside MMC-format
cards; at this writing, the MMC stack won't handle those.
-config MTD_DATAFLASH_WRITE_VERIFY
+config MTD_DATAFLASH_VERIFY_WRITE
bool "Verify DataFlash page writes"
depends on MTD_DATAFLASH
help
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Kconfig: MTD_DATAFLASH_WRITE_VERIFY -> MTD_DATAFLASH_VERIFY_WRITE
2009-09-10 11:19 [PATCH] Kconfig: MTD_DATAFLASH_WRITE_VERIFY -> MTD_DATAFLASH_VERIFY_WRITE Robert P. J. Day
@ 2009-09-10 11:57 ` Peter Korsgaard
2009-09-10 13:26 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2009-09-10 11:57 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: MTD mailing list
>>>>> "Robert" == Robert P J Day <rpjday@crashcourse.ca> writes:
Robert> Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so
Robert> that it matches the spelling here:
Robert> drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
Robert> drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
Robert> -config MTD_DATAFLASH_WRITE_VERIFY
Robert> +config MTD_DATAFLASH_VERIFY_WRITE
It probably makes more sense to change the .c file instead of Kconfig,
to not bother/confuse people and simply make it "just work".
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Kconfig: MTD_DATAFLASH_WRITE_VERIFY -> MTD_DATAFLASH_VERIFY_WRITE
2009-09-10 11:57 ` Peter Korsgaard
@ 2009-09-10 13:26 ` Robert P. J. Day
0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2009-09-10 13:26 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: MTD mailing list
On Thu, 10 Sep 2009, Peter Korsgaard wrote:
> >>>>> "Robert" == Robert P J Day <rpjday@crashcourse.ca> writes:
>
> Robert> Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so
> Robert> that it matches the spelling here:
>
> Robert> drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
> Robert> drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
>
> Robert> -config MTD_DATAFLASH_WRITE_VERIFY
> Robert> +config MTD_DATAFLASH_VERIFY_WRITE
>
> It probably makes more sense to change the .c file instead of Kconfig,
> to not bother/confuse people and simply make it "just work".
ok, if that's the consensus, i'll have that patch out later today.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-10 13:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-10 11:19 [PATCH] Kconfig: MTD_DATAFLASH_WRITE_VERIFY -> MTD_DATAFLASH_VERIFY_WRITE Robert P. J. Day
2009-09-10 11:57 ` Peter Korsgaard
2009-09-10 13:26 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.