* [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c
@ 2010-01-01 17:28 Robert P. J. Day
2010-01-01 18:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 5+ messages in thread
From: Robert P. J. Day @ 2010-01-01 17:28 UTC (permalink / raw)
To: Linux Kernel Mailing List
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
no appropriate subsystem maintainer listed in MAINTAINERS.
diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
index 793b236..71c0fcd 100644
--- a/drivers/char/hvsi.c
+++ b/drivers/char/hvsi.c
@@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
- while (time_before(end_jiffies, jiffies))
+ while (time_before(jiffies, end_jiffies))
if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
break;
}
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c
2010-01-01 17:28 [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c Robert P. J. Day
@ 2010-01-01 18:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2010-01-01 18:15 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Joe Perches, linuxppc-dev, Linux Kernel Mailing List
On Friday 01 January 2010 06:28:03 pm Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> no appropriate subsystem maintainer listed in MAINTAINERS.
drivers/char/Makefile:
obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o
so it should belong to:
HYPERVISOR VIRTUAL CONSOLE DRIVER
L: linuxppc-dev@ozlabs.org
S: Odd Fixes
F: drivers/char/hvc_*
[ Though maybe Ben would be willing to pick this one up directly
as hvsi is PPC specific thingy and patch is obviously correct. ]
> diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
> index 793b236..71c0fcd 100644
> --- a/drivers/char/hvsi.c
> +++ b/drivers/char/hvsi.c
> @@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
> uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
> unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
>
> - while (time_before(end_jiffies, jiffies))
> + while (time_before(jiffies, end_jiffies))
> if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
> break;
> }
--
Bartlomiej Zolnierkiewicz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c
@ 2010-01-01 18:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2010-01-01 18:15 UTC (permalink / raw)
To: Robert P. J. Day
Cc: Linux Kernel Mailing List, Joe Perches, linuxppc-dev,
Benjamin Herrenschmidt
On Friday 01 January 2010 06:28:03 pm Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> no appropriate subsystem maintainer listed in MAINTAINERS.
drivers/char/Makefile:
obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o
so it should belong to:
HYPERVISOR VIRTUAL CONSOLE DRIVER
L: linuxppc-dev@ozlabs.org
S: Odd Fixes
F: drivers/char/hvc_*
[ Though maybe Ben would be willing to pick this one up directly
as hvsi is PPC specific thingy and patch is obviously correct. ]
> diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
> index 793b236..71c0fcd 100644
> --- a/drivers/char/hvsi.c
> +++ b/drivers/char/hvsi.c
> @@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
> uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
> unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
>
> - while (time_before(end_jiffies, jiffies))
> + while (time_before(jiffies, end_jiffies))
> if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
> break;
> }
--
Bartlomiej Zolnierkiewicz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c
2010-01-01 18:15 ` Bartlomiej Zolnierkiewicz
@ 2010-01-01 21:11 ` Benjamin Herrenschmidt
-1 siblings, 0 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2010-01-01 21:11 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Joe Perches, linuxppc-dev, Robert P. J. Day,
Linux Kernel Mailing List
On Fri, 2010-01-01 at 19:15 +0100, Bartlomiej Zolnierkiewicz wrote:
> On Friday 01 January 2010 06:28:03 pm Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > no appropriate subsystem maintainer listed in MAINTAINERS.
>
> drivers/char/Makefile:
> obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o
>
> so it should belong to:
>
> HYPERVISOR VIRTUAL CONSOLE DRIVER
> L: linuxppc-dev@ozlabs.org
> S: Odd Fixes
> F: drivers/char/hvc_*
>
> [ Though maybe Ben would be willing to pick this one up directly
> as hvsi is PPC specific thingy and patch is obviously correct. ]
Sure, I'll pick that one up.
Cheers,
Ben.
> > diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
> > index 793b236..71c0fcd 100644
> > --- a/drivers/char/hvsi.c
> > +++ b/drivers/char/hvsi.c
> > @@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
> > uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
> > unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
> >
> > - while (time_before(end_jiffies, jiffies))
> > + while (time_before(jiffies, end_jiffies))
> > if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
> > break;
> > }
>
> --
> Bartlomiej Zolnierkiewicz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c
@ 2010-01-01 21:11 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2010-01-01 21:11 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Robert P. J. Day, Linux Kernel Mailing List, Joe Perches,
linuxppc-dev
On Fri, 2010-01-01 at 19:15 +0100, Bartlomiej Zolnierkiewicz wrote:
> On Friday 01 January 2010 06:28:03 pm Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > no appropriate subsystem maintainer listed in MAINTAINERS.
>
> drivers/char/Makefile:
> obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o
>
> so it should belong to:
>
> HYPERVISOR VIRTUAL CONSOLE DRIVER
> L: linuxppc-dev@ozlabs.org
> S: Odd Fixes
> F: drivers/char/hvc_*
>
> [ Though maybe Ben would be willing to pick this one up directly
> as hvsi is PPC specific thingy and patch is obviously correct. ]
Sure, I'll pick that one up.
Cheers,
Ben.
> > diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
> > index 793b236..71c0fcd 100644
> > --- a/drivers/char/hvsi.c
> > +++ b/drivers/char/hvsi.c
> > @@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
> > uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
> > unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
> >
> > - while (time_before(end_jiffies, jiffies))
> > + while (time_before(jiffies, end_jiffies))
> > if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
> > break;
> > }
>
> --
> Bartlomiej Zolnierkiewicz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-01-01 21:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-01 17:28 [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c Robert P. J. Day
2010-01-01 18:15 ` Bartlomiej Zolnierkiewicz
2010-01-01 18:15 ` Bartlomiej Zolnierkiewicz
2010-01-01 21:11 ` Benjamin Herrenschmidt
2010-01-01 21:11 ` Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.