All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <john.stultz@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Yong Zhang <yong.zhang0@gmail.com>,
	David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH] clocksource: Avoid selecting mult values that might overflow when adjusted
Date: Thu, 3 Nov 2011 13:05:19 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.02.1111031304210.2829@ionos> (raw)
In-Reply-To: <1320264087-3413-1-git-send-email-john.stultz@linaro.org>

On Wed, 2 Nov 2011, John Stultz wrote:
>  
> +	WARN_ONCE(timekeeper.mult+adj >
> +			timekeeper.clock->mult + timekeeper.clock->maxadj,
> +			"Adjusting more then 11%%");

Shouldn't we rather limit the update instead of just warn and overflow ?

Thanks,

	tglx

  parent reply	other threads:[~2011-11-03 12:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 20:01 [PATCH] clocksource: Avoid selecting mult values that might overflow when adjusted John Stultz
2011-11-03  3:10 ` Yong Zhang
2011-11-03  9:36   ` Américo Wang
2011-11-04  2:16     ` Yong Zhang
2011-11-03 12:05 ` Thomas Gleixner [this message]
2011-11-03 13:10   ` John Stultz
2011-11-03 13:26     ` Thomas Gleixner
2011-11-03 14:01       ` John Stultz
2011-11-03 14:09         ` John Stultz
2011-11-03 14:49           ` Thomas Gleixner
2011-11-03 14:52             ` Thomas Gleixner
2011-11-03 15:14               ` John Stultz
2011-11-03 21:10 ` Ingo Molnar
2011-11-04 13:11   ` John Stultz
2011-11-04 15:20     ` Ingo Molnar
2011-11-08  3:09   ` John Stultz
2011-11-08  3:11     ` Yong Zhang
2011-11-08  5:02     ` Yong Zhang
2011-11-08 21:39       ` John Stultz
2011-11-09  1:46         ` Yong Zhang
2011-11-10 15:05           ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2011-11-09  2:08 John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1111031304210.2829@ionos \
    --to=tglx@linutronix.de \
    --cc=ddaney.cavm@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.