From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: abstract locking out into helper functions
Date: Thu, 28 Mar 2013 10:31:22 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1303281027170.22263@ionos> (raw)
In-Reply-To: <1364445958-2999-2-git-send-email-mturquette@linaro.org>
On Wed, 27 Mar 2013, Mike Turquette wrote:
> Create locking helpers for the global mutex and global spinlock. The
> definitions of these helpers will be expanded upon in the next patch
> which introduces reentrancy into the locking scheme.
This looks way better. Nitpick below.
> +static void clk_enable_lock(unsigned long *flags)
> +{
> + spin_lock_irqsave(&enable_lock, *flags);
> +}
> +static void clk_enable_unlock(unsigned long *flags)
Please just hand in the flags, no need for indirection.
> +{
> + spin_unlock_irqrestore(&enable_lock, *flags);
> +}
> +
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Mike Turquette <mturquette@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, patches@linaro.org,
linaro-kernel@lists.linaro.org, rajagopal.venkat@linaro.org,
davidb@codeaurora.org, ulf.hansson@linaro.org,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 1/2] clk: abstract locking out into helper functions
Date: Thu, 28 Mar 2013 10:31:22 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1303281027170.22263@ionos> (raw)
In-Reply-To: <1364445958-2999-2-git-send-email-mturquette@linaro.org>
On Wed, 27 Mar 2013, Mike Turquette wrote:
> Create locking helpers for the global mutex and global spinlock. The
> definitions of these helpers will be expanded upon in the next patch
> which introduces reentrancy into the locking scheme.
This looks way better. Nitpick below.
> +static void clk_enable_lock(unsigned long *flags)
> +{
> + spin_lock_irqsave(&enable_lock, *flags);
> +}
> +static void clk_enable_unlock(unsigned long *flags)
Please just hand in the flags, no need for indirection.
> +{
> + spin_unlock_irqrestore(&enable_lock, *flags);
> +}
> +
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2013-03-28 9:31 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 7:09 [PATCH v4] clk: allow reentrant calls into the clk framework Mike Turquette
2013-03-27 7:09 ` Mike Turquette
2013-03-27 9:08 ` Laurent Pinchart
2013-03-27 9:08 ` Laurent Pinchart
2013-03-27 15:06 ` Mike Turquette
2013-03-27 17:12 ` Thomas Gleixner
2013-03-27 17:12 ` Thomas Gleixner
2013-03-27 9:40 ` Thomas Gleixner
2013-03-27 9:40 ` Thomas Gleixner
2013-03-27 9:55 ` Viresh Kumar
2013-03-27 9:55 ` Viresh Kumar
2013-03-27 10:03 ` Ulf Hansson
2013-03-27 10:03 ` Ulf Hansson
2013-03-27 11:09 ` Thomas Gleixner
2013-03-27 11:09 ` Thomas Gleixner
2013-03-27 14:25 ` Mike Turquette
2013-03-27 14:25 ` Mike Turquette
2013-03-27 9:59 ` Laurent Pinchart
2013-03-27 9:59 ` Laurent Pinchart
2013-03-27 11:24 ` Thomas Gleixner
2013-03-27 11:24 ` Thomas Gleixner
2013-03-27 16:47 ` Mike Turquette
2013-03-27 17:09 ` Thomas Gleixner
2013-03-27 17:09 ` Thomas Gleixner
2013-03-27 22:56 ` Russell King - ARM Linux
2013-03-27 22:56 ` Russell King - ARM Linux
2013-03-28 3:00 ` Mike Turquette
2013-03-28 4:45 ` [PATCH v5 0/2] reentrancy in the common " Mike Turquette
2013-03-28 4:45 ` Mike Turquette
2013-03-28 4:45 ` [PATCH 1/2] clk: abstract locking out into helper functions Mike Turquette
2013-03-28 4:45 ` Mike Turquette
2013-03-28 9:31 ` Thomas Gleixner [this message]
2013-03-28 9:31 ` Thomas Gleixner
2013-03-28 4:45 ` [PATCH 2/2] clk: allow reentrant calls into the clk framework Mike Turquette
2013-03-28 4:45 ` Mike Turquette
2013-03-28 9:33 ` Thomas Gleixner
2013-03-28 9:33 ` Thomas Gleixner
2013-03-28 15:23 ` Mike Turquette
2013-03-28 15:23 ` Mike Turquette
2013-03-28 10:44 ` [PATCH v5 0/2] reentrancy in the common " Laurent Pinchart
2013-03-28 10:44 ` Laurent Pinchart
2013-03-28 20:59 ` [PATCH v6 " Mike Turquette
2013-03-28 20:59 ` Mike Turquette
2013-03-28 20:59 ` [PATCH 1/2] clk: abstract locking out into helper functions Mike Turquette
2013-03-28 20:59 ` Mike Turquette
2013-04-02 9:23 ` Ulf Hansson
2013-04-02 9:23 ` Ulf Hansson
2013-03-28 20:59 ` [PATCH 2/2] clk: allow reentrant calls into the clk framework Mike Turquette
2013-03-28 20:59 ` Mike Turquette
2013-04-02 9:35 ` Ulf Hansson
2013-04-02 9:35 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1303281027170.22263@ionos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.