scripts/runqemu-internal adds "-no-reboot" QEMU options redundantly

scripts/runqemu-internal adds "-no-reboot" QEMU options redundantly

[Robert P. J. Day]

  more obsessive pedantry, but when i do "runqemu qemuarm" (or other
arches), i notice that the eventual lengthy "qemu-system-arm" command
run has the option "-no-reboot" in it twice. that's because, in
scripts/runqemu-internal, numerous individual architectures add that
option to the variable QEMUOPTIONS while, at the bottom of that
script, one reads:

echo "Running $QEMU..."
# -no-reboot is a mandatory option - see bug #100
if [ "$FSTYPE" = "vmdk" ]; then
    echo $QEMUBIN $VM $QEMUOPTIONS $SERIALOPTS -no-reboot $SCRIPT_QEMU_OPT $SCRIPT_QEMU_EXTRA_OPT
    ... snip ...

wherein everyone ends up including that option a second time.

  doesn't hurt, of course, but it makes reading that script more
confusing than it has to be.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================