question about SERIAL_CONSOLES vs SERIAL_CONSOLE

question about SERIAL_CONSOLES vs SERIAL_CONSOLE

[Robert P. J. Day]

  given that SERIAL_CONSOLE is officially deprecated, i was going to
submit a patch that switched them all over to SERIAL_CONSOLES, but i'm
not sure what this is doing in
meta/recipes-core/systemd/systemd-serialgetty.bb:

... snip ...
SERIAL_CONSOLE ?= "115200 ttyS0"

SRC_URI = "file://serial-getty@.service"

do_install() {
        if [ ! -z "${SERIAL_CONSOLES}" ] ; then
                default_baudrate=`echo "${SERIAL_CONSOLES}" | sed 's/\;.*//'`
                install -d ${D}${systemd_unitdir}/system/
                install -d ${D}${sysconfdir}/systemd/system/getty.target.wants/
                install -m 0644 ${WORKDIR}/serial-getty@.service ${D}${systemd_unitdir}/system/
                sed -i -e s/\@BAUDRATE\@/$default_baudrate/g ${D}${systemd_unitdir}/system/serial-getty@.service

                tmp="${SERIAL_CONSOLES}"
                for entry in $tmp ; do
... snip ...

  so, SERIAL_CONSOLE is initially set, but all further references are
to SERIAL_CONSOLES. so, is that initial setting of SERIAL_CONSOLE even
doing anything?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================