From: James Morris <james.l.morris@oracle.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
linux-crypto@vger.kernel.org,
Alexander Potapenko <glider@google.com>,
Eric Biggers <ebiggers@google.com>,
stable@vger.kernel.org, Tudor Ambarus <tudor-dan.ambarus@nxp.com>
Subject: Re: [PATCH] crypto: rsa - fix buffer overread when stripping leading zeroes
Date: Mon, 27 Nov 2017 08:22:09 +0000 [thread overview]
Message-ID: <alpine.LFD.2.20.1711271921511.2808@localhost> (raw)
In-Reply-To: <20171127071649.25800-1-ebiggers3@gmail.com>
On Sun, 26 Nov 2017, Eric Biggers wrote:
> Fixes: 5a7de97309f5 ("crypto: rsa - return raw integers for the ASN.1 parser")
> Cc: <stable@vger.kernel.org> # v4.8+
> Cc: Tudor Ambarus <tudor-dan.ambarus@nxp.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/rsa_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/rsa_helper.c b/crypto/rsa_helper.c
> index 0b66dc824606..cad395d70d78 100644
> --- a/crypto/rsa_helper.c
> +++ b/crypto/rsa_helper.c
> @@ -30,7 +30,7 @@ int rsa_get_n(void *context, size_t hdrlen, unsigned char tag,
> return -EINVAL;
>
> if (fips_enabled) {
> - while (!*ptr && n_sz) {
> + while (n_sz && !*ptr) {
> ptr++;
> n_sz--;
> }
Reviewed-by: James Morris <james.l.morris@oracle.com>
--
James Morris
<james.l.morris@oracle.com>
WARNING: multiple messages have this Message-ID (diff)
From: James Morris <james.l.morris@oracle.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
linux-crypto@vger.kernel.org,
Alexander Potapenko <glider@google.com>,
Eric Biggers <ebiggers@google.com>,
stable@vger.kernel.org, Tudor Ambarus <tudor-dan.ambarus@nxp.com>
Subject: Re: [PATCH] crypto: rsa - fix buffer overread when stripping leading zeroes
Date: Mon, 27 Nov 2017 19:22:09 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LFD.2.20.1711271921511.2808@localhost> (raw)
In-Reply-To: <20171127071649.25800-1-ebiggers3@gmail.com>
On Sun, 26 Nov 2017, Eric Biggers wrote:
> Fixes: 5a7de97309f5 ("crypto: rsa - return raw integers for the ASN.1 parser")
> Cc: <stable@vger.kernel.org> # v4.8+
> Cc: Tudor Ambarus <tudor-dan.ambarus@nxp.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/rsa_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/rsa_helper.c b/crypto/rsa_helper.c
> index 0b66dc824606..cad395d70d78 100644
> --- a/crypto/rsa_helper.c
> +++ b/crypto/rsa_helper.c
> @@ -30,7 +30,7 @@ int rsa_get_n(void *context, size_t hdrlen, unsigned char tag,
> return -EINVAL;
>
> if (fips_enabled) {
> - while (!*ptr && n_sz) {
> + while (n_sz && !*ptr) {
> ptr++;
> n_sz--;
> }
Reviewed-by: James Morris <james.l.morris@oracle.com>
--
James Morris
<james.l.morris@oracle.com>
next prev parent reply other threads:[~2017-11-27 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 7:16 [PATCH] crypto: rsa - fix buffer overread when stripping leading zeroes Eric Biggers
2017-11-27 7:16 ` Eric Biggers
2017-11-27 8:22 ` James Morris [this message]
2017-11-27 8:22 ` James Morris
2017-11-28 10:54 ` David Howells
2017-11-28 23:26 ` Herbert Xu
2017-11-28 23:26 ` Herbert Xu
2017-11-28 10:55 ` David Howells
2017-11-29 5:22 ` Herbert Xu
2017-11-29 5:22 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1711271921511.2808@localhost \
--to=james.l.morris@oracle.com \
--cc=dhowells@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=glider@google.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tudor-dan.ambarus@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.