* [PATCH] kbuild: fix warnings by specifing format arguments
@ 2011-10-22 17:19 Peter Foley
2011-12-11 20:27 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Peter Foley @ 2011-10-22 17:19 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linux Kbuild Mailing List, mmarek
Specify format arguments to fix warnings.
HOSTCC scripts/kconfig/gconf.o
/usr/src/lto/scripts/kconfig/gconf.c: In function 'on_introduction1_activate':
/usr/src/lto/scripts/kconfig/gconf.c:686:6: warning: format not a string literal and no format arguments
/usr/src/lto/scripts/kconfig/gconf.c: In function 'on_about1_activate':
/usr/src/lto/scripts/kconfig/gconf.c:704:6: warning: format not a string literal and no format arguments
/usr/src/lto/scripts/kconfig/gconf.c: In function 'on_license1_activate':
/usr/src/lto/scripts/kconfig/gconf.c:723:6: warning: format not a string literal and no format arguments
Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
scripts/kconfig/gconf.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index 9f44380..b9e26a5 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -683,7 +683,7 @@ void on_introduction1_activate(GtkMenuItem * menuitem, gpointer user_data)
dialog = gtk_message_dialog_new(GTK_WINDOW(main_wnd),
GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_INFO,
- GTK_BUTTONS_CLOSE, intro_text);
+ GTK_BUTTONS_CLOSE, "%s", intro_text);
g_signal_connect_swapped(GTK_OBJECT(dialog), "response",
G_CALLBACK(gtk_widget_destroy),
GTK_OBJECT(dialog));
@@ -701,7 +701,7 @@ void on_about1_activate(GtkMenuItem * menuitem, gpointer user_data)
dialog = gtk_message_dialog_new(GTK_WINDOW(main_wnd),
GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_INFO,
- GTK_BUTTONS_CLOSE, about_text);
+ GTK_BUTTONS_CLOSE, "%s", about_text);
g_signal_connect_swapped(GTK_OBJECT(dialog), "response",
G_CALLBACK(gtk_widget_destroy),
GTK_OBJECT(dialog));
@@ -720,7 +720,7 @@ void on_license1_activate(GtkMenuItem * menuitem, gpointer user_data)
dialog = gtk_message_dialog_new(GTK_WINDOW(main_wnd),
GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_INFO,
- GTK_BUTTONS_CLOSE, license_text);
+ GTK_BUTTONS_CLOSE, "%s", license_text);
g_signal_connect_swapped(GTK_OBJECT(dialog), "response",
G_CALLBACK(gtk_widget_destroy),
GTK_OBJECT(dialog));
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: fix warnings by specifing format arguments
2011-10-22 17:19 [PATCH] kbuild: fix warnings by specifing format arguments Peter Foley
@ 2011-12-11 20:27 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2011-12-11 20:27 UTC (permalink / raw)
To: Peter Foley; +Cc: Linux Kernel Mailing List, Linux Kbuild Mailing List
On Sat, Oct 22, 2011 at 01:19:02PM -0400, Peter Foley wrote:
> Specify format arguments to fix warnings.
>
> HOSTCC scripts/kconfig/gconf.o
> /usr/src/lto/scripts/kconfig/gconf.c: In function 'on_introduction1_activate':
> /usr/src/lto/scripts/kconfig/gconf.c:686:6: warning: format not a string literal and no format arguments
> /usr/src/lto/scripts/kconfig/gconf.c: In function 'on_about1_activate':
> /usr/src/lto/scripts/kconfig/gconf.c:704:6: warning: format not a string literal and no format arguments
> /usr/src/lto/scripts/kconfig/gconf.c: In function 'on_license1_activate':
> /usr/src/lto/scripts/kconfig/gconf.c:723:6: warning: format not a string literal and no format arguments
>
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
> scripts/kconfig/gconf.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Applied to kbuild.git#kconfig.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-11 20:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-22 17:19 [PATCH] kbuild: fix warnings by specifing format arguments Peter Foley
2011-12-11 20:27 ` Michal Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.