From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Eric Biggers <ebiggers@google.com>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KEYS: user: Align the payload buffer
Date: Wed, 20 Feb 2019 20:50:31 +0000 [thread overview]
Message-ID: <alpine.LRH.2.21.1902210750180.1411@namei.org> (raw)
In-Reply-To: <16012.1550671795@warthog.procyon.org.uk>
On Wed, 20 Feb 2019, David Howells wrote:
> David Laight <David.Laight@ACULAB.COM> wrote:
>
> > I'd make the 'datalen' field 'unsigned int' at the same time.
> > It will use some of the hole you've made and generate better
> > code on most arches.
>
> Most arches? I though most, if not all, arches had a load-word instruction.
>
> Do you want to send me a patch for that? I'd rather not alter this patch at
> this point. I can pass the additional patch to James for the next merge
> window.
Should this first one go into -rc?
--
James Morris
<jmorris@namei.org>
WARNING: multiple messages have this Message-ID (diff)
From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Eric Biggers <ebiggers@google.com>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KEYS: user: Align the payload buffer
Date: Thu, 21 Feb 2019 07:50:31 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.21.1902210750180.1411@namei.org> (raw)
In-Reply-To: <16012.1550671795@warthog.procyon.org.uk>
On Wed, 20 Feb 2019, David Howells wrote:
> David Laight <David.Laight@ACULAB.COM> wrote:
>
> > I'd make the 'datalen' field 'unsigned int' at the same time.
> > It will use some of the hole you've made and generate better
> > code on most arches.
>
> Most arches? I though most, if not all, arches had a load-word instruction.
>
> Do you want to send me a patch for that? I'd rather not alter this patch at
> this point. I can pass the additional patch to James for the next merge
> window.
Should this first one go into -rc?
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2019-02-20 20:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 3:37 [PATCH] KEYS: user: Align the payload buffer Eric Biggers
2019-01-15 3:37 ` Eric Biggers
2019-01-15 19:19 ` Aaro Koskinen
2019-01-15 19:19 ` Aaro Koskinen
2019-02-07 23:35 ` Eric Biggers
2019-02-07 23:35 ` Eric Biggers
2019-02-19 23:08 ` Eric Biggers
2019-02-19 23:08 ` Eric Biggers
2019-02-20 13:32 ` David Howells
2019-02-20 13:32 ` David Howells
2019-02-20 13:32 ` David Howells
2019-02-20 13:52 ` David Laight
2019-02-20 13:52 ` David Laight
2019-02-20 14:09 ` David Howells
2019-02-20 20:50 ` James Morris [this message]
2019-02-20 20:50 ` James Morris
2019-02-20 21:37 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1902210750180.1411@namei.org \
--to=jmorris@namei.org \
--cc=David.Laight@ACULAB.COM \
--cc=aaro.koskinen@iki.fi \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.