From: Alan Maguire <alan.maguire@oracle.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: kvm@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
David Rientjes <rientjes@google.com>,
Jonathan Adams <jwadams@google.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, brendanhiggins@google.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH v3 3/7] kunit: tests for stats_fs API
Date: Wed, 27 May 2020 10:05:23 +0000 [thread overview]
Message-ID: <alpine.LRH.2.21.2005271054360.24819@localhost> (raw)
In-Reply-To: <20200526110318.69006-4-eesposit@redhat.com>
On Tue, 26 May 2020, Emanuele Giuseppe Esposito wrote:
> Add kunit tests to extensively test the stats_fs API functionality.
>
I've added in the kunit-related folks.
> In order to run them, the kernel .config must set CONFIG_KUNIT=y
> and a new .kunitconfig file must be created with CONFIG_STATS_FS=y
> and CONFIG_STATS_FS_TEST=y
>
It looks like CONFIG_STATS_FS is built-in, but it exports
much of the functionality you are testing. However could the
tests also be built as a module (i.e. make CONFIG_STATS_FS_TEST
a tristate variable)? To test this you'd need to specify
CONFIG_KUNIT=m and CONFIG_STATS_FS_TEST=m, and testing would
simply be a case of "modprobe"ing the stats fs module and collecting
results in /sys/kernel/debug/kunit/<module_name> (rather
than running kunit.py). Are you relying on unexported internals in
the the tests that would prevent building them as a module?
Thanks!
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Maguire <alan.maguire@oracle.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: kvm@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
David Rientjes <rientjes@google.com>,
Jonathan Adams <jwadams@google.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, brendanhiggins@google.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH v3 3/7] kunit: tests for stats_fs API
Date: Wed, 27 May 2020 11:05:23 +0100 (BST) [thread overview]
Message-ID: <alpine.LRH.2.21.2005271054360.24819@localhost> (raw)
In-Reply-To: <20200526110318.69006-4-eesposit@redhat.com>
On Tue, 26 May 2020, Emanuele Giuseppe Esposito wrote:
> Add kunit tests to extensively test the stats_fs API functionality.
>
I've added in the kunit-related folks.
> In order to run them, the kernel .config must set CONFIG_KUNIT=y
> and a new .kunitconfig file must be created with CONFIG_STATS_FS=y
> and CONFIG_STATS_FS_TEST=y
>
It looks like CONFIG_STATS_FS is built-in, but it exports
much of the functionality you are testing. However could the
tests also be built as a module (i.e. make CONFIG_STATS_FS_TEST
a tristate variable)? To test this you'd need to specify
CONFIG_KUNIT=m and CONFIG_STATS_FS_TEST=m, and testing would
simply be a case of "modprobe"ing the stats fs module and collecting
results in /sys/kernel/debug/kunit/<module_name> (rather
than running kunit.py). Are you relying on unexported internals in
the the tests that would prevent building them as a module?
Thanks!
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Maguire <alan.maguire@oracle.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, netdev@vger.kernel.org,
kunit-dev@googlegroups.com,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
Jonathan Adams <jwadams@google.com>,
brendanhiggins@google.com,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kselftest@vger.kernel.org,
David Rientjes <rientjes@google.com>,
linux-fsdevel@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH v3 3/7] kunit: tests for stats_fs API
Date: Wed, 27 May 2020 11:05:23 +0100 (BST) [thread overview]
Message-ID: <alpine.LRH.2.21.2005271054360.24819@localhost> (raw)
In-Reply-To: <20200526110318.69006-4-eesposit@redhat.com>
On Tue, 26 May 2020, Emanuele Giuseppe Esposito wrote:
> Add kunit tests to extensively test the stats_fs API functionality.
>
I've added in the kunit-related folks.
> In order to run them, the kernel .config must set CONFIG_KUNIT=y
> and a new .kunitconfig file must be created with CONFIG_STATS_FS=y
> and CONFIG_STATS_FS_TEST=y
>
It looks like CONFIG_STATS_FS is built-in, but it exports
much of the functionality you are testing. However could the
tests also be built as a module (i.e. make CONFIG_STATS_FS_TEST
a tristate variable)? To test this you'd need to specify
CONFIG_KUNIT=m and CONFIG_STATS_FS_TEST=m, and testing would
simply be a case of "modprobe"ing the stats fs module and collecting
results in /sys/kernel/debug/kunit/<module_name> (rather
than running kunit.py). Are you relying on unexported internals in
the the tests that would prevent building them as a module?
Thanks!
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Maguire <alan.maguire@oracle.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, netdev@vger.kernel.org,
kunit-dev@googlegroups.com,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
Jonathan Adams <jwadams@google.com>,
brendanhiggins@google.com,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kselftest@vger.kernel.org,
David Rientjes <rientjes@google.com>,
linux-fsdevel@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH v3 3/7] kunit: tests for stats_fs API
Date: Wed, 27 May 2020 11:05:23 +0100 (BST) [thread overview]
Message-ID: <alpine.LRH.2.21.2005271054360.24819@localhost> (raw)
In-Reply-To: <20200526110318.69006-4-eesposit@redhat.com>
On Tue, 26 May 2020, Emanuele Giuseppe Esposito wrote:
> Add kunit tests to extensively test the stats_fs API functionality.
>
I've added in the kunit-related folks.
> In order to run them, the kernel .config must set CONFIG_KUNIT=y
> and a new .kunitconfig file must be created with CONFIG_STATS_FS=y
> and CONFIG_STATS_FS_TEST=y
>
It looks like CONFIG_STATS_FS is built-in, but it exports
much of the functionality you are testing. However could the
tests also be built as a module (i.e. make CONFIG_STATS_FS_TEST
a tristate variable)? To test this you'd need to specify
CONFIG_KUNIT=m and CONFIG_STATS_FS_TEST=m, and testing would
simply be a case of "modprobe"ing the stats fs module and collecting
results in /sys/kernel/debug/kunit/<module_name> (rather
than running kunit.py). Are you relying on unexported internals in
the the tests that would prevent building them as a module?
Thanks!
Alan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-27 10:05 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 11:03 [PATCH v3 0/7] Statsfs: a new ram-based file system for Linux kernel statistics Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 1/7] stats_fs API: create, add and remove stats_fs sources and values Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 2/7] documentation for stats_fs Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-06-04 0:23 ` Randy Dunlap
2020-06-04 0:23 ` Randy Dunlap
2020-06-04 0:23 ` Randy Dunlap
2020-06-04 0:23 ` Randy Dunlap
2020-06-04 15:34 ` Emanuele Giuseppe Esposito
2020-06-04 15:34 ` Emanuele Giuseppe Esposito
2020-06-04 15:34 ` Emanuele Giuseppe Esposito
2020-06-04 15:34 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 3/7] kunit: tests for stats_fs API Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-27 10:05 ` Alan Maguire [this message]
2020-05-27 10:05 ` Alan Maguire
2020-05-27 10:05 ` Alan Maguire
2020-05-27 10:05 ` Alan Maguire
2020-05-27 13:26 ` Emanuele Giuseppe Esposito
2020-05-27 13:26 ` Emanuele Giuseppe Esposito
2020-05-27 13:26 ` Emanuele Giuseppe Esposito
2020-05-27 13:26 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 4/7] stats_fs fs: virtual fs to show stats to the end-user Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 5/7] kvm_main: replace debugfs with stats_fs Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 6/7] [not for merge] kvm: example of stats_fs_value show function Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` [PATCH v3 7/7] [not for merge] netstats: example use of stats_fs API Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 11:03 ` Emanuele Giuseppe Esposito
2020-05-26 14:16 ` Andrew Lunn
2020-05-26 14:16 ` Andrew Lunn
2020-05-26 14:16 ` Andrew Lunn
2020-05-26 14:16 ` Andrew Lunn
2020-05-26 15:45 ` Emanuele Giuseppe Esposito
2020-05-26 15:45 ` Emanuele Giuseppe Esposito
2020-05-26 15:45 ` Emanuele Giuseppe Esposito
2020-05-26 15:45 ` Emanuele Giuseppe Esposito
2020-05-26 22:31 ` [PATCH v3 0/7] Statsfs: a new ram-based file system for Linux kernel statistics Jakub Kicinski
2020-05-26 22:31 ` Jakub Kicinski
2020-05-26 22:31 ` Jakub Kicinski
2020-05-26 22:31 ` Jakub Kicinski
2020-05-27 13:14 ` Emanuele Giuseppe Esposito
2020-05-27 13:14 ` Emanuele Giuseppe Esposito
2020-05-27 13:14 ` Emanuele Giuseppe Esposito
2020-05-27 13:14 ` Emanuele Giuseppe Esposito
2020-05-27 13:33 ` Andrew Lunn
2020-05-27 13:33 ` Andrew Lunn
2020-05-27 13:33 ` Andrew Lunn
2020-05-27 13:33 ` Andrew Lunn
2020-05-27 15:00 ` Paolo Bonzini
2020-05-27 15:00 ` Paolo Bonzini
2020-05-27 15:00 ` Paolo Bonzini
2020-05-27 15:00 ` Paolo Bonzini
2020-05-27 20:23 ` Jakub Kicinski
2020-05-27 20:23 ` Jakub Kicinski
2020-05-27 20:23 ` Jakub Kicinski
2020-05-27 20:23 ` Jakub Kicinski
2020-05-27 21:07 ` Paolo Bonzini
2020-05-27 21:07 ` Paolo Bonzini
2020-05-27 21:07 ` Paolo Bonzini
2020-05-27 21:07 ` Paolo Bonzini
2020-05-27 21:27 ` Jakub Kicinski
2020-05-27 21:27 ` Jakub Kicinski
2020-05-27 21:27 ` Jakub Kicinski
2020-05-27 21:27 ` Jakub Kicinski
2020-05-27 21:44 ` Paolo Bonzini
2020-05-27 21:44 ` Paolo Bonzini
2020-05-27 21:44 ` Paolo Bonzini
2020-05-27 21:44 ` Paolo Bonzini
2020-05-27 22:21 ` David Ahern
2020-05-27 22:21 ` David Ahern
2020-05-27 22:21 ` David Ahern
2020-05-27 22:21 ` David Ahern
2020-05-28 5:22 ` Paolo Bonzini
2020-05-28 5:22 ` Paolo Bonzini
2020-05-28 5:22 ` Paolo Bonzini
2020-05-28 5:22 ` Paolo Bonzini
2020-05-27 21:17 ` Andrew Lunn
2020-05-27 21:17 ` Andrew Lunn
2020-05-27 21:17 ` Andrew Lunn
2020-05-27 21:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.2005271054360.24819@localhost \
--to=alan.maguire@oracle.com \
--cc=borntraeger@de.ibm.com \
--cc=brendanhiggins@google.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=eesposit@redhat.com \
--cc=jmattson@google.com \
--cc=jwadams@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.