[PATCH] tpm: atmel: depend on X86

[PATCH] tpm: atmel: depend on X86

[Karl Mehltretter]

tpm_atmel probes for the chip at fixed x86 Super-I/O ports (0x4e) with
inb()/outb(), so it only works on x86. TCG_ATMEL nevertheless depends
only on HAS_IOPORT_MAP/HAS_IOPORT, which arm and arm64 also satisfy.
There the probe is useless, and on platforms whose unbacked I/O access
faults it oopses in init_atmel() at boot (e.g. arm/versatile):

  Unable to handle kernel paging request at virtual address fee0004e
  PC is at init_atmel+0x34/0x244

TCG_NSC and TCG_TIS already "depends on X86" (commit 2f592f2a7d74 ("TPM:
NSC and TIS drivers X86 dependency fix")); TCG_ATMEL was missed. Add the
same dependency.

Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 drivers/char/tpm/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 8a8f692b6088..5f672f2c01b0 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -163,8 +163,7 @@ config TCG_NSC
 
 config TCG_ATMEL
 	tristate "Atmel TPM Interface"
-	depends on HAS_IOPORT_MAP
-	depends on HAS_IOPORT
+	depends on X86
 	help
 	  If you have a TPM security chip from Atmel say Yes and it 
 	  will be accessible from within Linux.  To compile this driver 
-- 
2.39.5 (Apple Git-154)

Re: [PATCH] tpm: atmel: depend on X86

[Jarkko Sakkinen]

On Sun, Jul 12, 2026 at 08:32:34PM +0200, Karl Mehltretter wrote:
> tpm_atmel probes for the chip at fixed x86 Super-I/O ports (0x4e) with
> inb()/outb(), so it only works on x86. TCG_ATMEL nevertheless depends
> only on HAS_IOPORT_MAP/HAS_IOPORT, which arm and arm64 also satisfy.
> There the probe is useless, and on platforms whose unbacked I/O access
> faults it oopses in init_atmel() at boot (e.g. arm/versatile):
> 
>   Unable to handle kernel paging request at virtual address fee0004e
>   PC is at init_atmel+0x34/0x244
> 
> TCG_NSC and TCG_TIS already "depends on X86" (commit 2f592f2a7d74 ("TPM:
> NSC and TIS drivers X86 dependency fix")); TCG_ATMEL was missed. Add the
> same dependency.
> 
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  drivers/char/tpm/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 8a8f692b6088..5f672f2c01b0 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -163,8 +163,7 @@ config TCG_NSC
>  
>  config TCG_ATMEL
>  	tristate "Atmel TPM Interface"
> -	depends on HAS_IOPORT_MAP
> -	depends on HAS_IOPORT
> +	depends on X86
>  	help
>  	  If you have a TPM security chip from Atmel say Yes and it 
>  	  will be accessible from within Linux.  To compile this driver 
> -- 
> 2.39.5 (Apple Git-154)
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko