From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Melo <arnaldo.melo@gmail.com>
Cc: Ian Rogers <irogers@google.com>,
linux-perf-users <linux-perf-users@vger.kernel.org>
Subject: Re: Getting positive, and not just negative, Sashiko reviews
Date: Wed, 22 Jul 2026 22:28:11 -0700 [thread overview]
Message-ID: <amGmayOYWbL_Uhny@google.com> (raw)
In-Reply-To: <E034E1D9-D2EA-428C-AD7C-A8F40B2E0E52@gmail.com>
Hello,
On Wed, Jul 22, 2026 at 08:30:04PM -0300, Arnaldo Melo wrote:
>
>
> On July 22, 2026 7:19:33 PM GMT-03:00, Ian Rogers <irogers@google.com> wrote:
> >Hi,
> >
> >I wanted to give a heads up. I sent out a 1 line email policy change
> >for linux-perf-users to get positive Sashiko reviews, not just
> >negative ones:
> >https://github.com/sashiko-dev/sashiko/pull/363
> >Please comment/complain if this upsets you and I can abandon the PR.
>
> And it's merged upstream already, let's see how it goes, I think it
> may be a good move.
>
> The maintainers summit list discussion (public) touches lots of
> aspects about Sashiko collaboration, we need to take its reviews with
> a grain of salt, but my experience so far is very positive, I've been
> using it locally for perf and pahole development, in a loop with
> Claude code, with very good results.
I'm also ok with getting positive reviews.
Thanks,
Namhyung
prev parent reply other threads:[~2026-07-23 5:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 22:19 Getting positive, and not just negative, Sashiko reviews Ian Rogers
2026-07-22 23:30 ` Arnaldo Melo
2026-07-23 5:28 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amGmayOYWbL_Uhny@google.com \
--to=namhyung@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.