All of lore.kernel.org
 help / color / mirror / Atom feed
* Getting positive, and not just negative, Sashiko reviews
@ 2026-07-22 22:19 Ian Rogers
  2026-07-22 23:30 ` Arnaldo Melo
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2026-07-22 22:19 UTC (permalink / raw)
  To: linux-perf-users

Hi,

I wanted to give a heads up. I sent out a 1 line email policy change
for linux-perf-users to get positive Sashiko reviews, not just
negative ones:
https://github.com/sashiko-dev/sashiko/pull/363
Please comment/complain if this upsets you and I can abandon the PR.

Thanks,
Ian

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: Getting positive, and not just negative, Sashiko reviews
  2026-07-22 22:19 Getting positive, and not just negative, Sashiko reviews Ian Rogers
@ 2026-07-22 23:30 ` Arnaldo Melo
  2026-07-23  5:28   ` Namhyung Kim
  0 siblings, 1 reply; 3+ messages in thread
From: Arnaldo Melo @ 2026-07-22 23:30 UTC (permalink / raw)
  To: Ian Rogers, linux-perf-users



On July 22, 2026 7:19:33 PM GMT-03:00, Ian Rogers <irogers@google.com> wrote:
>Hi,
>
>I wanted to give a heads up. I sent out a 1 line email policy change
>for linux-perf-users to get positive Sashiko reviews, not just
>negative ones:
>https://github.com/sashiko-dev/sashiko/pull/363
>Please comment/complain if this upsets you and I can abandon the PR.

And it's merged upstream already, let's see how it goes, I think it may be a good move. 

The maintainers summit list discussion (public) touches lots of aspects about Sashiko collaboration, we need to take its reviews with a grain of salt, but my experience so far is very positive, I've been using it locally for perf and pahole development, in a loop with Claude code, with very good results.

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: Getting positive, and not just negative, Sashiko reviews
  2026-07-22 23:30 ` Arnaldo Melo
@ 2026-07-23  5:28   ` Namhyung Kim
  0 siblings, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2026-07-23  5:28 UTC (permalink / raw)
  To: Arnaldo Melo; +Cc: Ian Rogers, linux-perf-users

Hello,

On Wed, Jul 22, 2026 at 08:30:04PM -0300, Arnaldo Melo wrote:
> 
> 
> On July 22, 2026 7:19:33 PM GMT-03:00, Ian Rogers <irogers@google.com> wrote:
> >Hi,
> >
> >I wanted to give a heads up. I sent out a 1 line email policy change
> >for linux-perf-users to get positive Sashiko reviews, not just
> >negative ones:
> >https://github.com/sashiko-dev/sashiko/pull/363
> >Please comment/complain if this upsets you and I can abandon the PR.
> 
> And it's merged upstream already, let's see how it goes, I think it
> may be a good move. 
> 
> The maintainers summit list discussion (public) touches lots of
> aspects about Sashiko collaboration, we need to take its reviews with
> a grain of salt, but my experience so far is very positive, I've been
> using it locally for perf and pahole development, in a loop with
> Claude code, with very good results.

I'm also ok with getting positive reviews.

Thanks,
Namhyung


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-23  5:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-22 22:19 Getting positive, and not just negative, Sashiko reviews Ian Rogers
2026-07-22 23:30 ` Arnaldo Melo
2026-07-23  5:28   ` Namhyung Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.