All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Doru Blânzeanu" <dblanzeanu@linux.microsoft.com>
To: Magnus Kulke <magnuskulke@linux.microsoft.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Magnus Kulke" <magnuskulke@microsoft.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Wei Liu" <wei.liu@kernel.org>,
	"Doru Blânzeanu" <doru.blanzeanu@microsoft.com>,
	"Wei Liu" <liuwe@microsoft.com>
Subject: Re: [PATCH 12/12] hw/i386/mshv: drop initial msi vector 0
Date: Thu, 23 Jul 2026 12:28:17 +0300	[thread overview]
Message-ID: <amHesdOJPThW0EAo@linux.microsoft.com> (raw)
In-Reply-To: <20260710101534.664604-13-magnuskulke@linux.microsoft.com>

On Fri, Jul 10, 2026 at 12:15:34PM +0200, Magnus Kulke wrote:
> This has been a warning before that was always raised if the machine has
> a hpet. hpet_reset() will eventually result in mshv_send_msi called w/
> vector 0, which we can safely drop.
> 
> Signed-off-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
> ---
>  hw/i386/mshv/apic.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/hw/i386/mshv/apic.c b/hw/i386/mshv/apic.c
> index 9188a93b2f..ad326030bf 100644
> --- a/hw/i386/mshv/apic.c
> +++ b/hw/i386/mshv/apic.c
> @@ -293,6 +293,16 @@ static void mshv_send_msi(MSIMessage *msi)
>      delivery     = (data >> MSI_DATA_DELIVERY_MODE_SHIFT) &
>                     MSI_DATA_DELIVERY_MODE_MASK;
>  
> +    /*
> +     * Vector 0 is not a valid interrupt vector (0-15 are reserved for CPU
> +     * exceptions). This can trigger during machine reset, if hpet_reset()
> +     * forces the PIT to pulse GSI 2 before IOAPIC's own reset has masked its
> +     * redirection entries.
> +     */
> +    if (vector == 0) {
> +        return;
> +    }
> +
>      mshv_request_interrupt(mshv_state, delivery, vector, dest, dest_mode,
>                             trigger_mode);
>  }
> -- 
> 2.34.1

Reviewed-by: Doru Blânzeanu <dblanzeanu@linux.microsoft.com>


      reply	other threads:[~2026-07-23  9:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 10:15 [PATCH 00/12] Add migration support to MSHV accelerator, Part 2 Magnus Kulke
2026-07-10 10:15 ` [PATCH 01/12] target/i386/mshv: disable AMX TILE features Magnus Kulke
2026-07-16 11:06   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 02/12] accel/mshv: introduce SaveVMHandler Magnus Kulke
2026-07-16 11:10   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 03/12] hw/i386/mshv: migrate REFERENCE_TIME Magnus Kulke
2026-07-16 12:01   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 04/12] accel/mshv: install dummy handler for SIG_IPI Magnus Kulke
2026-07-17 14:43   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 05/12] target/i386/mshv: migrate LAPIC state Magnus Kulke
2026-07-22 11:57   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 06/12] target/i386/mshv: migrate Synic SINT MSRs Magnus Kulke
2026-07-22 14:03   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 07/12] target/i386/mshv: migrate SIMP and SIEFP state Magnus Kulke
2026-07-22 14:12   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 08/12] target/i386/mshv: migrate STIMER state Magnus Kulke
2026-07-22 14:24   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 09/12] accel/mshv: write synthetic MSRs after migration Magnus Kulke
2026-07-23  8:24   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 10/12] target/i386/mshv: migrate MP_STATE Magnus Kulke
2026-07-23  9:25   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 11/12] target/i386/mshv: toggle fpu/xsave migration Magnus Kulke
2026-07-23  9:27   ` Doru Blânzeanu
2026-07-10 10:15 ` [PATCH 12/12] hw/i386/mshv: drop initial msi vector 0 Magnus Kulke
2026-07-23  9:28   ` Doru Blânzeanu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amHesdOJPThW0EAo@linux.microsoft.com \
    --to=dblanzeanu@linux.microsoft.com \
    --cc=doru.blanzeanu@microsoft.com \
    --cc=liuwe@microsoft.com \
    --cc=magnuskulke@linux.microsoft.com \
    --cc=magnuskulke@microsoft.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=wei.liu@kernel.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.