From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port()
Date: Fri, 24 Jul 2026 09:58:13 +0200 [thread overview]
Message-ID: <amMZoJ41FKcd2ddG@monoceros> (raw)
In-Reply-To: <20260723231359.5d7fa1e8e11990fa00c476f4@hugovil.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Thu, Jul 23, 2026 at 11:13:59PM -0400, Hugo Villeneuve wrote:
> > For me the open question remains if the driver works in the
> > configuration CONFIG_SERIAL_8250=y (and thus CONFIG_SERIAL_CORE=y) +
> > CONFIG_SERIAL_8250_HUB6=m. In this case at least commit
> > 3d406299d8829747fe2e8692f4c29fe3dc1d101f +
> > https://lore.kernel.org/linux-serial/20260715153707.4181828-1-hugo@hugovil.com/
> > introduces a logical change in uart_match_port() that isn't explained in
> > the commit log.
>
> Not sure what you mean by that logical change?
With said configuration and before
3d406299d8829747fe2e8692f4c29fe3dc1d101f uart_match_port() returned
port1->iobase == port2->iobase && port1->hub6 == port2->hub6
and with 3d406299d8829747fe2e8692f4c29fe3dc1d101f (and your fix on top)
it returns false (because when drivers/tty/serial/serial_core.c is
compiled IS_REACHABLE(CONFIG_SERIAL_8250_HUB6) evaluates to false).
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-07-24 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 8:08 [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port() Uwe Kleine-König (The Capable Hub)
2026-07-20 10:31 ` Uwe Kleine-König (The Capable Hub)
2026-07-20 14:07 ` Hugo Villeneuve
2026-07-20 21:18 ` Uwe Kleine-König
2026-07-20 22:53 ` Hugo Villeneuve
2026-07-23 4:37 ` Uwe Kleine-König
2026-07-24 3:13 ` Hugo Villeneuve
2026-07-24 7:58 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amMZoJ41FKcd2ddG@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.