From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port()
Date: Thu, 30 Jul 2026 21:57:01 +0200 [thread overview]
Message-ID: <amusQjI0DOPzL4jM@monoceros> (raw)
In-Reply-To: <2026073028-anointer-unlinked-c0ea@gregkh>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
Hello Hugo,
On Thu, Jul 30, 2026 at 04:49:45PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 29, 2026 at 03:30:57PM +0200, Uwe Kleine-König wrote:
> > I think the real fix would be to just copy uart_match_port() into the
> > two drivers that actually use it (and remove the then dead code paths).
> > Then it would be drivers/tty/serial/8250/8250_core.c using
> > hub6_match_port() only and that can be handled by a proper dependency.
>
> I'm totally confused, so I'll drop this patch from my review queue and
> wait for you all to figure it out :)
Does my suggestion make sense for you? Do you intend to work on this to
unconfuse Greg?
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-30 19:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 8:08 [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port() Uwe Kleine-König (The Capable Hub)
2026-07-20 10:31 ` Uwe Kleine-König (The Capable Hub)
2026-07-20 14:07 ` Hugo Villeneuve
2026-07-20 21:18 ` Uwe Kleine-König
2026-07-20 22:53 ` Hugo Villeneuve
2026-07-23 4:37 ` Uwe Kleine-König
2026-07-24 3:13 ` Hugo Villeneuve
2026-07-24 7:58 ` Uwe Kleine-König
2026-07-27 15:22 ` Hugo Villeneuve
2026-07-27 15:26 ` Hugo Villeneuve
2026-07-29 13:30 ` Uwe Kleine-König
2026-07-30 14:49 ` Greg Kroah-Hartman
2026-07-30 19:57 ` Uwe Kleine-König [this message]
2026-07-30 20:15 ` Hugo Villeneuve
2026-07-31 13:20 ` Uwe Kleine-König
2026-07-31 13:59 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amusQjI0DOPzL4jM@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.