* [PATCH net-next] bridge: mrp: fix MRP_Test option TLV length
@ 2026-07-24 5:12 David Corvaglia
2026-07-25 14:51 ` Nikolay Aleksandrov
0 siblings, 1 reply; 2+ messages in thread
From: David Corvaglia @ 2026-07-24 5:12 UTC (permalink / raw)
To: Nikolay Aleksandrov, Ido Schimmel, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Simon Horman, bridge, netdev, linux-kernel, David Corvaglia
oui is a pointer, so sizeof(oui) is the pointer size. The MRA
Option TLV thus advertises a wrong length (15 vs 10 on x86_64),
causing misparsing of the frame on peers. Fix is to replace
with sizeof(*oui).
Signed-off-by: David Corvaglia <david@corvaglia.dev>
---
net/bridge/br_mrp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_mrp.c b/net/bridge/br_mrp.c
index 3f7126a7d720..179d2470b724 100644
--- a/net/bridge/br_mrp.c
+++ b/net/bridge/br_mrp.c
@@ -215,7 +215,7 @@ static struct sk_buff *br_mrp_alloc_test_skb(struct br_mrp *mrp,
struct br_mrp_oui_hdr *oui = NULL;
u8 length;
- length = sizeof(*sub_opt) + sizeof(*sub_tlv) + sizeof(oui) +
+ length = sizeof(*sub_opt) + sizeof(*sub_tlv) + sizeof(*oui) +
MRP_OPT_PADDING;
br_mrp_skb_tlv(skb, BR_MRP_TLV_HEADER_OPTION, length);
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] bridge: mrp: fix MRP_Test option TLV length
2026-07-24 5:12 [PATCH net-next] bridge: mrp: fix MRP_Test option TLV length David Corvaglia
@ 2026-07-25 14:51 ` Nikolay Aleksandrov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Aleksandrov @ 2026-07-25 14:51 UTC (permalink / raw)
To: David Corvaglia
Cc: Ido Schimmel, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, bridge, netdev, linux-kernel
On Fri, Jul 24, 2026 at 05:12:02AM +0000, David Corvaglia wrote:
> oui is a pointer, so sizeof(oui) is the pointer size. The MRA
> Option TLV thus advertises a wrong length (15 vs 10 on x86_64),
> causing misparsing of the frame on peers. Fix is to replace
> with sizeof(*oui).
>
> Signed-off-by: David Corvaglia <david@corvaglia.dev>
> ---
> net/bridge/br_mrp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_mrp.c b/net/bridge/br_mrp.c
> index 3f7126a7d720..179d2470b724 100644
> --- a/net/bridge/br_mrp.c
> +++ b/net/bridge/br_mrp.c
> @@ -215,7 +215,7 @@ static struct sk_buff *br_mrp_alloc_test_skb(struct br_mrp *mrp,
> struct br_mrp_oui_hdr *oui = NULL;
> u8 length;
>
> - length = sizeof(*sub_opt) + sizeof(*sub_tlv) + sizeof(oui) +
> + length = sizeof(*sub_opt) + sizeof(*sub_tlv) + sizeof(*oui) +
> MRP_OPT_PADDING;
> br_mrp_skb_tlv(skb, BR_MRP_TLV_HEADER_OPTION, length);
>
> --
> 2.55.0
>
This is clearly a fix and looks like it is needed for proper parsing.
I think it should be targeted at -net with a fixes tag, probably
f7458934b0791 ("net: bridge: mrp: Update the Test frames for MRA")
Cheers,
Nik
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-25 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-24 5:12 [PATCH net-next] bridge: mrp: fix MRP_Test option TLV length David Corvaglia
2026-07-25 14:51 ` Nikolay Aleksandrov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.