From: Akash Sukhavasi <akash.sukhavasi@gmail.com>
To: Doug Anderson <dianders@chromium.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH] drm/panel: tdo-tl070wsh30: Use mipi_dsi_*_multi() functions
Date: Sat, 25 Jul 2026 21:37:44 -0500 [thread overview]
Message-ID: <amU_GppAwt3XXPX-@gmail.com> (raw)
In-Reply-To: <20260725170134.035EB1F000E9@smtp.kernel.org>
On Sat, Jul 25, 2026 at 05:01:33PM +0000, sashiko-bot@kernel.org wrote:
> [Severity: High]
> Does returning early here on a DSI transmission error leave the panel in an
> unrecoverable state?
>
> Because panel->prepared is never set to false on error, a subsequent call
> to drm_panel_prepare() will immediately return 0 without re-running the
> hardware initialization sequence, leaving the display permanently blank
> until a system reboot.
>
> Could we unconditionally disable the regulator and return 0 here to ensure
> the state machine remains synchronized, even if there are DSI errors?
Agreed, and this is the alternative I raised below the cut in this
patch.
Unless anyone objects, I will send a v2 that disables the regulator
unconditionally and returns 0.
Sashiko AI review: https://sashiko.dev/#/patchset/20260725-mipi-dsi-tl070wsh30-multi-v1-1-69160b83982e@gmail.com?part=1
--
Thanks,
Akash
next parent reply other threads:[~2026-07-26 2:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260725170134.035EB1F000E9@smtp.kernel.org>
2026-07-26 2:37 ` Akash Sukhavasi [this message]
2026-07-25 16:56 [PATCH] drm/panel: tdo-tl070wsh30: Use mipi_dsi_*_multi() functions Akash Sukhavasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amU_GppAwt3XXPX-@gmail.com \
--to=akash.sukhavasi@gmail.com \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.