From: Lukas <lukas.metz@gmx.net>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Siratul Islam" <siratul.islam@linux.dev>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: dac: dac8163: Add driver for DAC8163
Date: Sun, 26 Jul 2026 20:46:23 +0200 [thread overview]
Message-ID: <amZV_2_dsNZmp7Bb@berta-MS-7693> (raw)
In-Reply-To: <20260726191833.67dcfac2@jic23-huawei>
On Sun, Jul 26, 2026 at 07:18:33PM +0100, Jonathan Cameron wrote:
>
> As this has come up, I'd favour just having two static const regmap_config structures
> and picking between them. Obviously I haven't checked but I'd guess that any
> overhead of extra text data for those is not that different to the extra code of the current
> approach. Generally if you can make this sort of thing data rather than code it
> is a net gain.
>
> Jonathan
I actually misspoke before. Since all dacxxx3 devices have different
default values (mid-scale varies for different resolutions), 4
different reg_defaults are needed to cover all the devices. I could
define 4 static const regmap_configs and pick between them or go with
Siratul Islams approach.
Best regards
Lukas
next prev parent reply other threads:[~2026-07-26 18:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 9:52 [PATCH v2 0/2] Add driver for DAC8163: Lukas Metz
2026-07-08 9:52 ` [PATCH v2 1/2] dt-bindings: iio: dac: Add DAC8163 Lukas Metz
2026-07-08 10:06 ` sashiko-bot
2026-07-08 16:37 ` Conor Dooley
2026-07-14 15:01 ` Lukas
2026-07-14 16:49 ` Conor Dooley
2026-07-14 19:25 ` David Lechner
2026-07-08 9:52 ` [PATCH v2 2/2] iio: dac: dac8163: Add driver for DAC8163 Lukas Metz
2026-07-08 10:04 ` sashiko-bot
2026-07-08 11:32 ` Andy Shevchenko
2026-07-09 10:03 ` Lukas
2026-07-09 10:19 ` Andy Shevchenko
2026-07-08 15:58 ` Siratul Islam
2026-07-08 17:33 ` Jonathan Cameron
2026-07-08 19:04 ` Siratul Islam
2026-07-26 14:10 ` Lukas
2026-07-26 17:01 ` Siratul Islam
2026-07-26 18:18 ` Jonathan Cameron
2026-07-26 18:46 ` Lukas [this message]
2026-07-26 18:52 ` Siratul Islam
2026-07-26 18:48 ` Siratul Islam
2026-07-12 22:23 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amZV_2_dsNZmp7Bb@berta-MS-7693 \
--to=lukas.metz@gmx.net \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=siratul.islam@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.