From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Paul Walmsley <pjw@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
Subject: Re: [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver
Date: Mon, 3 Aug 2026 00:23:44 +0200 [thread overview]
Message-ID: <am_CzLdCkMKeRv_F@monoceros> (raw)
In-Reply-To: <20260801072711.153217-5-changhuang.liang@starfivetech.com>
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
Hello,
On Sat, Aug 01, 2026 at 12:26:54AM -0700, Changhuang Liang wrote:
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
Please don't include <linux/mod_devicetable.h>, which will go away soon.
<linux/platform_device.h> already contains the necessary bits to have
of_device_id defined, so you can just drop the #include for
<linux/mod_devicetable.h>.
This also affects several other patches in this series.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Paul Walmsley <pjw@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
Subject: Re: [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver
Date: Mon, 3 Aug 2026 00:23:44 +0200 [thread overview]
Message-ID: <am_CzLdCkMKeRv_F@monoceros> (raw)
In-Reply-To: <20260801072711.153217-5-changhuang.liang@starfivetech.com>
[-- Attachment #1.1: Type: text/plain, Size: 456 bytes --]
Hello,
On Sat, Aug 01, 2026 at 12:26:54AM -0700, Changhuang Liang wrote:
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
Please don't include <linux/mod_devicetable.h>, which will go away soon.
<linux/platform_device.h> already contains the necessary bits to have
of_device_id defined, so you can just drop the #include for
<linux/mod_devicetable.h>.
This also affects several other patches in this series.
Best regards
Uwe
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-08-02 22:23 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 7:26 [PATCH v4 00/21] Add basic pinctrl drivers for JHB100 SoC Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-01 7:26 ` [PATCH v4 01/21] dt-bindings: pincfg-node: Add property 'input-debounce-ns' Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-03 14:13 ` Rob Herring
2026-08-03 14:13 ` Rob Herring
2026-08-04 1:12 ` Changhuang Liang
2026-08-04 1:12 ` Changhuang Liang
2026-08-01 7:26 ` [PATCH v4 02/21] pinctrl: pinconf-generic: " Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-01 7:26 ` [PATCH v4 03/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0-pinctrl Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-01 7:26 ` [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-02 22:23 ` Uwe Kleine-König [this message]
2026-08-02 22:23 ` Uwe Kleine-König
2026-08-04 1:09 ` Changhuang Liang
2026-08-04 1:09 ` Changhuang Liang
2026-08-03 15:28 ` Philipp Zabel
2026-08-03 15:28 ` Philipp Zabel
2026-08-04 1:21 ` Changhuang Liang
2026-08-04 1:21 ` Changhuang Liang
2026-08-04 20:30 ` Linus Walleij
2026-08-04 20:30 ` Linus Walleij
2026-08-01 7:26 ` [PATCH v4 05/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0h-pinctrl Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-05 21:30 ` Rob Herring
2026-08-05 21:30 ` Rob Herring
2026-08-06 6:27 ` Changhuang Liang
2026-08-06 6:27 ` Changhuang Liang
2026-08-01 7:26 ` [PATCH v4 06/21] pinctrl: starfive: Add StarFive JHB100 sys0h controller driver Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-01 7:26 ` [PATCH v4 07/21] dt-bindings: pinctrl: Add starfive,jhb100-sys1-pinctrl Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-01 7:26 ` [PATCH v4 08/21] pinctrl: starfive: Add StarFive JHB100 sys1 controller driver Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-01 7:26 ` [PATCH v4 09/21] dt-bindings: pinctrl: Add starfive,jhb100-sys2-pinctrl Changhuang Liang
2026-08-01 7:26 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 10/21] pinctrl: starfive: Add StarFive JHB100 sys2 controller driver Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 11/21] dt-bindings: pinctrl: Add starfive,jhb100-per0-pinctrl Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 12/21] pinctrl: starfive: Add StarFive JHB100 per0 controller driver Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 13/21] dt-bindings: pinctrl: Add starfive,jhb100-per1-pinctrl Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 14/21] pinctrl: starfive: Add StarFive JHB100 per1 controller driver Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 15/21] dt-bindings: pinctrl: Add starfive,jhb100-per2-pinctrl Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 16/21] pinctrl: starfive: Add StarFive JHB100 per2 controller driver Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 17/21] dt-bindings: pinctrl: Add starfive,jhb100-per2pok-pinctrl Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 18/21] pinctrl: starfive: Add StarFive JHB100 per2pok controller driver Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 19/21] dt-bindings: pinctrl: Add starfive,jhb100-per3-pinctrl Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 20/21] pinctrl: starfive: Add StarFive JHB100 per3 controller driver Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
2026-08-01 7:27 ` [PATCH v4 21/21] riscv: dts: starfive: jhb100: Add pinctrl nodes Changhuang Liang
2026-08-01 7:27 ` Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am_CzLdCkMKeRv_F@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=brgl@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=lianfeng.ouyang@starfivetech.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.