From: Tejun Heo <tj@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
marco.crivellari@suse.com
Subject: Re: [PATCH 4/6] workqueue: account nr_active by the backing pool
Date: Sun, 2 Aug 2026 14:34:16 -1000 [thread overview]
Message-ID: <am_iCGcm8XqbQxSF@slm.duckdns.org> (raw)
In-Reply-To: <20260731-wq-pool-refactor-v1-4-8eaf71cdab5f@debian.org>
Hello,
On Fri, Jul 31, 2026 at 04:57:36AM -0700, Breno Leitao wrote:
> @@ -1796,6 +1799,10 @@ static bool pwq_tryinc_nr_active(struct pool_workqueue *pwq, bool fill)
> if (unlikely(pwq->plugged))
> return false;
>
> + nna = wq_node_nr_active(wq, pool->node);
> + if (WARN_ON_ONCE(!nna))
> + return false;
Would it make sense to turn WQ_UNBOUND test in wq_node_nr_active() into a
WARN_ON_ONCE()? And I don't think the return value needs a null check.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-08-03 0:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 11:57 [PATCH 0/6] workqueue: base pwq pool release and nr_active on the backing pool Breno Leitao
2026-07-31 11:57 ` [PATCH 1/6] workqueue: factor out get_percpu_pool() Breno Leitao
2026-07-31 11:57 ` [PATCH 2/6] workqueue: factor out alloc_and_link_percpu_pwqs() Breno Leitao
2026-07-31 11:57 ` [PATCH 3/6] workqueue: release pwq pools by pool type Breno Leitao
2026-08-03 0:31 ` Tejun Heo
2026-08-03 14:02 ` Breno Leitao
2026-08-03 16:50 ` Tejun Heo
2026-07-31 11:57 ` [PATCH 4/6] workqueue: account nr_active by the backing pool Breno Leitao
2026-08-03 0:34 ` Tejun Heo [this message]
2026-08-03 14:19 ` Breno Leitao
2026-07-31 11:57 ` [PATCH 5/6] workqueue: add a per-cpu backend for unbound pwqs Breno Leitao
2026-08-03 0:36 ` Tejun Heo
2026-08-03 16:35 ` Breno Leitao
2026-08-03 16:58 ` Tejun Heo
2026-07-31 11:57 ` [PATCH 6/6] workqueue: install per-cpu pwqs at creation for __WQ_PERCPU_POOLS Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am_iCGcm8XqbQxSF@slm.duckdns.org \
--to=tj@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.