All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org, kernel-team@meta.com,
	marco.crivellari@suse.com
Subject: Re: [PATCH 5/6] workqueue: add a per-cpu backend for unbound pwqs
Date: Sun, 2 Aug 2026 14:36:52 -1000	[thread overview]
Message-ID: <am_ipG3sFGybrX2M@slm.duckdns.org> (raw)
In-Reply-To: <20260731-wq-pool-refactor-v1-5-8eaf71cdab5f@debian.org>

Hello,

On Fri, Jul 31, 2026 at 04:57:37AM -0700, Breno Leitao wrote:
> Add alloc_percpu_pwq(), which binds a pwq to get_percpu_pool(wq, cpu),
> and an internal __WQ_PERCPU_POOLS flag. unbound_wq_update_pwq() installs
> such a pwq per CPU when the flag is set, reusing the existing
> install/drain path. Pool release and nr_active are already keyed on the
> backing pool, so a per-cpu-backed pwq is torn down and throttled
> correctly.
> 
> PS: We can do this using if/else for per cpu/unbound as well, instead of
> this labels:, would it be better?

So, we would have percpu-pool backed unbound workqueues in addition to the
existing percpu workqueues? I'm not sure that makes sense. What prevents
unifying them?

Thanks.

-- 
tejun

  reply	other threads:[~2026-08-03  0:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 11:57 [PATCH 0/6] workqueue: base pwq pool release and nr_active on the backing pool Breno Leitao
2026-07-31 11:57 ` [PATCH 1/6] workqueue: factor out get_percpu_pool() Breno Leitao
2026-07-31 11:57 ` [PATCH 2/6] workqueue: factor out alloc_and_link_percpu_pwqs() Breno Leitao
2026-07-31 11:57 ` [PATCH 3/6] workqueue: release pwq pools by pool type Breno Leitao
2026-08-03  0:31   ` Tejun Heo
2026-08-03 14:02     ` Breno Leitao
2026-08-03 16:50       ` Tejun Heo
2026-07-31 11:57 ` [PATCH 4/6] workqueue: account nr_active by the backing pool Breno Leitao
2026-08-03  0:34   ` Tejun Heo
2026-08-03 14:19     ` Breno Leitao
2026-07-31 11:57 ` [PATCH 5/6] workqueue: add a per-cpu backend for unbound pwqs Breno Leitao
2026-08-03  0:36   ` Tejun Heo [this message]
2026-08-03 16:35     ` Breno Leitao
2026-08-03 16:58       ` Tejun Heo
2026-07-31 11:57 ` [PATCH 6/6] workqueue: install per-cpu pwqs at creation for __WQ_PERCPU_POOLS Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=am_ipG3sFGybrX2M@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.